briar issueshttps://code.briarproject.org/groups/briar/-/issues2018-06-12T11:32:20Zhttps://code.briarproject.org/briar/briar/-/issues/597gradle connectedCheck fails due to method limit2018-06-12T11:32:20ZTorsten Grotegradle connectedCheck fails due to method limit```
Execution failed for task ':briar-android-tests:transformClassesWithDexForDebugAndroidTest'.
> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionExcep...```
Execution failed for task ':briar-android-tests:transformClassesWithDexForDebugAndroidTest'.
> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexIndexOverflowException: method ID not in [0, 0xffff]: 65536
```Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/595Clients should decide whether to share messages2018-06-12T11:32:20ZakwizgranClients should decide whether to share messagesThe validation manager currently sets all messages as shared after delivering them. Clients should specify which messages to share, for example by returning a boolean from the delivery hook or calling DatabaseComponent#setMessageShared()...The validation manager currently sets all messages as shared after delivering them. Clients should specify which messages to share, for example by returning a boolean from the delivery hook or calling DatabaseComponent#setMessageShared() from within the delivery hook.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/593Make the user's own identities visually distinct2018-06-12T11:32:20ZakwizgranMake the user's own identities visually distinctThe user's own identities have no trust indicator (zero hashes). In a context such as forums or the combined blog feed, this makes the user's own identities look like they're less trusted than strangers (one hash), unverified contacts (t...The user's own identities have no trust indicator (zero hashes). In a context such as forums or the combined blog feed, this makes the user's own identities look like they're less trusted than strangers (one hash), unverified contacts (two hashes), or verified contacts (three hashes).
Make the user's own identities visually distinct in some way to prevent any confusion.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/591Add New Message Types to BlogValidator2018-06-12T11:32:20ZTorsten GroteAdd New Message Types to BlogValidatorSub-Ticket of #494 and #437.Sub-Ticket of #494 and #437.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/587java.lang.IllegalStateException: No Group in intent.2018-06-12T11:32:20Zligijava.lang.IllegalStateException: No Group in intent.on 44d13ef28eb929b1051d7917f392f2aa8cb589ae
when pressing up-affordance from blog - would try to reproduce a bit more but having to enter my Password again after each crash is a bit disencouraging -
cannot even make a simple passw...on 44d13ef28eb929b1051d7917f392f2aa8cb589ae
when pressing up-affordance from blog - would try to reproduce a bit more but having to enter my Password again after each crash is a bit disencouraging -
cannot even make a simple password for testing - how do you guys do this?-)
```
08-08 16:51:17.150 15782 15782 E ACRA : ACRA caught a RuntimeException for org.briarproject
08-08 16:51:17.150 15782 15782 E ACRA : java.lang.RuntimeException: Unable to start activity ComponentInfo{org.briarproject/org.briarproject.android.blogs.BlogActivity}: java.lang.IllegalStateException: No Group in intent.
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3253)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3349)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread.access$1100(ActivityThread.java:221)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1794)
08-08 16:51:17.150 15782 15782 E ACRA : at android.os.Handler.dispatchMessage(Handler.java:102)
08-08 16:51:17.150 15782 15782 E ACRA : at android.os.Looper.loop(Looper.java:158)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread.main(ActivityThread.java:7225)
08-08 16:51:17.150 15782 15782 E ACRA : at java.lang.reflect.Method.invoke(Native Method)
08-08 16:51:17.150 15782 15782 E ACRA : at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
08-08 16:51:17.150 15782 15782 E ACRA : at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
08-08 16:51:17.150 15782 15782 E ACRA : Caused by: java.lang.IllegalStateException: No Group in intent.
08-08 16:51:17.150 15782 15782 E ACRA : at org.briarproject.android.blogs.BlogActivity.onCreate(BlogActivity.java:61)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.Activity.performCreate(Activity.java:6876)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1135)
08-08 16:51:17.150 15782 15782 E ACRA : at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3206)
08-08 16:51:17.150 15782 15782 E ACRA : ... 9 more
```Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/583NPE @ org.briarproject.android.util.QrCodeUtils.createQrCode2018-06-12T11:32:21ZligiNPE @ org.briarproject.android.util.QrCodeUtils.createQrCode```
08-07 21:32:41.258 25424 25424 I CameraView: Surface created
08-07 21:32:41.259 25424 25424 I CameraView: Surface changed: 1200x1648
08-07 21:32:41.268 25424 25424 D AndroidRuntime: Shutting down VM
08-07 21:32:41.269 25424 25424...```
08-07 21:32:41.258 25424 25424 I CameraView: Surface created
08-07 21:32:41.259 25424 25424 I CameraView: Surface changed: 1200x1648
08-07 21:32:41.268 25424 25424 D AndroidRuntime: Shutting down VM
08-07 21:32:41.269 25424 25424 E ACRA : ACRA caught a NullPointerException for org.briarproject
08-07 21:32:41.269 25424 25424 E ACRA : java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.WindowManager android.app.Activity.getWindowManager()' on a null object reference
08-07 21:32:41.269 25424 25424 E ACRA : at org.briarproject.android.util.QrCodeUtils.createQrCode(QrCodeUtils.java:25)
08-07 21:32:41.269 25424 25424 E ACRA : at org.briarproject.android.keyagreement.ShowQrCodeFragment$5.run(ShowQrCodeFragment.java:298)
08-07 21:32:41.269 25424 25424 E ACRA : at android.os.Handler.handleCallback(Handler.java:739)
08-07 21:32:41.269 25424 25424 E ACRA : at android.os.Handler.dispatchMessage(Handler.java:95)
08-07 21:32:41.269 25424 25424 E ACRA : at android.os.Looper.loop(Looper.java:148)
08-07 21:32:41.269 25424 25424 E ACRA : at android.app.ActivityThread.main(ActivityThread.java:5417)
08-07 21:32:41.269 25424 25424 E ACRA : at java.lang.reflect.Method.invoke(Native Method)
08-07 21:32:41.269 25424 25424 E ACRA : at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
08-07 21:32:41.269 25424 25424 E ACRA : at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
```
happens on 44d13ef28eb929b1051d7917f392f2aa8cb589ae
when trying to add a new contact on a Nexus 7 stock android 6.0.1 - works on my Note4 though ( also 6.0.1 )Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/582Tor GeoIP file is not updated2018-06-12T11:32:21ZakwizgranTor GeoIP file is not updatedIf the Tor plugin has already installed a GeoIP file on the device, it will not install a newer version.If the Tor plugin has already installed a GeoIP file on the device, it will not install a newer version.Milestone Dakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/580Introduced Contacts Have Status VERIFIED2018-06-12T11:32:21ZTorsten GroteIntroduced Contacts Have Status VERIFIEDIntroduced contacts appear fully verified, even though they should be UNVERIFIED.Introduced contacts appear fully verified, even though they should be UNVERIFIED.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/579Unsubscribe From Shared Blogs2018-06-12T11:32:21ZTorsten GroteUnsubscribe From Shared BlogsIt is now possible to share personal blogs of your contacts with others, but it is not yet possible to unsubscribe again from these blogs.
This should work analogous to forums with the exception that you can not unsubscribe from perso...It is now possible to share personal blogs of your contacts with others, but it is not yet possible to unsubscribe again from these blogs.
This should work analogous to forums with the exception that you can not unsubscribe from personal blogs that belong to your contacts.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/578Another app may bind the Tor ports2018-06-12T11:32:21ZakwizgranAnother app may bind the Tor portsAnother app may bind the ports that Briar uses for communicating with Tor. If Briar finds that the control port is already bound at startup it will assume Tor is already running and not start its own Tor process.
Briar will pass confi...Another app may bind the ports that Briar uses for communicating with Tor. If Briar finds that the control port is already bound at startup it will assume Tor is already running and not start its own Tor process.
Briar will pass confidential data over the control port, including the Tor authentication cookie and the hidden service private key.
Briar will also pass confidential data over the proxy port, including the hidden service addresses of contacts and encrypted BTP streams and crash reports.Milestone Dakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/576Empty State Messages Are Briefly Shown When They Shouldn't2018-06-12T11:32:21ZTorsten GroteEmpty State Messages Are Briefly Shown When They Shouldn'tFor the Contact List, Forums and Private Conversations, the empty state messages show up briefly when clicking around to open new Activities. This is a regression that must have been introduced recently.For the Contact List, Forums and Private Conversations, the empty state messages show up briefly when clicking around to open new Activities. This is a regression that must have been introduced recently.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/575Fix SharerLeavesBeforeResponse Test2018-06-12T11:32:21ZTorsten GroteFix SharerLeavesBeforeResponse TestThis test was broken by a51d2f47af7674fef8c97aac631608daee675ae6This test was broken by a51d2f47af7674fef8c97aac631608daee675ae6Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/572Tor Plugin Fails to Shutdown Prevents SignOut2018-06-12T11:32:21ZTorsten GroteTor Plugin Fails to Shutdown Prevents SignOutI observed two times already that Briar does not sign out, because the Tor plugin does not shut down properly.
To be honest that might be due to me running two instances of Briar on the same phone which was probably not meant to happe...I observed two times already that Briar does not sign out, because the Tor plugin does not shut down properly.
To be honest that might be due to me running two instances of Briar on the same phone which was probably not meant to happen. However, other applications might also open hidden services on the phone which might lead to the same problem.Milestone Dakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/571NPE in FeedFragment2018-06-12T11:32:21ZakwizgranNPE in FeedFragmentThe app crashed after using the back button to leave the blog feed. The stacktrace comes from a branch, so the line numbers may be slightly different from those on master, but as far as I can see the exception was caused by getActivity()...The app crashed after using the back button to leave the blog feed. The stacktrace comes from a branch, so the line numbers may be slightly different from those on master, but as far as I can see the exception was caused by getActivity() returning null, which would happen in the same way on master.
```
08-02 18:18:01.398 12121-12165/org.briarproject E/ACRA: ACRA caught a NullPointerException for org.briarproject
java.lang.NullPointerException
at org.briarproject.android.blogs.FeedFragment.onBlogPostAdded(FeedFragment.java:164)
at org.briarproject.android.blogs.FeedControllerImpl$3.run(FeedControllerImpl.java:144)
at org.briarproject.android.controller.DbControllerImpl$1.run(DbControllerImpl.java:35)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1088)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:581)
at java.lang.Thread.run(Thread.java:1027)
```Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/568Notifications aren't blocked when viewing a single blog2018-06-12T11:32:21ZakwizgranNotifications aren't blocked when viewing a single blogMilestone Dakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/566Raise minimum Android version to 42018-06-12T11:32:21ZakwizgranRaise minimum Android version to 4* Raise minimum API version to 14
* Remove any code and resources that only apply to older versions
* Close as rejected any tickets that only apply to older versions
* Raise minimum API version to 14
* Remove any code and resources that only apply to older versions
* Close as rejected any tickets that only apply to older versions
Milestone Dhttps://code.briarproject.org/briar/briar/-/issues/565Forums sometimes appear empty2018-06-12T11:32:21ZakwizgranForums sometimes appear emptyForums that contain posts occasionally appear empty. The progress wheel disappears and the empty state message is not shown, but no posts are shown either (see screenshot). Destroying and recreating the activity (eg. by rotating the scre...Forums that contain posts occasionally appear empty. The progress wheel disappears and the empty state message is not shown, but no posts are shown either (see screenshot). Destroying and recreating the activity (eg. by rotating the screen) *usually* causes the posts to appear, but pausing and resuming the activity (e.g. by turning the screen off and on again) doesn't.
I haven't worked out how to reproduce this bug reliably yet, but it can be reproduced eventually by repeatedly moving between the forum and the forum list. I think it may be caused by a race between loading the posts and starting/stopping updates of the BriarRecyclerView. Most other activities load their content from onResume() rather than onCreate(), which would solve the race if it exists.
![device-2016-08-01-183239](/uploads/4123e4d357c340000e682dc00eae8669/device-2016-08-01-183239.png)Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/564Wrong message counts in new message notifications2018-06-12T11:32:21ZakwizgranWrong message counts in new message notificationsIf messages arrive in a group while notifications are blocked for that group, AndroidNotificationManagerImpl still updates its new message count for that group and its total new message count. If the user unsubscribes from the group, e.g...If messages arrive in a group while notifications are blocked for that group, AndroidNotificationManagerImpl still updates its new message count for that group and its total new message count. If the user unsubscribes from the group, e.g. by removing a contact or leaving a forum, the wrongly counted messages are included in the total displayed in the new message notification until the user signs out.Milestone Dakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/563NPE when switching between contacts and forums at startup2018-06-12T11:32:21ZakwizgranNPE when switching between contacts and forums at startupAt startup, while the contact list was loading, I switched to the forum activity and back. The app crashed with the following stacktrace:
```
08-01 15:55:43.290 10492-10726/org.briarproject E/ACRA: ACRA caught a NullPointerException ...At startup, while the contact list was loading, I switched to the forum activity and back. The app crashed with the following stacktrace:
```
08-01 15:55:43.290 10492-10726/org.briarproject E/ACRA: ACRA caught a NullPointerException for org.briarproject
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getString(int, java.lang.Object[])' on a null object reference
at org.briarproject.android.contact.ConversationItem.from(ConversationItem.java:113)
at org.briarproject.android.contact.ContactListFragment.getMessages(ContactListFragment.java:414)
at org.briarproject.android.contact.ContactListFragment.access$200(ContactListFragment.java:68)
at org.briarproject.android.contact.ContactListFragment$2.run(ContactListFragment.java:211)
at org.briarproject.android.controller.DbControllerImpl$1.run(DbControllerImpl.java:35)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)
```Milestone Dhttps://code.briarproject.org/briar/briar/-/issues/562NPE in ContactListFragment2018-06-12T11:32:22ZTorsten GroteNPE in ContactListFragmentThis NPE happens when quickly switching to another fragment after the app started. Maybe `getActivity()` which seems to be called from the DbThread returns no proper context when the fragment has been hidden.
```
08-01 11:53:19.814 E/A...This NPE happens when quickly switching to another fragment after the app started. Maybe `getActivity()` which seems to be called from the DbThread returns no proper context when the fragment has been hidden.
```
08-01 11:53:19.814 E/ACRA: ACRA caught a NullPointerException for org.briarproject
java.lang.NullPointerException
at org.briarproject.android.contact.ConversationItem.from(ConversationItem.java:130)
at org.briarproject.android.contact.ContactListFragment.getMessages(ContactListFragment.java:414)
at org.briarproject.android.contact.ContactListFragment.access$200(ContactListFragment.java:68)
at org.briarproject.android.contact.ContactListFragment$2.run(ContactListFragment.java:212)
at org.briarproject.android.controller.DbControllerImpl$1.run(DbControllerImpl.java:35)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
```Milestone DTorsten GroteTorsten Grote