briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-04-03T10:36:36Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/165Relate a successfully added contact to the pending contact by an event2022-04-03T10:36:36ZMikolai GütschowRelate a successfully added contact to the pending contact by an eventSee https://code.briarproject.org/briar/briar-desktop/-/merge_requests/51#note_58786:
> The ContactManager method that converts a PendingContact into a Contact could broadcast an event with both IDs, if that would help?
>
> That transac...See https://code.briarproject.org/briar/briar-desktop/-/merge_requests/51#note_58786:
> The ContactManager method that converts a PendingContact into a Contact could broadcast an event with both IDs, if that would help?
>
> That transaction already gets a PendingContactRemovedEvent and ContactAddedEvent attached to it. I'm guessing that in order to handle those events cleanly in the UI, you'd want the new event (let's call it a PendingContactConvertedEvent for the sake of argument) to be broadcast before the PendingContactRemovedEvent. Otherwise the UI would react to the PendingContactRemovedEvent by removing the selected item, which would no longer exist when the PendingContactConvertedEvent arrived.
>
> If the UI will depend on the order of events for correct behaviour then the order ought to be documented in ContactManager's javadoc.https://code.briarproject.org/briar/briar-desktop/-/issues/164Investigate reproducibility of current toolchain2023-02-10T19:27:52ZMikolai GütschowInvestigate reproducibility of current toolchaine.g. by looking at nightly buildse.g. by looking at nightly buildshttps://code.briarproject.org/briar/briar/-/issues/2245Adding a duplicate contact at a distance - contact name in the toast message ...2023-03-15T12:27:44ZIvanaAdding a duplicate contact at a distance - contact name in the toast message is incorrectThis test was run at the request in !1568
Steps to reproduce:
- Add a contact at a distance: Bobby
- Add another contact at a distance (Billy), but pasting Bobby's link (and not a new link as is required for successful addition of a ne...This test was run at the request in !1568
Steps to reproduce:
- Add a contact at a distance: Bobby
- Add another contact at a distance (Billy), but pasting Bobby's link (and not a new link as is required for successful addition of a new contact)
Expected results:
- A popup message should come up asking the user if the two contacts are the same person? This functions OK.
- The user clicks on the Same Person button - which discontinues the process, and there is a little toast message at the bottom of thescreen saing "contact Bobby already eixsts"
Actual results:
The toast message says: Contact Billy already exists.
It looks like the name of the contact that already exists and the duplicate contact are swapped. See screenshots attached.
Tested on build: 3a22388, fix-string-substitutions branch, dated 14/12/2021, 19:5
![device-2021-12-17-113044](/uploads/57e28f7ec784844532c67ca1e9da1703/device-2021-12-17-113044.png)IvanaIvanahttps://code.briarproject.org/briar/briar-desktop/-/issues/163Consider offloading avatar loading to the IoExecutor2023-02-01T14:11:02ZSebastianConsider offloading avatar loading to the IoExecutorCurrently we load avatar images on the db thread, maybe that's not optimalCurrently we load avatar images on the db thread, maybe that's not optimalhttps://code.briarproject.org/briar/briar-desktop/-/issues/162See if we can externalize versions from briar's build file and reuse them here2022-11-07T15:58:07ZSebastianSee if we can externalize versions from briar's build file and reuse them hereSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/80Consider starting mailbox before phone has been unlocked by user2023-08-28T16:00:11ZSebastianConsider starting mailbox before phone has been unlocked by userSee !50 in particular https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/50#note_58609See !50 in particular https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/50#note_58609https://code.briarproject.org/briar/briar-mailbox/-/issues/78Fix checkstyle2022-04-20T13:51:22ZSebastianFix checkstyleAs discovered in !47: When I run `./gradlew checkstyleMain` locally, I get checkstyle reports in `build/reports/checkstyle` and failing builds on style errors only for modules `mailbox-core` and `mailbox-cli`. That even though we configu...As discovered in !47: When I run `./gradlew checkstyleMain` locally, I get checkstyle reports in `build/reports/checkstyle` and failing builds on style errors only for modules `mailbox-core` and `mailbox-cli`. That even though we configured the plugin for the other two modules, too. Maybe it doesn't work for android/android-library subprojects out of the box?SebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/2244Reduce bandwidth used by polling2021-12-13T14:23:36ZakwizgranReduce bandwidth used by pollingPolling for connections to contacts via Tor uses a significant amount of bandwidth. We could save bandwidth by polling unreachable contacts less often, or by polling less often (perhaps not at all) if we're confident that contacts can co...Polling for connections to contacts via Tor uses a significant amount of bandwidth. We could save bandwidth by polling unreachable contacts less often, or by polling less often (perhaps not at all) if we're confident that contacts can connect to us when they come online (ie if our hidden service is reachable).
For short-range transports, polling contacts in a batch may use less battery than polling them at contact-specific intervals. It may be possible to meet the needs of Tor and short-range transports by polling in batches, but not including unreachable contacts in every batch.https://code.briarproject.org/briar/briar-mailbox/-/issues/77Lifecycle cleanup2022-02-25T14:55:01ZSebastianLifecycle cleanupalso address wakelock handlingalso address wakelock handlingSebastianSebastian2022-01-03https://code.briarproject.org/briar/briar/-/issues/2241Add marker interface to `ContactId` and `PendingContactId`2022-02-28T15:52:29ZMikolai GütschowAdd marker interface to `ContactId` and `PendingContactId`Since we are trying to show both in the same list for https://code.briarproject.org/briar/briar-desktop/-/merge_requests/51, it would be nice to have a common interface for them. It could be named `BaseContactId` for example. If you have...Since we are trying to show both in the same list for https://code.briarproject.org/briar/briar-desktop/-/merge_requests/51, it would be nice to have a common interface for them. It could be named `BaseContactId` for example. If you have no objections, we would happily add the respective code in a MR.https://code.briarproject.org/briar/briar-desktop/-/issues/153Investigate Compose `State` thread-safety2023-01-31T08:46:31ZMikolai GütschowInvestigate Compose `State` thread-safetyIt doesn't state anything in the [official docs](https://developer.android.com/reference/kotlin/androidx/compose/runtime/MutableState), but according to [this blog post](https://dev.to/zachklipp/a-historical-introduction-to-the-compose-r...It doesn't state anything in the [official docs](https://developer.android.com/reference/kotlin/androidx/compose/runtime/MutableState), but according to [this blog post](https://dev.to/zachklipp/a-historical-introduction-to-the-compose-reactive-state-model-19j8#snapshot-state-thread-safety), accessing states concurrently from different threads should be no problem. If that is true, we can use compose state values directly from within `runOnDbThread` and friends.
Related to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/55#note_57632.https://code.briarproject.org/briar/briar-desktop/-/issues/152Move test data creation to db thread2022-04-03T10:36:39ZSebastianMove test data creation to db threadhttps://code.briarproject.org/briar/briar/-/issues/2240Compression so heavy2021-12-10T10:37:42ZJoan SinglaCompression so heavySend images on briar for android is nearly unusefull because the receiver receive an image with a big quality loss.Send images on briar for android is nearly unusefull because the receiver receive an image with a big quality loss.https://code.briarproject.org/briar/briar-mailbox/-/issues/75Auto-start mailbox app on boot2022-02-25T14:56:13ZTorsten GroteAuto-start mailbox app on bootThis may not work on all versions of Android with all vendors.This may not work on all versions of Android with all vendors.https://code.briarproject.org/briar/briar/-/issues/2239GlideApp class removed2022-02-25T15:01:19ZNico HennrichGlideApp class removedI can't build briar anymore as the class org.briarproject.briar.android.conversation.glide.GlideApp is missing.
This class is referenced in six class (eg ImageFragment)I can't build briar anymore as the class org.briarproject.briar.android.conversation.glide.GlideApp is missing.
This class is referenced in six class (eg ImageFragment)https://code.briarproject.org/briar/briar-desktop/-/issues/151Reduce space requirements for GitLab CI2022-04-03T10:36:40ZNicoReduce space requirements for GitLab CIAnother pipeline failed because the CI runner ran out of space. Quoting @grote:
> yeah the server is out of space again, this was quick
>
> There's a runner caches with 21 GB, 15 GB, 11 GB, etc.
>
> The 21 GB one is for briar-desktop wh...Another pipeline failed because the CI runner ran out of space. Quoting @grote:
> yeah the server is out of space again, this was quick
>
> There's a runner caches with 21 GB, 15 GB, 11 GB, etc.
>
> The 21 GB one is for briar-desktop where each branch takes up more than 642M, the nightly builds 1.3GBhttps://code.briarproject.org/briar/briar/-/issues/2238Upgrade h22023-09-07T14:13:30ZSebastianUpgrade h2While working on https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/46 we discovered some things relevant to upgrading H2 in briarWhile working on https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/46 we discovered some things relevant to upgrading H2 in briarhttps://code.briarproject.org/briar/briar-desktop/-/issues/149Emoji picker2022-04-03T10:36:40ZSebastianEmoji pickerWe probably need an emoji picker otherwise it's going to be difficult to add those with a regular keyboard.We probably need an emoji picker otherwise it's going to be difficult to add those with a regular keyboard.https://code.briarproject.org/briar/briar-desktop/-/issues/143Find way to maybe not have additional main() methods in production code for U...2022-04-03T10:36:41ZSebastianFind way to maybe not have additional main() methods in production code for UI testingRelated to !61Related to !61https://code.briarproject.org/briar/briar/-/issues/2237Pending contact list doesn't show "No internet connection" if list contains f...2021-12-01T10:43:02ZakwizgranPending contact list doesn't show "No internet connection" if list contains failed pending contactsIf the pending contact list contains a mixture of failed and not-failed pending contacts, the "No internet connection" snackbar isn't shown when the device is offline. If the failed pending contacts are removed, leaving only not-failed o...If the pending contact list contains a mixture of failed and not-failed pending contacts, the "No internet connection" snackbar isn't shown when the device is offline. If the failed pending contacts are removed, leaving only not-failed ones, the snackbar appears.