briar issueshttps://code.briarproject.org/groups/briar/-/issues2019-08-08T12:58:09Zhttps://code.briarproject.org/briar/briar/-/issues/1598headless: add RSS feed functionality2019-08-08T12:58:09Ziwakehheadless: add RSS feed functionalityIt would be great to have the RSS feed functionality in briar-headless.
(I could help with the implementation with a little info about how to approach this best.)It would be great to have the RSS feed functionality in briar-headless.
(I could help with the implementation with a little info about how to approach this best.)https://code.briarproject.org/briar/briar/-/issues/1616A dumb issue2019-08-05T01:48:15ZKyf LeeA dumb issuehttps://code.briarproject.org/briar/briar/-/issues/1597make headless module start w/o running Tor2019-07-14T15:57:14Ziwakehmake headless module start w/o running TorIs there a way to reuse an existing Tor connection and avoid starting a Tor instance when running the headless jar?
Or, simply run it w/o Tor?Is there a way to reuse an existing Tor connection and avoid starting a Tor instance when running the headless jar?
Or, simply run it w/o Tor?https://code.briarproject.org/briar/briar/-/issues/1606ClassCastException when opening conversation with contact who supports images2019-06-28T13:28:39ZakwizgranClassCastException when opening conversation with contact who supports images* Android version: 9
* Phone model: Xiaomi Mi A1
* Briar version: 1.1.7 (37d0b61)
Stacktrace:
```
java.lang.ClassCastException: org.briarproject.briar.android.view.TextSendController cannot be cast to org.briarproject.briar.android.view...* Android version: 9
* Phone model: Xiaomi Mi A1
* Briar version: 1.1.7 (37d0b61)
Stacktrace:
```
java.lang.ClassCastException: org.briarproject.briar.android.view.TextSendController cannot be cast to org.briarproject.briar.android.view.TextAttachmentController
at org.briarproject.briar.android.conversation.ConversationActivity.showImageOnboarding(ConversationActivity.java:730)
at org.briarproject.briar.android.conversation.ConversationActivity.lambda$tKsX2hu-pmpHBYdC5ev_sWoOCXk(Unknown Source:0)
at org.briarproject.briar.android.conversation.-$$Lambda$ConversationActivity$tKsX2hu-pmpHBYdC5ev_sWoOCXk.run(Unknown Source:2)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6762)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
```
The crash is caused by failing to check the image attachments feature flag before calling showImageOnboarding(). This is fixed on master but will happen for Briar 1.1.7 (and possibly some earlier releases) when contacts upgrade to a version that supports image attachments, including 1.2 and 1.3 alpha releases.
Fortunately I've found a sneaky workaround: we bump the client minor version to 2. Briar 1.1.7 only considers that a contact supports image attachments if the minor version is exactly 1 (this is also fixed on master, but fortunately didn't make it into the 1.1.7 release).Android 1.3akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1603Calls and videocalls (Idea)2019-06-28T10:36:21ZjomocuCalls and videocalls (Idea)I think it would be great to add calls and video calls to the application.
With the possibility of "Compressing data" in mobile data...
Greetings and good projectI think it would be great to add calls and video calls to the application.
With the possibility of "Compressing data" in mobile data...
Greetings and good projecthttps://code.briarproject.org/briar/briar/-/issues/1605Allow access to urls with a click2019-06-28T09:28:15ZjomocuAllow access to urls with a clickIt would be great, to support that function, even for special domains (.bit .o among many others)
https://www.opennic.org
regardsIt would be great, to support that function, even for special domains (.bit .o among many others)
https://www.opennic.org
regardshttps://code.briarproject.org/briar/briar/-/issues/1604Briar desktop (Idea)2019-06-28T09:27:21ZjomocuBriar desktop (Idea)It would be great to have "briar desktop" for computers.
Windows, Linux and Mac
RegardsIt would be great to have "briar desktop" for computers.
Windows, Linux and Mac
Regardshttps://code.briarproject.org/briar/briar/-/issues/1426Feedback data is hard to read in preview screen2019-06-18T16:52:08ZakwizgranFeedback data is hard to read in preview screenSince [upgrading ACRA](https://code.briarproject.org/briar/briar/commit/b972d1fc13570fa6258048d5e8a429f9882b8ef6) the contents of crash reports and feedback are shown in the preview as blobs of JSON rather than key-value pairs, which mak...Since [upgrading ACRA](https://code.briarproject.org/briar/briar/commit/b972d1fc13570fa6258048d5e8a429f9882b8ef6) the contents of crash reports and feedback are shown in the preview as blobs of JSON rather than key-value pairs, which makes them harder to read.
There also seems to be an issue with the scroll view cutting off the bottom of the content.Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1390PasswordActivity is shown after backing out of crash report, can't back out o...2019-06-18T16:51:50ZakwizgranPasswordActivity is shown after backing out of crash report, can't back out of PasswordActivitySteps to reproduce:
* Sign into Briar (debug build)
* Go to Settings > Crash
* Choose "Send Report"
* Back out of the report creation screen
* Expected behaviour: Return to home screen
* Actual behaviour: PasswordActivity is shown
* Pre...Steps to reproduce:
* Sign into Briar (debug build)
* Go to Settings > Crash
* Choose "Send Report"
* Back out of the report creation screen
* Expected behaviour: Return to home screen
* Actual behaviour: PasswordActivity is shown
* Press back button
* Expected behaviour: Return to home screen
* Actual behaviour: PasswordActivity remains visible (or maybe another instance immediately appears?)Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1061ACRA can't find BuildConfig class2019-06-18T16:51:38ZakwizgranACRA can't find BuildConfig classThis was included in a log submitted by a tester:
```
08-24 19:38:24.542 E/ACRA (25526): Not adding buildConfig to log. Class Not found : org.briarproject.briar.beta.BuildConfig. Please configure 'buildConfigClass' in your ACRA confi...This was included in a log submitted by a tester:
```
08-24 19:38:24.542 E/ACRA (25526): Not adding buildConfig to log. Class Not found : org.briarproject.briar.beta.BuildConfig. Please configure 'buildConfigClass' in your ACRA config
```
* Android version: 7.1.1
* Phone model: Moto Z2 Play
* Briar version: 0.16.9 (0785348)Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1054Cannot scroll in error dialog2019-06-18T16:51:27ZligiCannot scroll in error dialogThis happens on a very small device (Jelly-pro):
![briar_bug](/uploads/54e8e90ff0d2e9a348126c2363a4aee1/briar_bug.png)This happens on a very small device (Jelly-pro):
![briar_bug](/uploads/54e8e90ff0d2e9a348126c2363a4aee1/briar_bug.png)Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1012User feedback screen doesn't scroll when email address field gets focus2019-06-18T16:51:11ZakwizgranUser feedback screen doesn't scroll when email address field gets focusA user reported that when sending feedback and moving focus to the email address field, the screen didn't scroll, so the email address field was hidden under the onscreen keyboard.A user reported that when sending feedback and moving focus to the email address field, the screen didn't scroll, so the email address field was hidden under the onscreen keyboard.Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1591RuntimeException after sending crash report2019-06-18T16:50:53ZakwizgranRuntimeException after sending crash report* Android version: 9
* Phone model: Honor 8A
* Briar version: current master (30e0be9f)
Steps to reproduce:
* Cause a crash (e.g. with the crash button in the settings screen)
* Send a crash report or dismiss the report dialog
* Expecte...* Android version: 9
* Phone model: Honor 8A
* Briar version: current master (30e0be9f)
Steps to reproduce:
* Cause a crash (e.g. with the crash button in the settings screen)
* Send a crash report or dismiss the report dialog
* Expected: The dialog disappears
* Actual: The dialog repeatedly reappears with new crashes, even after pressing the home button and relaunching Briar
Stacktrace:
```
java.lang.RuntimeException: Unable to start activity ComponentInfo{org.briarproject.briar.android.debug/org.briarproject.briar.android.navdrawer.NavDrawerActivity}: android.os.BadParcelableException: Parcelable protocol requires a Parcelable.Creator object called CREATOR on class android.support.v4.app.FragmentManagerState
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3364)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3548)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:86)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2155)
at android.os.Handler.dispatchMessage(Handler.java:109)
at android.os.Looper.loop(Looper.java:207)
at android.app.ActivityThread.main(ActivityThread.java:7539)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:958)
Caused by: android.os.BadParcelableException: Parcelable protocol requires a Parcelable.Creator object called CREATOR on class android.support.v4.app.FragmentManagerState
at android.os.Parcel.readParcelableCreator(Parcel.java:2849)
at android.os.Parcel.readParcelable(Parcel.java:2771)
at android.os.Parcel.readValue(Parcel.java:2674)
at android.os.Parcel.readArrayMapInternal(Parcel.java:3043)
at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:288)
at android.os.BaseBundle.unparcel(BaseBundle.java:232)
at android.os.BaseBundle.getBoolean(BaseBundle.java:898)
at android.app.Activity.restoreHasCurrentPermissionRequest(Activity.java:7768)
at android.app.Activity.performCreate(Activity.java:7436)
at android.app.Activity.performCreate(Activity.java:7431)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1286)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3343)
... 11 more
```Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1590IllegalStateException: Cannot invoke setValue on a background thread2019-06-18T11:58:53ZakwizgranIllegalStateException: Cannot invoke setValue on a background threadCrashed when sending a message to a new contact.
Stacktrace:
```
java.lang.IllegalStateException: Cannot invoke setValue on a background thread
at android.arch.lifecycle.LiveData.assertMainThread(LiveData.java:435)
at androi...Crashed when sending a message to a new contact.
Stacktrace:
```
java.lang.IllegalStateException: Cannot invoke setValue on a background thread
at android.arch.lifecycle.LiveData.assertMainThread(LiveData.java:435)
at android.arch.lifecycle.LiveData.setValue(LiveData.java:279)
at android.arch.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
at org.briarproject.briar.android.attachment.AttachmentCreator.resetState(AttachmentCreator.java:183)
at org.briarproject.briar.android.attachment.AttachmentCreator.onAttachmentsSent(AttachmentCreator.java:164)
at org.briarproject.briar.android.conversation.ConversationViewModel.storeMessage(ConversationViewModel.java:295)
at org.briarproject.briar.android.conversation.ConversationViewModel.lambda$createMessage$8$ConversationViewModel(ConversationViewModel.java:286)
at org.briarproject.briar.android.conversation.-$$Lambda$ConversationViewModel$1LsoWDT2XwB7wPxBWawY1IIRFR0.run(Unknown Source:10)
at org.briarproject.bramble.TimeLoggingExecutor.lambda$execute$0$TimeLoggingExecutor(TimeLoggingExecutor.java:36)
at org.briarproject.bramble.-$$Lambda$TimeLoggingExecutor$Bqrtbsq_8LcRPoTWBOef6xh7gJg.run(Unknown Source:6)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:784)
```
This is my fault - I recommended moving the onAttachmentsSent() call to a place that's on the UI thread on my branch, forgetting that it's on the crypto executor on master.Android 1.2akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1587Add version negotiation to sync protocol2019-06-18T11:58:45ZakwizgranAdd version negotiation to sync protocolAdd a record to the sync protocol that tells the remote peer which versions of the protocol the local peer supports. Send this record at the start of every session. Remember the last set of versions received from the remote peer and use ...Add a record to the sync protocol that tells the remote peer which versions of the protocol the local peer supports. Send this record at the start of every session. Remember the last set of versions received from the remote peer and use them to decide which records we can send.
Subtask of #1434.Android 1.3akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1254Headless server/desktop app2019-06-18T11:50:21ZakwizgranHeadless server/desktop appUmbrella ticket for sponsor 1, objective 5.
Outstanding Tasks:
* [x] add command line options for things like controlling log verbosity, port to bind to, etc.
* [x] research better input validation options
* [x] unit tests for all con...Umbrella ticket for sponsor 1, objective 5.
Outstanding Tasks:
* [x] add command line options for things like controlling log verbosity, port to bind to, etc.
* [x] research better input validation options
* [x] unit tests for all controllers
* [x] REST API authentication with bearer token (maybe optional, or only when not bound to localhost?)
* [x] Websocket API authentication (problematic since JavaScript can't control headers in request)
* [x] simple API documentation in README.md
* [x] add support for adding contacts (blocked by missing support in core)Headless MVPTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1580Warn when adding pending contact with Tor disabled2019-06-18T09:54:35ZTorsten GroteWarn when adding pending contact with Tor disabledAdding contacts remotely won't work with the Tor plugin not running. We should notify contacts when that is the case, so they can go online or enable Tor.Adding contacts remotely won't work with the Tor plugin not running. We should notify contacts when that is the case, so they can go online or enable Tor.Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1467Improve Conversation Scrolling Behaviour2019-06-17T10:10:29ZTorsten GroteImprove Conversation Scrolling BehaviourCurrently, we scroll down after loading the list of messages (after each activity start). We also scroll down when loading a message text or image asynchronously.
This is problematic, because the user can't scroll up right after a large...Currently, we scroll down after loading the list of messages (after each activity start). We also scroll down when loading a message text or image asynchronously.
This is problematic, because the user can't scroll up right after a large conversation is displayed and because when looking at older photos, the user forcibly gets scrolled to the end of the conversation and needs to find where she was.
Subtask of #1242Android 1.3Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/713Don't always scroll to bottom of conversation when a message arrives2019-06-17T10:10:29ZakwizgranDon't always scroll to bottom of conversation when a message arrivesIf the conversation is already scrolled to the bottom, scroll to the bottom after adding the new item so it becomes visible. Otherwise don't scroll, as the user may be manually scrolling back in the conversation to look for something.If the conversation is already scrolled to the bottom, scroll to the bottom after adding the new item so it becomes visible. Otherwise don't scroll, as the user may be manually scrolling back in the conversation to look for something.Android 1.3Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/1393Error page is shown when trying to install Ripple from Google Play2019-06-12T10:45:27ZakwizgranError page is shown when trying to install Ripple from Google PlayWhen no panic button app is installed, touching the "Panic Button App" preference automatically opens a market:// link to install Ripple. If the device has Google Play but not F-Droid, a Play Store error page is shown. This may be confus...When no panic button app is installed, touching the "Panic Button App" preference automatically opens a market:// link to install Ripple. If the device has Google Play but not F-Droid, a Play Store error page is shown. This may be confusing for the user, as we haven't given any indication that we're about to search for an app on Google Play.
If the device has both Google Play and F-Droid, an app chooser is shown. Choosing Google Play leads to the error page.
![device-2018-09-28-110048](/uploads/5eb85f3d601c31b661f9071d70638c20/device-2018-09-28-110048.png)Android 1.1