briar issueshttps://code.briarproject.org/groups/briar/-/issues2023-02-01T13:45:04Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/320Increase threshold for including translations2023-02-01T13:45:04ZNicoIncrease threshold for including translationsWith !185 I realized that 50% might be not enough for us to include languages for future releases. Ukrainian is only around 50%, and while a lot of important strings are already translated, there's still a lot of stuff missing.
I sugges...With !185 I realized that 50% might be not enough for us to include languages for future releases. Ukrainian is only around 50%, and while a lot of important strings are already translated, there's still a lot of stuff missing.
I suggest aligning Desktop's policy [with Android's one](https://code.briarproject.org/briar/briar/-/blob/master/briar-android/.tx/config#L10) and set the threshold to 80% for future releases.
What to do with languages that are included but under 80% is open to discussion.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/319Connectivity issues after suspend/hibernate2023-03-08T14:07:07ZSebastianConnectivity issues after suspend/hibernateAs @akwizgran [pointed out here](https://code.briarproject.org/briar/briar-desktop/-/issues/183#note_60283):
> I think Linux takes network interfaces down on suspend/hibernate (wake-on-LAN is handled at the hardware level), so we might
...As @akwizgran [pointed out here](https://code.briarproject.org/briar/briar-desktop/-/issues/183#note_60283):
> I think Linux takes network interfaces down on suspend/hibernate (wake-on-LAN is handled at the hardware level), so we might
need to listen for some kind of event indicating that the device has come out of suspend/hibernate and force a connectivity check. Such events exist on certain flavours of Linux but I don't know how they're implemented (dbus?) or whether anything similar exists on Win/Mac.
I think we also already got reports that briar desktop was offline after coming back from suspend also it appeared online in the own user interface.https://code.briarproject.org/briar/briar-desktop/-/issues/317Better TAB navigation in combination with password reveal buttons2022-02-21T23:06:27ZMikolai GütschowBetter TAB navigation in combination with password reveal buttonsThe following discussion from !177 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/177#note_63754): (+1 comment)
> I just noticed that stepping through ...The following discussion from !177 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/177#note_63754): (+1 comment)
> I just noticed that stepping through the text fields using the TAB/Enter keys does not work very nicely anymore since the "reveal password" button is in between two text fields. Not sure what should be the expected behavior here though, since having the reveal password buttons accessible is definitely a must as well. Perhaps changing the tab order?https://code.briarproject.org/briar/briar-desktop/-/issues/316Add list of contributors to About dialog2022-02-22T01:29:02ZMikolai GütschowAdd list of contributors to About dialogE.g. like it's done in Transportr. What are your thoughts on this @nico @sebkur?E.g. like it's done in Transportr. What are your thoughts on this @nico @sebkur?https://code.briarproject.org/briar/briar-desktop/-/issues/315Use private Composable functions where possible2023-01-09T21:39:57ZMikolai GütschowUse private Composable functions where possibleThe following discussion from !165 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/165#note_63088): (+2 comments)
> Hmm, I guess [having private Composab...The following discussion from !165 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/165#note_63088): (+2 comments)
> Hmm, I guess [having private Composable functions has] been possible all the time, we just haven't made use of it the way one usually would. For example looking at `PrivateMessageScreen`, all methods except `PrivateMessageScreen()` could be private. I think that's pretty common in our codebase. I think we didn't stumble upon it as IntelliJ doesn't warn about @Composable functions that could be private like it does with regular methods that could be private.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/311Disable copy ~~and paste~~ on password fields2023-08-25T13:33:35ZSebastianDisable copy ~~and paste~~ on password fieldsI think usually this is not possible.
I guess it helps prevent people copying the password from the first field to the second ;)I think usually this is not possible.
I guess it helps prevent people copying the password from the first field to the second ;)Desktop 0.7.0Altynbek NurtazaAltynbek Nurtazahttps://code.briarproject.org/briar/briar-desktop/-/issues/306Center AddContactDialog in current MainWindow2023-08-25T13:33:34ZMikolai GütschowCenter AddContactDialog in current MainWindowFollow-up of https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62432
Currently it is centered in the center of the screen, no matter where the Briar Main Window is shown.Follow-up of https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62432
Currently it is centered in the center of the screen, no matter where the Briar Main Window is shown.Desktop 0.7.0https://code.briarproject.org/briar/briar-desktop/-/issues/305Set windows' minimum size depending on Dp2023-08-25T13:33:36ZMikolai GütschowSet windows' minimum size depending on DpThe following discussion from !144 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62513): (+4 comments)
> I think it probably makes sense to ad...The following discussion from !144 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62513): (+4 comments)
> I think it probably makes sense to add a minimum size to the dialog's underlying window, too. Like we do in `BriarUi#start()`, i.e. we could add
> ```
> window.minimumSize = Dimension(450, 500)
> ```
> or even use the initial sizes used above (although the probably need to be converted to pixels somehow
quoting @paul-lorenc :
> From https://github.com/JetBrains/compose-jb/issues/1773, it looks like we can use the following line:
>
> `val density = LocalDensity.current`
>
> To get the current screen density, then calculate the dp to pixel conversion using this density (maybe?). For now I think `window.minimumSize = Dimension(x, y)` is good enough here, and we can further investigate this method to use here, and also for defining the minimum size of the main UI window.Desktop 0.7.0SebastianSebastianhttps://code.briarproject.org/briar/tor-reproducer/-/issues/8Do hardening of builds2022-02-15T10:04:12ZNicoDo hardening of buildsThe following discussion from !17 should be addressed:
- [ ] @akwizgran started a [discussion](https://code.briarproject.org/briar/tor-reproducer/-/merge_requests/17#note_59064): (+2 comments)
> I think you mentioned somewhere tha...The following discussion from !17 should be addressed:
- [ ] @akwizgran started a [discussion](https://code.briarproject.org/briar/tor-reproducer/-/merge_requests/17#note_59064): (+2 comments)
> I think you mentioned somewhere that you had to drop `-O3` (which is commented as "needed for FORTIFY_SOURCE" in the Linux build), but I couldn't find where you mentioned it. I can't remember where the FORTIFY_SOURCE comment came from - possibly the Guardian Project's original Makefile? Any idea whether it's important?https://code.briarproject.org/briar/briar-desktop/-/issues/304Scrollbar Visual Bug2022-03-14T04:33:36ZpaulScrollbar Visual BugWhile scrolling through messages, the scrollbar often changes size and position.
![scrollbar-visual-bug](/uploads/a2ba5d9aeb45c5064c4fcd0ae7181394/scrollbar-visual-bug.gif)While scrolling through messages, the scrollbar often changes size and position.
![scrollbar-visual-bug](/uploads/a2ba5d9aeb45c5064c4fcd0ae7181394/scrollbar-visual-bug.gif)https://code.briarproject.org/briar/briar/-/issues/2263Status of Tor plugin is unclear in connections screen2022-02-11T12:35:00ZakwizgranStatus of Tor plugin is unclear in connections screenWhen the "Use mobile data" setting is turned off or the "Connect to the Internet only when charging" setting is turned on, Briar might not connect to the internet even though the parent setting, "Connect to contacts via the Internet", is...When the "Use mobile data" setting is turned off or the "Connect to the Internet only when charging" setting is turned on, Briar might not connect to the internet even though the parent setting, "Connect to contacts via the Internet", is turned on.
In the main settings screen this is hopefully clear because all the settings are shown. But in the connections screen we only show the parent setting and the current status. So it may not be obvious that Briar is offline, or how to change this.https://code.briarproject.org/briar/briar/-/issues/2262Improve warning about being offline when adding a contact remotely2022-02-11T12:16:38ZakwizgranImprove warning about being offline when adding a contact remotelyIf the user adds a contact remotely while Briar is offline (ie not connected to Tor), we don't show any indication that Briar doesn't have an internet connection until the user reaches the pending contact list, and when the warning is sh...If the user adds a contact remotely while Briar is offline (ie not connected to Tor), we don't show any indication that Briar doesn't have an internet connection until the user reaches the pending contact list, and when the warning is shown it doesn't give any guidance about what the user could do to solve the problem.https://code.briarproject.org/briar/briar-desktop/-/issues/302Allow to translate metainfo.xml2022-02-11T11:49:51ZNicoAllow to translate metainfo.xmlFollow-up to https://code.briarproject.org/briar/briar-desktop/-/issues/128Follow-up to https://code.briarproject.org/briar/briar-desktop/-/issues/128https://code.briarproject.org/briar/briar-desktop/-/issues/301Use shrinked version for native distribution2022-09-15T05:18:11ZMikolai GütschowUse shrinked version for native distributionThe following discussion from !134 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/134#note_62165): (+1 comment)
> What's still going to be tricky is to ...The following discussion from !134 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/134#note_62165): (+1 comment)
> What's still going to be tricky is to ship the shrinked jar file along with our `deb`, because we somehow need to tweak it to use that file. Seemed like no-one on the kotlinlang slack knew how to do that, but I'll try to figure something out.https://code.briarproject.org/briar/briar-desktop/-/issues/299Further reduce .jar size by excluding tor binaries for other architectures2022-02-09T15:42:12ZNicoFurther reduce .jar size by excluding tor binaries for other architecturesFollow-up to https://code.briarproject.org/briar/briar-desktop/-/issues/141#note_62471:
> Don't know if it's related to this, but in briar-headless we also strip tor binaries of other architectures:
>
> https://code.briarproject.org/bri...Follow-up to https://code.briarproject.org/briar/briar-desktop/-/issues/141#note_62471:
> Don't know if it's related to this, but in briar-headless we also strip tor binaries of other architectures:
>
> https://code.briarproject.org/briar/tor-reproducer/-/blob/234280ef8891b1bcb4768e5906896467e880f067/build-tor.py#L195
This has the potential of reducing the .jar by some more MB.https://code.briarproject.org/briar/briar-desktop/-/issues/298Try to make ktlint fail with missing i18n on main source set2022-04-03T10:36:20ZSebastianTry to make ktlint fail with missing i18n on main source sethttps://code.briarproject.org/briar/briar-desktop/-/issues/297For long outgoing message, scroll to bottom when opening the chat2022-02-05T20:45:04ZMikolai GütschowFor long outgoing message, scroll to bottom when opening the chatSame might apply to already read, incoming messages.
Currently, when opening the Georgy Voronoy chat, the chat view always jumps to the *start* of the last message.
![image](/uploads/1d39f4c178334db5b6db2ab83ca7ce40/image.png)Same might apply to already read, incoming messages.
Currently, when opening the Georgy Voronoy chat, the chat view always jumps to the *start* of the last message.
![image](/uploads/1d39f4c178334db5b6db2ab83ca7ce40/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/296connection is not restored2022-02-22T09:44:17Zmicressorconnection is not restoredConnection is not restored when switching from one LAN network to another LAN network (different IP range).
The contact status remains offline.
Fix by restarting the briar desktop app
version: 0.1.0-betaConnection is not restored when switching from one LAN network to another LAN network (different IP range).
The contact status remains offline.
Fix by restarting the briar desktop app
version: 0.1.0-betahttps://code.briarproject.org/briar/briar-desktop/-/issues/294Can Briar work over an existing Tor network? Tor over Tor?2022-02-04T19:17:58ZLucy LuCan Briar work over an existing Tor network? Tor over Tor?Can Briar work over an existing Tor network?
Many users concerned with security, privacy, anonymity will be using secure operating systems and anonymous networks.
Use Cases:
- People operating on Whonix.
- People operating on Tails...Can Briar work over an existing Tor network?
Many users concerned with security, privacy, anonymity will be using secure operating systems and anonymous networks.
Use Cases:
- People operating on Whonix.
- People operating on Tails.
- People operating on Qubes OS TorVM.
- Running a Tor network router.https://code.briarproject.org/briar/briar-desktop/-/issues/293Correctly handle RTL languages2022-10-25T09:42:57ZNicoCorrectly handle RTL languagesUI elements should go from the right to the left then? Like, e.g., the contact list being on the right instead of one the left?UI elements should go from the right to the left then? Like, e.g., the contact list being on the right instead of one the left?Desktop 1.0.0