briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-09-01T11:18:53Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/118[deb] NoClassDefFoundError: java/sql/SQLException2022-09-01T11:18:53ZNico[deb] NoClassDefFoundError: java/sql/SQLExceptionExecuting the .deb package currently fails with the following error:
```
➜ ~ /opt/briar-desktop/bin/Briar
Exception in thread "main" java.lang.NoClassDefFoundError: java/sql/SQLException
at org.briarproject.bramble.db.DatabaseModule.p...Executing the .deb package currently fails with the following error:
```
➜ ~ /opt/briar-desktop/bin/Briar
Exception in thread "main" java.lang.NoClassDefFoundError: java/sql/SQLException
at org.briarproject.bramble.db.DatabaseModule.provideDatabase(DatabaseModule.java:27)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.provideDatabase(DatabaseModule_ProvideDatabaseFactory.java:47)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.get(DatabaseModule_ProvideDatabaseFactory.java:36)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.get(DatabaseModule_ProvideDatabaseFactory.java:12)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseComponentFactory.get(DatabaseModule_ProvideDatabaseComponentFactory.java:40)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseComponentFactory.get(DatabaseModule_ProvideDatabaseComponentFactory.java:13)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.lifecycle.LifecycleManagerImpl_Factory.get(LifecycleManagerImpl_Factory.java:30)
at org.briarproject.bramble.lifecycle.LifecycleManagerImpl_Factory.get(LifecycleManagerImpl_Factory.java:10)
at org.briarproject.bramble.lifecycle.LifecycleModule_ProvideLifecycleManagerFactory.get(LifecycleModule_ProvideLifecycleManagerFactory.java:26)
at org.briarproject.bramble.lifecycle.LifecycleModule_ProvideLifecycleManagerFactory.get(LifecycleModule_ProvideLifecycleManagerFactory.java:9)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.cleanup.CleanupModule_ProvideCleanupManagerFactory.get(CleanupModule_ProvideCleanupManagerFactory.java:35)
at org.briarproject.bramble.cleanup.CleanupModule_ProvideCleanupManagerFactory.get(CleanupModule_ProvideCleanupManagerFactory.java:11)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.briar.desktop.DaggerBriarDesktopApp.injectEagerSingletons(DaggerBriarDesktopApp.java:1428)
at org.briarproject.briar.desktop.DaggerBriarDesktopApp.inject(DaggerBriarDesktopApp.java:1320)
at org.briarproject.bramble.BrambleCoreEagerSingletons$Helper.injectEagerSingletons(BrambleCoreEagerSingletons.java:48)
at org.briarproject.briar.desktop.Main.run(Main.kt:75)
at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:198)
at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:18)
at com.github.ajalt.clikt.core.CliktCommand.parse(CliktCommand.kt:395)
at com.github.ajalt.clikt.core.CliktCommand.parse$default(CliktCommand.kt:392)
at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:410)
at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:435)
at org.briarproject.briar.desktop.MainKt.main(Main.kt:102)
Caused by: java.lang.ClassNotFoundException: java.sql.SQLException
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 27 more
Failed to launch JVM
```Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/117Add copyright notices to all files2022-01-18T16:34:18ZNicoAdd copyright notices to all filesFollow-up to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/38#note_56628.
At Briar GTK I respected https://reuse.software/, with file headers looking like this:
```python
# Copyright (c) 2019 Nico Alt
# Copyright (c...Follow-up to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/38#note_56628.
At Briar GTK I respected https://reuse.software/, with file headers looking like this:
```python
# Copyright (c) 2019 Nico Alt
# Copyright (c) 2014-2018 Cedric Bellegarde <cedric.bellegarde@adishatz.org>
# SPDX-License-Identifier: AGPL-3.0-only
# License-Filename: LICENSE.md
#
# Initial version based on GNOME Lollypop
# https://gitlab.gnome.org/World/lollypop/blob/1.0.2/lollypop/define.py
```
https://code.briarproject.org/briar/briar-gtk/-/blob/0.1.0-beta3/briar-gtk/briar_gtk/define.py
For our project I would suggest something like this:
```kotlin
/*
* SPDX-FileCopyrightText: 2021 The Briar Project <contact@briarproject.org>
* SPDX-License-Identifier: AGPL-3.0-only
* License-Filename: LICENSE.md
*/
```Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/72Database has duplicate contacts in Integration tests2022-02-25T14:52:22ZSebastianDatabase has duplicate contacts in Integration testsThe db doesn't check if a contact with the same id already exists when adding a contact. The way we're using this in integration tests at the moment, it leads to duplicate contacts in the db. Possible solutions are cleaning up properly i...The db doesn't check if a contact with the same id already exists when adding a contact. The way we're using this in integration tests at the moment, it leads to duplicate contacts in the db. Possible solutions are cleaning up properly in a `@AfterEach`, clearing the database, or checking for duplicates during `addContact()`.MailboxTorsten GroteTorsten Grote2021-11-29https://code.briarproject.org/briar/briar/-/issues/2214ActivityNotFoundException for CREATE_DOCUMENT intent2022-04-20T14:54:05ZakwizgranActivityNotFoundException for CREATE_DOCUMENT intentThis looks similar to #2097, but with CREATE_DOCUMENT instead of OPEN_DOCUMENT.
* Android version: 7.1.1
* Phone model: Meitu MP1709
* Briar version: 1.3.8 (8076775)
Last lines of log:
```
10-03 16:14:39.625 I/BaseActivity: Pausing Con...This looks similar to #2097, but with CREATE_DOCUMENT instead of OPEN_DOCUMENT.
* Android version: 7.1.1
* Phone model: Meitu MP1709
* Briar version: 1.3.8 (8076775)
Last lines of log:
```
10-03 16:14:39.625 I/BaseActivity: Pausing ConversationActivity
10-03 16:14:39.641 I/BaseActivity: Creating ImageActivity
10-03 16:14:39.681 I/BaseActivity: Starting ImageActivity
10-03 16:14:39.685 I/BaseActivity: Resuming ImageActivity
10-03 16:14:40.191 I/BaseActivity: Stopping ConversationActivity
```
Stacktrace:
```
No Activity found to handle Intent { act=android.intent.action.CREATE_DOCUMENT typ=*/* (has extras) }
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.CREATE_DOCUMENT typ=*/* (has extras) }
at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1809)
at android.app.Instrumentation.execStartActivity(Instrumentation.java:1523)
at android.app.Activity.startActivityForResult(Activity.java:4227)
at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:574)
at androidx.core.app.ActivityCompat.startActivityForResult(ActivityCompat.java:234)
at androidx.activity.ComponentActivity$2.onLaunch(ComponentActivity.java:208)
at androidx.activity.result.ActivityResultRegistry$2.launch(ActivityResultRegistry.java:166)
at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:47)
at org.briarproject.briar.android.conversation.ImageActivity.lambda$showSaveImageDialog$2(ImageActivity.java:266)
at org.briarproject.briar.android.conversation.ImageActivity.lambda$showSaveImageDialog$2$ImageActivity(ImageActivity.java)
at org.briarproject.briar.android.conversation.-$$Lambda$ImageActivity$ko_mlYveGbWbVoqWLtXvgqGatns.onClick(lambda)
at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
at android.os.Handler.dispatchMessage(Handler.java:110)
at android.os.Looper.loop(Looper.java:203)
at android.app.ActivityThread.main(ActivityThread.java:6314)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1097)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:951)
```
We have two reports of this but they look like they come from the same device, so I won't add it to the current milestone yet.Android 1.4akwizgranakwizgranhttps://code.briarproject.org/briar/briar-desktop/-/issues/116Allow to accept/decline private group invitations2023-04-15T18:17:53ZNicoAllow to accept/decline private group invitationsBlocked by https://code.briarproject.org/briar/briar-desktop/-/issues/110.
Sub-task of #12.Blocked by https://code.briarproject.org/briar/briar-desktop/-/issues/110.
Sub-task of #12.Desktop 0.5.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/115Implement threaded chat history for private groups and forums2022-10-25T08:36:09ZNicoImplement threaded chat history for private groups and forumsAs the UI of both is quite similar, they should definitively share code.
Sub-task of #12 or #13.As the UI of both is quite similar, they should definitively share code.
Sub-task of #12 or #13.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/114Show private groups in list2022-01-07T21:57:38ZNicoShow private groups in listAnalogously to the contact list.
Sub-task of #12.Analogously to the contact list.
Sub-task of #12.NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/113Add test private groups to TestData run configurations2023-05-15T12:09:04ZNicoAdd test private groups to TestData run configurationsSub-task of #12.Sub-task of #12.Desktop 0.6.0https://code.briarproject.org/briar/briar-desktop/-/issues/112Add MaterialTheme Typography Styling2022-02-18T10:00:07ZpaulAdd MaterialTheme Typography StylingInstead of manually declaring things like font size and weight, we can use the default `MaterialTheme` typography settings for sizing headers, content etc. From quickly experimenting, I don't see a need to create custom text sizing, but ...Instead of manually declaring things like font size and weight, we can use the default `MaterialTheme` typography settings for sizing headers, content etc. From quickly experimenting, I don't see a need to create custom text sizing, but I believe there are some existing manual font styles we can switch over to the `MaterialTheme` method.
Here's an example:
https://developer.android.com/jetpack/compose/themes/material#text-stylesDesktop 0.2.0paulpaulhttps://code.briarproject.org/briar/briar-desktop/-/issues/111Allow to log out of Briar Desktop without closing the window2022-01-07T15:22:31ZMikolai GütschowAllow to log out of Briar Desktop without closing the windowThe window should go back to the login screen after logging out. This action would be triggered by the last button in the left sidebar.The window should go back to the login screen after logging out. This action would be triggered by the last button in the left sidebar.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/110Add UI support for introductions and invitations inside the private message view2022-01-06T17:04:06ZMikolai GütschowAdd UI support for introductions and invitations inside the private message viewCurrently, only private messages are supported and shown in the UI. Both introductions and invitations have similar demands on the UI with the possibility of reacting on them by pressing a button.
This is also a prerequisite to be able ...Currently, only private messages are supported and shown in the UI. Both introductions and invitations have similar demands on the UI with the possibility of reacting on them by pressing a button.
This is also a prerequisite to be able to test #12Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/109Special handling of "Enter" in message compose field2022-01-06T17:04:05ZMikolai GütschowSpecial handling of "Enter" in message compose fieldSee the discussion in https://code.briarproject.org/briar/briar-desktop/-/issues/94#note_56401.See the discussion in https://code.briarproject.org/briar/briar-desktop/-/issues/94#note_56401.Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/108Mark new messages as read and show proper unread counter in contact list2021-12-06T14:25:09ZMikolai GütschowMark new messages as read and show proper unread counter in contact listCurrently, all incoming messages are unread by default and never set to read. Therefore, unread count is always bigger than zero and the small (blue) dot is correspondingly shown in the contact list. We could also show the number of unre...Currently, all incoming messages are unread by default and never set to read. Therefore, unread count is always bigger than zero and the small (blue) dot is correspondingly shown in the contact list. We could also show the number of unread messages inside the blue circle similar to the way the Android app does it.Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/107Glitch while displaying newly sent message2022-01-06T17:04:06ZSebastianGlitch while displaying newly sent messageWhile recording a demo I noticed a small glitch in the UI, apparently something is wrong when updating the conversation listWhile recording a demo I noticed a small glitch in the UI, apparently something is wrong when updating the conversation listDesktop 0.1.0https://code.briarproject.org/briar/briar-desktop/-/issues/106Hitting Send on whitespace-only message clears the input2021-12-06T14:25:08ZSebastianHitting Send on whitespace-only message clears the inputDesktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-mailbox/-/issues/71Check Java code style using CI2022-02-25T14:55:02ZSebastianCheck Java code style using CIMailboxSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/70API endpoint for checking mailbox status2022-02-25T14:55:02ZakwizgranAPI endpoint for checking mailbox statusImplement an API endpoint at `/status` that just returns 200 OK. This can replace the existing endpoint at `/`.Implement an API endpoint at `/status` that just returns 200 OK. This can replace the existing endpoint at `/`.MailboxSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/69Test everything is working on API 162022-12-15T13:02:58ZSebastianTest everything is working on API 16There's also other API levels like 17/18 that could cause issues due to different Java version. We need to make sure to test with Java 6.There's also other API levels like 17/18 that could cause issues due to different Java version. We need to make sure to test with Java 6.MailboxSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/68Try to upgrade h22022-02-25T14:51:53ZSebastianTry to upgrade h2MailboxSebastianSebastian2021-12-13https://code.briarproject.org/briar/briar-mailbox/-/issues/67Create read{} and write{} shortcut methods for database transactions2022-02-25T14:55:02ZSebastianCreate read{} and write{} shortcut methods for database transactionsMailboxSebastianSebastian