briar issueshttps://code.briarproject.org/groups/briar/-/issues2021-04-30T13:35:41Zhttps://code.briarproject.org/briar/briar/-/issues/1916Remove locking from MessageTreeImpl and mark the interface @UiThread2021-04-30T13:35:41ZakwizgranRemove locking from MessageTreeImpl and mark the interface @UiThreadSubtask of #1823.Subtask of #1823.https://code.briarproject.org/briar/briar/-/issues/1915Optimise ConnectionRegistry calls in SharingControllerImpl2021-04-30T13:35:47ZakwizgranOptimise ConnectionRegistry calls in SharingControllerImplSubtask of #1823.Subtask of #1823.https://code.briarproject.org/briar/briar/-/issues/1882Get rid of legacy code after ViewModel migration2021-04-30T13:35:56ZTorsten GroteGet rid of legacy code after ViewModel migrationA list of things we might not need anymore after the ViewModel migration is complete:
* [ ] `ActivityComponent`
* [ ] `BaseEventFragment`
* [ ] most of `BaseFragment`
* [ ] part of `BaseFragmentListener`
* [ ] `BriarActivity#runOnDbThre...A list of things we might not need anymore after the ViewModel migration is complete:
* [ ] `ActivityComponent`
* [ ] `BaseEventFragment`
* [ ] most of `BaseFragment`
* [ ] part of `BaseFragmentListener`
* [ ] `BriarActivity#runOnDbThread()`
* [ ] `BriarActivity#finishOnUiThread()`
* [ ] `VersionedAdapter` and its implementationhttps://code.briarproject.org/briar/briar/-/issues/1880Introduce ViewModel for SharingStatusActivity2021-04-30T13:36:01ZTorsten GroteIntroduce ViewModel for SharingStatusActivitySubtask of #1823.Subtask of #1823.https://code.briarproject.org/briar/briar/-/issues/1879Migrate ShareForumController to ViewModel2021-04-30T13:36:05ZTorsten GroteMigrate ShareForumController to ViewModelSubtask of #1800Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1878Migrate ShareBlogController to ViewModel2021-04-30T13:36:10ZTorsten GroteMigrate ShareBlogController to ViewModelSubtask of #1800Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1877Migrate RevealContactsController to ViewModel2021-04-30T13:36:28ZTorsten GroteMigrate RevealContactsController to ViewModelSubtask of #1800Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1876Migrate GroupMemberListController to ViewModel2021-04-30T13:36:32ZTorsten GroteMigrate GroupMemberListController to ViewModelSubtask of #1800Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1875Migrate InvitationControllers to ViewModel2021-04-30T13:36:37ZTorsten GroteMigrate InvitationControllers to ViewModelThere's three controllers sharing code:
* [ ] ForumInvitationController
* [ ] GroupInvitationController
* [ ] BlogInvitationController
Subtask of #1800There's three controllers sharing code:
* [ ] ForumInvitationController
* [ ] GroupInvitationController
* [ ] BlogInvitationController
Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1874Migrate CreateGroupController to ViewModel2021-04-30T13:37:10ZTorsten GroteMigrate CreateGroupController to ViewModelSubtask of #1800Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1868Migrate ContactSelectorController to ViewModel2021-04-30T13:37:26ZTorsten GroteMigrate ContactSelectorController to ViewModelThere's some code sharing going on here with various places. Also related to #1867
Subtask of #1800There's some code sharing going on here with various places. Also related to #1867
Subtask of #1800https://code.briarproject.org/briar/briar/-/issues/1737Huawei P8 Lite 2017 enters device idle mode despite doze whitelisting2021-04-30T13:38:14ZakwizgranHuawei P8 Lite 2017 enters device idle mode despite doze whitelistingAfter setting up Briar as normal on the Huawei P8 Lite 2017 (Android 7.0, EMUI 5.0.1) and leaving it running for a few hours, the doze watchdog dialog was shown after unlocking the screen, indicating that the phone entered device idle mo...After setting up Briar as normal on the Huawei P8 Lite 2017 (Android 7.0, EMUI 5.0.1) and leaving it running for a few hours, the doze watchdog dialog was shown after unlocking the screen, indicating that the phone entered device idle mode despite Briar being whitelisted.
![Screenshot_20200602-214120](/uploads/8771b9bbe470ab02575ddfe0221a9656/Screenshot_20200602-214120.png)
![Screenshot_20200602-214132](/uploads/d21e2d865b68342b1a9ae4f5f9319be9/Screenshot_20200602-214132.png)
Wifi and mobile data were turned off, so there was no Tor wake lock keeping the device awake.
After tapping "fix", which prompts to add Briar to the whitelist again, I left the phone idle for more than 24 hours and didn't see the doze watchdog dialog again.
I didn't capture any logs at the time as I was running another experiment. I'll try to reproduce this when the other experiments are finished.https://code.briarproject.org/briar/briar/-/issues/1558ViewModelModule is breaking package encapsulation2021-04-30T13:38:33ZTorsten GroteViewModelModule is breaking package encapsulationThe ViewModelModule is breaking package encapsulation. Let's refactor the ViewModel bindings into the respective packages and cleaning them up.The ViewModelModule is breaking package encapsulation. Let's refactor the ViewModel bindings into the respective packages and cleaning them up.https://code.briarproject.org/briar/briar/-/issues/2034Produce localized framed screenshots for app stores2021-05-10T12:17:32ZTorsten GroteProduce localized framed screenshots for app stores@c1e0 started work to automatically frame screenshots for Google Play:
https://code.briarproject.org/c1e0/briar/-/tree/fastlane/fastlane-screenshots
These can be localized and produced in a scripted fashion.@c1e0 started work to automatically frame screenshots for Google Play:
https://code.briarproject.org/c1e0/briar/-/tree/fastlane/fastlane-screenshots
These can be localized and produced in a scripted fashion.https://code.briarproject.org/briar/briar/-/issues/1895Introduce ViewModel for WriteBlogPostActivity2021-05-11T15:06:42ZTorsten GroteIntroduce ViewModel for WriteBlogPostActivityThe `WriteBlogPostActivity` could either be turned into a fragment and re-use BlogViewModel or have its own ViewModel.
Subtask of #1823
Depends on #1866The `WriteBlogPostActivity` could either be turned into a fragment and re-use BlogViewModel or have its own ViewModel.
Subtask of #1823
Depends on #1866https://code.briarproject.org/briar/briar/-/issues/2041Use vCard for URL transfer2021-05-17T11:46:06ZJens KorteUse vCard for URL transferI am not sure if it is of use: vCards can contain URLs. Maybe that URLs will be opened in a non-safe-Browser.I am not sure if it is of use: vCards can contain URLs. Maybe that URLs will be opened in a non-safe-Browser.https://code.briarproject.org/briar/briar/-/issues/2046After reblogging, return to the main blog feed page2021-05-18T10:24:19ZIvanaAfter reblogging, return to the main blog feed pageCurrently (githash b0faab9, master 17/05/2021 17:37) this is what happens:
- Open blog details page, and tap on reblog button.
- Type in the reblog comments and tap Reblog when finished.
This action returns the user to the blog detail...Currently (githash b0faab9, master 17/05/2021 17:37) this is what happens:
- Open blog details page, and tap on reblog button.
- Type in the reblog comments and tap Reblog when finished.
This action returns the user to the blog details page - where his new reblog entry is not shown, so the user may be left wondering 'where is the post that I just created'?
If the user then returns to the main blog feed page, their reblgo entry is correctly shown at the top of the page
It may be a neater solution to return to the main blog feed page immediately after the user enters their comments and taps the Reblog button to avoid the step where the user might be wondering what happened to the post they just submitted.
This happens only when reblogging from the blog details screen.
When reblogging from the main blog feed page, the user can see their new reblog post immediately upon return on that page.https://code.briarproject.org/briar/briar/-/issues/1994App goes into background spontaneously when memory is low2021-05-20T15:15:34ZakwizgranApp goes into background spontaneously when memory is lowOn the Galaxy Nexus (Android 4.3), Briar sometimes goes into the background spontaneously when memory is low.
This seems to happen because the app's importance is downgraded from IMPORTANCE_FOREGROUND to IMPORTANCE_VISIBLE when the app'...On the Galaxy Nexus (Android 4.3), Briar sometimes goes into the background spontaneously when memory is low.
This seems to happen because the app's importance is downgraded from IMPORTANCE_FOREGROUND to IMPORTANCE_VISIBLE when the app's showing a system dialog (in my case it was the Bluetooth discoverability dialog). BriarApplicationImpl#isRunningInBackground() considers anything other than IMPORTANCE_FOREGROUND to be background, so it allows BriarService to hide the UI to save memory.
Fixing this will require some care. When Briar's actually running in the background on this device it has an importance of IMPORTANCE_PERCEPTIBLE_PRE_26 (perhaps it's treated as perceptible because of the foreground service). But on other devices it might plausibly have IMPORTANCE_FOREGROUND_SERVICE (added in API 23) or IMPORTANCE_PERCEPTIBLE (added in API 26). Presumably new constants may be added in future versions.
The constants seem to be ordered, with lower values being more important:
* IMPORTANCE_FOREGROUND = 100
* IMPORTANCE_FOREGROUND_SERVICE = 125
* IMPORTANCE_PERCEPTIBLE_PRE_26 = 130
* IMPORTANCE_VISIBLE = 200
* IMPORTANCE_PERCEPTIBLE = 230
Unfortunately there's no cutoff we can choose such that the values for "running in the foreground, maybe with a system dialog" are on one side while the values for "running in the background with a foreground service" are on the other side.
I suspect there's an Android bug here: an app that would have IMPORTANCE_PERCEPTIBLE_PRE_26 when running in the background shouldn't be less important when it's running in the foreground but showing a system dialog. If I'm right and we can find out when the bug was fixed, maybe we can use some version-aware logic to work around this.https://code.briarproject.org/briar/briar/-/issues/2053Briar API. Communicate trough Briar using another Android app.2021-05-26T13:11:35ZVladislavBriar API. Communicate trough Briar using another Android app.Is there a way to communicate trough Briar API (send messages, write blog post), for example using Tasker or Easer.
I for example, would like to send messages with my location to a Private Group, from an app like GPSLogger, which already...Is there a way to communicate trough Briar API (send messages, write blog post), for example using Tasker or Easer.
I for example, would like to send messages with my location to a Private Group, from an app like GPSLogger, which already can post location to email, Dropbox, ftp, openGTS, OSM, ownCloud.
For example we can add list of trusted apps in Briar settings, that can post messages without requiring password.
Or, would be easier/safer to implement Bramble into this kind of app and create new user for it?https://code.briarproject.org/briar/briar/-/issues/1911Emoji Input does not work on LG-P875H (Android 4.4)2021-05-31T13:41:01ZTorsten GroteEmoji Input does not work on LG-P875H (Android 4.4)Clicking the emoji icon brings up the normal keyboard. The icon stays emoji. When clicking it again, it turns into a keyboard icon, but the keyboard itself is still shown without change.
Running Android 4.1.2Clicking the emoji icon brings up the normal keyboard. The icon stays emoji. When clicking it again, it turns into a keyboard icon, but the keyboard itself is still shown without change.
Running Android 4.1.2