briar issueshttps://code.briarproject.org/groups/briar/-/issues2021-07-16T23:11:52Zhttps://code.briarproject.org/briar/briar-gtk/-/issues/101Briar GTK Flatpak Error: Failed to load module2021-07-16T23:11:52ZLucy LuBriar GTK Flatpak Error: Failed to load moduleFollowing instructions from: https://code.briarproject.org/briar/briar-gtk#installation
```
$ flatpak run app.briar.gtk
Gtk-Message: Failed to load module "xapp-gtk3-module"
Gtk-Message: Failed to load module "canberra-gtk-module"
```Following instructions from: https://code.briarproject.org/briar/briar-gtk#installation
```
$ flatpak run app.briar.gtk
Gtk-Message: Failed to load module "xapp-gtk3-module"
Gtk-Message: Failed to load module "canberra-gtk-module"
```https://code.briarproject.org/briar/briar/-/issues/2131Not respective system theme setting causes wrong colors on MIUI 122021-07-22T11:18:23ZTorsten GroteNot respective system theme setting causes wrong colors on MIUI 12Our default theme is the light theme. The expected new behavior is to default to the system theme setting, so all apps look the same.
MIUI 12 running Android 11 is forcing apps to use a dark theme somehow causing Briar to use a fake dar...Our default theme is the light theme. The expected new behavior is to default to the system theme setting, so all apps look the same.
MIUI 12 running Android 11 is forcing apps to use a dark theme somehow causing Briar to use a fake dark theme while set to the light theme which looks bad and gets colors wrong. Navigating to settings => Display and changing theme to system default fixes this.https://code.briarproject.org/briar/briar/-/issues/2127Set a timer to log out automatically2021-07-23T11:16:02ZMaxim Kopylovichmaxim380k@mail.ruSet a timer to log out automatically
I'm trying to study the messenger stably.
If you only enter a password to log in to your account, it does not require you to enter a password anymore. Until the device is rebooted.
Please make a timer and the ability to choose after wh...
I'm trying to study the messenger stably.
If you only enter a password to log in to your account, it does not require you to enter a password anymore. Until the device is rebooted.
Please make a timer and the ability to choose after what time the program will log out of the account itself.https://code.briarproject.org/briar/briar/-/issues/2129misleading warning when reporting feedback without internet connection2021-07-23T11:22:15ZJens Kortemisleading warning when reporting feedback without internet connectionWhen bluetooth only is on and a feedback is sent, then the german message (something like) "Die Nachricht wird nächstes Mal geschickt, wenn Du Dich einloggst" (translation by me: The message will be sent, when you register next time) is ...When bluetooth only is on and a feedback is sent, then the german message (something like) "Die Nachricht wird nächstes Mal geschickt, wenn Du Dich einloggst" (translation by me: The message will be sent, when you register next time) is imho misleading. It should be something like "the next time you login and have an internet connection, your feedback will be sent".https://code.briarproject.org/briar/briar/-/issues/2120Wrong order of settings items2021-07-23T11:23:23ZStoyanWrong order of settings itemsIn the bottom part of the menu the connection options are ordered like that:
* Internet
* Wi-Fi
* Bluetooth
When you tap on any of them in the presented dialogue they are ordered the same way.
In `Settings > Connections` they are ordered...In the bottom part of the menu the connection options are ordered like that:
* Internet
* Wi-Fi
* Bluetooth
When you tap on any of them in the presented dialogue they are ordered the same way.
In `Settings > Connections` they are ordered differently:
* Bluetooth
* Wi-Fi
* Internet.https://code.briarproject.org/briar/briar/-/issues/2121Inconsistency in "add new" button position and icon2021-07-23T11:23:23ZStoyanInconsistency in "add new" button position and icon* Contacts are added with "+" button on bottom right;
* Private groups are added with "+" button on top right;
* Forums are added with "+" button on top right;
* Blogs are added with "pen" button on the top right after the three-dot-menu...* Contacts are added with "+" button on bottom right;
* Private groups are added with "+" button on top right;
* Forums are added with "+" button on top right;
* Blogs are added with "pen" button on the top right after the three-dot-menu. Additionally the "pen" stays when I read (at least my) blogs and I expected taping on it to actually edit the post;
* RSS feeds are added with "+" button on top right.
Unifying the position and symbol of the action will improve the UX.https://code.briarproject.org/briar/briar/-/issues/2124The empty RSS Feed screen differs from others2021-07-23T11:23:23ZStoyanThe empty RSS Feed screen differs from othersThe empty RSS Feed screen has different layout than the other sections of the app. Take for example the Blogs screen. The empty blog screen has large icon in the center with a title underneath and a small description under the title. The...The empty RSS Feed screen has different layout than the other sections of the app. Take for example the Blogs screen. The empty blog screen has large icon in the center with a title underneath and a small description under the title. The RSS Feed empty screen has two rows of text that feels like are not styled at all.https://code.briarproject.org/briar/briar/-/issues/2126Disappearing messages not deleting the messages after 7 days2021-07-23T14:35:14ZHimesaka NoaDisappearing messages not deleting the messages after 7 daysTo what I know and understand if you use Disapperaing message it should delete the message both on you and to the person you taking to. But to my case and to my friend we use Disappearing messages but when the time comes that it should b...To what I know and understand if you use Disapperaing message it should delete the message both on you and to the person you taking to. But to my case and to my friend we use Disappearing messages but when the time comes that it should be deleted the messages that we sent to each other are both present to mine and to my friend! Even my messages that I send to his is still present. Can you guys explain why? why it's not been deleted? is there something we need to do so the it will delete the messages? me and my friend are both enable the Disappearing feature.https://code.briarproject.org/briar/briar/-/issues/2134Ask for confirmation before leaving feedback screen if feedback has been written2021-07-26T09:39:13ZakwizgranAsk for confirmation before leaving feedback screen if feedback has been writtenA user accidentally left the feedback screen while dismissing the screen overlay dialog and lost the feedback they'd been writing. The user suggested that the app should ask for confirmation when leaving the screen if feedback has been e...A user accidentally left the feedback screen while dismissing the screen overlay dialog and lost the feedback they'd been writing. The user suggested that the app should ask for confirmation when leaving the screen if feedback has been entered.https://code.briarproject.org/briar/briar/-/issues/1943Warn the user when the last shutdown wasn't clean2021-07-26T10:31:11ZakwizgranWarn the user when the last shutdown wasn't cleanShow some kind of warning (a notification, or something in the main UI when signing in) when the last shutdown wasn't clean (see #57).
We may also want to know whether the dirty shutdown happened before or after the last reboot.
Subtas...Show some kind of warning (a notification, or something in the main UI when signing in) when the last shutdown wasn't clean (see #57).
We may also want to know whether the dirty shutdown happened before or after the last reboot.
Subtask of #1824.https://code.briarproject.org/briar/briar/-/issues/18Contacts can't communicate if clock difference is too large2021-07-28T10:11:31ZakwizgranContacts can't communicate if clock difference is too largeIf a device's clock is very inaccurate (e.g. because the user has adjusted the clock when travelling, rather than changing the timezone) then it's possible to add a contact, but not possible to communicate with the contact subsequently b...If a device's clock is very inaccurate (e.g. because the user has adjusted the clock when travelling, rather than changing the timezone) then it's possible to add a contact, but not possible to communicate with the contact subsequently because the devices disagree about which rotation period they're in.
We should check the clock difference when adding a contact and if the difference is excessive, display the time and timezone and warn the users to check that they're using the same timezone. We may also need to make the maximum expected clock difference much larger (on the order of 24 hours rather than an hour), as contacts may change their clocks after adding each other.https://code.briarproject.org/briar/briar/-/issues/1996Improve animal sniffer profile / get Android Studio to check non-Android modules2021-08-09T12:30:07ZSebastianImprove animal sniffer profile / get Android Studio to check non-Android modulesApparently the animal sniffer profile/signature is being a bit more strict when it comes to detecting what can be used and what cannot be used when compared to what Android Studio does. As a result, for example `Long#compare()` cannot be...Apparently the animal sniffer profile/signature is being a bit more strict when it comes to detecting what can be used and what cannot be used when compared to what Android Studio does. As a result, for example `Long#compare()` cannot be used in the non-Android modules, even though it is desugarable, but animal sniffer doesn't seem to know that.
We discussed two ideas:
* either find a different animal sniffer profile that knows better what works and what doesn't
* try to make Android Studio check desugarability (which is needed for somer lower Android versions) for the non-Android modules, too
Either way it would also be good to test this somehow, i.e. identify some candidates that should pass and some that should be rejected.
Apparently those are examples that should pass:
* `Long#compare()`
* `Objects#requireNonNull()`
What are examples that should fail, i.e. ones that are known not to be desugarable?https://code.briarproject.org/briar/briar/-/issues/1429Configure Animal Sniffer to allow try-with-resources2021-08-09T12:30:08ZakwizgranConfigure Animal Sniffer to allow try-with-resourcesThe Animal Sniffer plugin, which we use to check that our code is compatible with the Java 6 API provided by older Android devices, rejects the try-with-resources statement added in Java 7. This is unfortunate, as Android's desugar prepr...The Animal Sniffer plugin, which we use to check that our code is compatible with the Java 6 API provided by older Android devices, rejects the try-with-resources statement added in Java 7. This is unfortunate, as Android's desugar preprocessor converts the statement to Java 6-compatible bytecode, so it's usable on older devices.
We should look for a way to configure Animal Sniffer so the statement isn't rejected.https://code.briarproject.org/briar/briar/-/issues/2150Briar doesn't detect connectivity change when P2P hotspot is started2021-08-12T15:50:51ZakwizgranBriar doesn't detect connectivity change when P2P hotspot is startedWhen a P2P hotspot is started on the Pixel 2 (Android 11), Briar doesn't detect the connectivity change and thus the wifi plugin doesn't become active unless it's manually turned off and on again.When a P2P hotspot is started on the Pixel 2 (Android 11), Briar doesn't detect the connectivity change and thus the wifi plugin doesn't become active unless it's manually turned off and on again.https://code.briarproject.org/briar/briar/-/issues/2146Contact list - add symbols for unsent, sent and acknowledged messages next to...2021-08-16T14:08:59ZIvanaContact list - add symbols for unsent, sent and acknowledged messages next to the time stampWith the possibility now to export unsent messages onto a removable medium, the user may have some unsent to be exported messages in some conversations, whereas in other conversations they may have already exported all unsent messages, e...With the possibility now to export unsent messages onto a removable medium, the user may have some unsent to be exported messages in some conversations, whereas in other conversations they may have already exported all unsent messages, etc.
To make it easier for the user to see in which conversations there are unsent, sent or acknowledged messages, maybe the appropriate symbols can be added next to the timestamp for each contact in the contact list.
If done similarly as can be seen on the screenshot below, then the user would know that in the conversation with Belle, there are still messages that are not sent and some that are not acknowledged. ![device-2021-08-10-105617](/uploads/7c5ab2017b728eeba8415f0ad9ca1656/device-2021-08-10-105617.png)https://code.briarproject.org/briar/briar/-/issues/1778Onboarding tap target wrongly positioned2021-08-19T11:13:14ZakwizgranOnboarding tap target wrongly positionedThe onboarding tap target for the connections screen is meant to be centered on the Tor icon. On the Samsung Galaxy Ace 2 (Android 4.1.2) it's centered on the top left corner of the nav drawer instead.
I can reproduce this reliably on t...The onboarding tap target for the connections screen is meant to be centered on the Tor icon. On the Samsung Galaxy Ace 2 (Android 4.1.2) it's centered on the top left corner of the nav drawer instead.
I can reproduce this reliably on the device, but it doesn't happen on the emulator running the same API version (16).
![device-2020-09-24-124455](/uploads/4b87fcb4d94c44028ae2fb0cc72dbbb1/device-2020-09-24-124455.png)https://code.briarproject.org/briar/briar/-/issues/2155Test whether showing a toast from the app context causes an error/warning on ...2021-08-20T12:38:38ZakwizgranTest whether showing a toast from the app context causes an error/warning on Android 12https://code.briarproject.org/briar/briar/-/issues/2008Doze broadcasts aren't received on Nokia 3.12021-08-27T11:26:27ZakwizgranDoze broadcasts aren't received on Nokia 3.1A [log](/uploads/201f05a7ef28f09973eb8767649d3687/Nokia3.1-28042021-Snooze.log) from the [Snooze app](https://code.briarproject.org/akwizgran/snooze) running on the Nokia 3.1 doesn't show any broadcasts indicating that the device entered...A [log](/uploads/201f05a7ef28f09973eb8767649d3687/Nokia3.1-28042021-Snooze.log) from the [Snooze app](https://code.briarproject.org/akwizgran/snooze) running on the Nokia 3.1 doesn't show any broadcasts indicating that the device entered or left doze mode (device idle mode), unlike ten other devices that were tested. On all devices, the app was exempt from doze, running a foreground service and holding a wake lock.
If Briar likewise doesn't receive doze broadcasts on this device then it may fail to detect that its doze exemption has been removed. We only check the exemption status if a doze broadcast has been received since the last check.
I've asked @earthlingIB to run another test on this device without the doze exemption, to see whether it's the exemption that prevents the broadcasts from being received. If that's the case then we can close this ticket, as Briar will still be able to detect if its exemption has been removed.https://code.briarproject.org/briar/briar/-/issues/2160NPE when creating SettingsActivity2021-09-02T12:25:32ZakwizgranNPE when creating SettingsActivity* Android version: 11
* Phone model: Google Pixel 2 (walleye)
* Briar version: 1.3.6 debug (48292d2)
Stacktrace:
```
Unable to start activity ComponentInfo{org.briarproject.briar.android.debug/org.briarproject.briar.android.settings.Set...* Android version: 11
* Phone model: Google Pixel 2 (walleye)
* Briar version: 1.3.6 debug (48292d2)
Stacktrace:
```
Unable to start activity ComponentInfo{org.briarproject.briar.android.debug/org.briarproject.briar.android.settings.SettingsActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void androidx.appcompat.widget.DecorContentParent.setWindowCallback(android.view.Window$Callback)' on a null object reference
java.lang.RuntimeException: Unable to start activity ComponentInfo{org.briarproject.briar.android.debug/org.briarproject.briar.android.settings.SettingsActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void androidx.appcompat.widget.DecorContentParent.setWindowCallback(android.view.Window$Callback)' on a null object reference
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void androidx.appcompat.widget.DecorContentParent.setWindowCallback(android.view.Window$Callback)' on a null object reference
at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:900)
at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:806)
at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:547)
at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:534)
at androidx.appcompat.app.AppCompatActivity.getSupportActionBar(AppCompatActivity.java:139)
at org.briarproject.briar.android.settings.SettingsActivity.onCreate(SettingsActivity.java:37)
at android.app.Activity.performCreate(Activity.java:8000)
at android.app.Activity.performCreate(Activity.java:7984)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
... 11 more
```
Edited log:
```
08-16 11:07:39.533 I/BaseActivity: Destroying SettingsActivity
08-16 11:07:39.549 I/BaseActivity: Destroying NavDrawerActivity
08-16 11:08:10.265 I/BaseActivity: Creating SettingsActivity
08-16 11:08:10.271 I/SettingsViewModel: Loading settings took 12 ms
```https://code.briarproject.org/briar/briar/-/issues/1544AMOLED dark theme2021-09-23T12:30:59ZakwizgranAMOLED dark themeA user asked for an AMOLED dark theme (i.e. based on pure black).
Related to #976.A user asked for an AMOLED dark theme (i.e. based on pure black).
Related to #976.