briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-09-05T09:49:53Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/369Deleting messages doesn't update last message time and position in contact li...2022-09-05T09:49:53ZSebastianDeleting messages doesn't update last message time and position in contact list (instantly)When I delete a single or all message within a conversation, nothing happens in the last message section of the contact card in the contact list.
When I switch to settings and back to the conversation list:
* After deleting all messages...When I delete a single or all message within a conversation, nothing happens in the last message section of the contact card in the contact list.
When I switch to settings and back to the conversation list:
* After deleting all messages, I get "No messages." and the contact list moved to the top of the list.
* After deleting a single message, I see the time of deletion of the message (i.e. now). Also the contact moves to the top of the list.
I think in both cases the update should ideally also happen instantly when deleting the messages.https://code.briarproject.org/briar/briar-desktop/-/issues/223Pressing tab in new message text field actually adds tab characters to the me...2022-09-04T20:57:37ZMikolai GütschowPressing tab in new message text field actually adds tab characters to the messageInstead, I would expect it to cycle the focus through all other interactive elements, starting again at the top left. Shift-Tab behaves as expected.Instead, I would expect it to cycle the focus through all other interactive elements, starting again at the top left. Shift-Tab behaves as expected.Desktop 0.4.0https://code.briarproject.org/briar/briar-desktop/-/issues/249Update information in README regarding previews2022-09-04T20:39:39ZMikolai GütschowUpdate information in README regarding previewsCurrently it reads:
> Briar Desktop makes use of [Compose for Desktop](https://www.jetbrains.com/lp/compose/) to build its UI. The Intellij IDEA plugin [Compose Multiplatform IDE Support](https://plugins.jetbrains.com/plugin/16541-compo...Currently it reads:
> Briar Desktop makes use of [Compose for Desktop](https://www.jetbrains.com/lp/compose/) to build its UI. The Intellij IDEA plugin [Compose Multiplatform IDE Support](https://plugins.jetbrains.com/plugin/16541-compose-multiplatform-ide-support) provides static previews of composable functions without parameters which are annotated with `@Preview`.
We don't actually use those static previews, but our own, interactive ones.https://code.briarproject.org/briar/briar-desktop/-/issues/255Accent handling partially broken2022-09-04T20:37:38ZSebastianAccent handling partially brokenA user reported that accent handling doesn't work for our text input field in the conversation view. I.e. entering characters such as é, è, ê, ô, etc wouldn't work.
I can reproduce this partially and also actually noticed this sometime ...A user reported that accent handling doesn't work for our text input field in the conversation view. I.e. entering characters such as é, è, ê, ô, etc wouldn't work.
I can reproduce this partially and also actually noticed this sometime before while trying to enter literal backticks ("`")).
However, this doesn't seem to work always (or be broken all the time).
What I found is, that when I open a conversation and try to enter those characters, it doesn't work. If I then Alt-Tab to a different window and then Alt-Tab back to Briar Desktop, suddenly input works flawlessly and I can enter those characters without problems.https://code.briarproject.org/briar/briar-desktop/-/issues/358Revise Dispatchers.Swing usage to run code on UI thread2022-09-04T20:23:27ZSebastianRevise Dispatchers.Swing usage to run code on UI threadThe following discussion from !199 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/199#note_66074): (+1 comment)
> I had to add this explicit dependency...The following discussion from !199 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/199#note_66074): (+1 comment)
> I had to add this explicit dependency as described at https://github.com/JetBrains/compose-jb/releases/tag/v1.1.1.
>
> They also state that our use of Dispatchers.Swing that relies on Compose internally using this dispatcher for the UI drawing is probably not future-proof. We might want to look again into binding the events to a coroutineScope instead (related to #336).https://code.briarproject.org/briar/briar-desktop/-/issues/118[deb] NoClassDefFoundError: java/sql/SQLException2022-09-01T11:18:53ZNico[deb] NoClassDefFoundError: java/sql/SQLExceptionExecuting the .deb package currently fails with the following error:
```
➜ ~ /opt/briar-desktop/bin/Briar
Exception in thread "main" java.lang.NoClassDefFoundError: java/sql/SQLException
at org.briarproject.bramble.db.DatabaseModule.p...Executing the .deb package currently fails with the following error:
```
➜ ~ /opt/briar-desktop/bin/Briar
Exception in thread "main" java.lang.NoClassDefFoundError: java/sql/SQLException
at org.briarproject.bramble.db.DatabaseModule.provideDatabase(DatabaseModule.java:27)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.provideDatabase(DatabaseModule_ProvideDatabaseFactory.java:47)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.get(DatabaseModule_ProvideDatabaseFactory.java:36)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseFactory.get(DatabaseModule_ProvideDatabaseFactory.java:12)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseComponentFactory.get(DatabaseModule_ProvideDatabaseComponentFactory.java:40)
at org.briarproject.bramble.db.DatabaseModule_ProvideDatabaseComponentFactory.get(DatabaseModule_ProvideDatabaseComponentFactory.java:13)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.lifecycle.LifecycleManagerImpl_Factory.get(LifecycleManagerImpl_Factory.java:30)
at org.briarproject.bramble.lifecycle.LifecycleManagerImpl_Factory.get(LifecycleManagerImpl_Factory.java:10)
at org.briarproject.bramble.lifecycle.LifecycleModule_ProvideLifecycleManagerFactory.get(LifecycleModule_ProvideLifecycleManagerFactory.java:26)
at org.briarproject.bramble.lifecycle.LifecycleModule_ProvideLifecycleManagerFactory.get(LifecycleModule_ProvideLifecycleManagerFactory.java:9)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.bramble.cleanup.CleanupModule_ProvideCleanupManagerFactory.get(CleanupModule_ProvideCleanupManagerFactory.java:35)
at org.briarproject.bramble.cleanup.CleanupModule_ProvideCleanupManagerFactory.get(CleanupModule_ProvideCleanupManagerFactory.java:11)
at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
at org.briarproject.briar.desktop.DaggerBriarDesktopApp.injectEagerSingletons(DaggerBriarDesktopApp.java:1428)
at org.briarproject.briar.desktop.DaggerBriarDesktopApp.inject(DaggerBriarDesktopApp.java:1320)
at org.briarproject.bramble.BrambleCoreEagerSingletons$Helper.injectEagerSingletons(BrambleCoreEagerSingletons.java:48)
at org.briarproject.briar.desktop.Main.run(Main.kt:75)
at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:198)
at com.github.ajalt.clikt.parsers.Parser.parse(Parser.kt:18)
at com.github.ajalt.clikt.core.CliktCommand.parse(CliktCommand.kt:395)
at com.github.ajalt.clikt.core.CliktCommand.parse$default(CliktCommand.kt:392)
at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:410)
at com.github.ajalt.clikt.core.CliktCommand.main(CliktCommand.kt:435)
at org.briarproject.briar.desktop.MainKt.main(Main.kt:102)
Caused by: java.lang.ClassNotFoundException: java.sql.SQLException
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 27 more
Failed to launch JVM
```Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-mailbox/-/issues/145Briar Mailbox was unable to run in the background: crash when clicking "fix"2022-08-31T10:18:01ZSebastianBriar Mailbox was unable to run in the background: crash when clicking "fix"Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/2362Timestamps in contact list (and maybe other lists) aren't updated2022-08-30T13:17:55ZakwizgranTimestamps in contact list (and maybe other lists) aren't updatedTimestamps in the contact list aren't updated if the screen timeout is set to less than 1 minute, as the refresher task is cancelled when the screen turns off.
Other BriarRecyclerViews may be affected if they don't reload their data or ...Timestamps in the contact list aren't updated if the screen timeout is set to less than 1 minute, as the refresher task is cancelled when the screen turns off.
Other BriarRecyclerViews may be affected if they don't reload their data or redraw their lists when started/resumed.https://code.briarproject.org/briar/briar-desktop/-/issues/370Accessibility for chat history2022-08-28T19:18:41ZSebastianAccessibility for chat historyI tried out using VoiceOver on the chat history and noticed that it reads out message text and date/time.
It does not read out whether a message is delivered or not.
It also does not read out the fact that a message is one own's messag...I tried out using VoiceOver on the chat history and noticed that it reads out message text and date/time.
It does not read out whether a message is delivered or not.
It also does not read out the fact that a message is one own's message or the contact's message.
I think both things should probably be added.Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/372Tooltip does not work on all icon buttons (hidpi issue?)2022-08-18T21:00:24ZSebastianTooltip does not work on all icon buttons (hidpi issue?)While testing !221 I noticed that on my hidpi Linux device, the tooltips for the icon buttons don't work there, while they do work on a regular machine. Maybe it has to do with the high density resolution, no idea, but that is the only t...While testing !221 I noticed that on my hidpi Linux device, the tooltips for the icon buttons don't work there, while they do work on a regular machine. Maybe it has to do with the high density resolution, no idea, but that is the only thing I know is different on that machine.https://code.briarproject.org/briar/briar/-/issues/2354After remote wiping - add a small confirmation message that wiping was succes...2022-08-18T09:42:16ZIvanaAfter remote wiping - add a small confirmation message that wiping was successfulAfter remote wiping of the mailbox app, there is no any kind of confirmation message to the user that the wiping was successful.
After discussion in the MM testing channel today, it was concluded that a message may be nice, and maybe t...After remote wiping of the mailbox app, there is no any kind of confirmation message to the user that the wiping was successful.
After discussion in the MM testing channel today, it was concluded that a message may be nice, and maybe the toast message would be the easiest to do.
Reporting this ticket to keep track of this issueMailbox: Unpairingakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/2351Add privacy policy to "about" screen2022-08-17T12:53:42ZakwizgranAdd privacy policy to "about" screenGoogle's user data policy requires apps to contain a link to the developer's privacy policy. We should add this link to the about screen, and maybe also to the crash report and feedback screens (since those are the only places where data...Google's user data policy requires apps to contain a link to the developer's privacy policy. We should add this link to the about screen, and maybe also to the crash report and feedback screens (since those are the only places where data is sent to us).Android 1.4https://code.briarproject.org/briar/briar/-/issues/2357Upload APK signatures and checksums during build2022-08-17T12:15:10ZakwizgranUpload APK signatures and checksums during buildakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/2356Investigate flaky unit tests2022-08-17T11:54:27ZakwizgranInvestigate flaky unit testsBefore !1697 was merged, we saw a couple of pipelines failing in the same place:
https://code.briarproject.org/briar/briar/-/jobs/21288
https://code.briarproject.org/briar/briar/-/jobs/21301
The same tests failed after merging to mast...Before !1697 was merged, we saw a couple of pipelines failing in the same place:
https://code.briarproject.org/briar/briar/-/jobs/21288
https://code.briarproject.org/briar/briar/-/jobs/21301
The same tests failed after merging to master:
https://code.briarproject.org/briar/briar/-/jobs/21335
Somehow two unit tests seem to have become flaky:
https://code.briarproject.org/briar/briar/-/blob/bcc7a4b93b28b0e252082bdcf4eb6175fd2d66d3/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java#L297
https://code.briarproject.org/briar/briar/-/blob/bcc7a4b93b28b0e252082bdcf4eb6175fd2d66d3/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java#L1900akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1808Download data from mailbox2022-08-17T10:10:55ZakwizgranDownload data from mailboxWrite backend code to download a file from the user's own mailbox or a contact's mailbox into a temporary directory, try to read a simplex stream from the local file, and delete the file from the mailbox and the temporary directory.
Dep...Write backend code to download a file from the user's own mailbox or a contact's mailbox into a temporary directory, try to read a simplex stream from the local file, and delete the file from the mailbox and the temporary directory.
Depends on #1804.Mailbox2022-10-31https://code.briarproject.org/briar/briar/-/issues/1807Upload data to mailbox2022-08-17T10:10:33ZakwizgranUpload data to mailboxWrite backend code to create a temporary file, write a simplex stream to the file, and upload the file to the user's own mailbox or a contact's mailbox.
Depends on #1804.Write backend code to create a temporary file, write a simplex stream to the file, and upload the file to the user's own mailbox or a contact's mailbox.
Depends on #1804.Mailbox2022-10-31https://code.briarproject.org/briar/briar/-/issues/1811Update Bramble protocol stack to support syncing via mailbox2022-08-17T10:09:50ZakwizgranUpdate Bramble protocol stack to support syncing via mailboxWhen communicating via mailboxes, the max latency and thus the retransmission interval are very long, so we need to be careful about any circumstances that could cause messages to be lost.
On the sender side, if an error (such as an IO ...When communicating via mailboxes, the max latency and thus the retransmission interval are very long, so we need to be careful about any circumstances that could cause messages to be lost.
On the sender side, if an error (such as an IO error, app crash or device crash) occurs while we're writing messages to a file, we need to ensure that those messages can be sent again after recovering from the error. Ideally this should apply to acks too.
On the receiver side, if an error occurs while we're reading messages from a file, we need to ensure that the file can be read again after recovering from the error.Mailbox2022-10-31https://code.briarproject.org/briar/briar/-/issues/2352Don't upload to mailbox when directly connected to contact2022-08-17T10:03:32ZakwizgranDon't upload to mailbox when directly connected to contactWhile we're directly connected to a contact we should stop creating files to send to the contact via our own mailbox or the contact's mailbox. Files that have already been created should be uploaded, and downloads should continue as norm...While we're directly connected to a contact we should stop creating files to send to the contact via our own mailbox or the contact's mailbox. Files that have already been created should be uploaded, and downloads should continue as normal.
The mailbox upload worker (#2291) is probably the best place to add this.Mailbox: Manage mailbox connectionsakwizgranakwizgranhttps://code.briarproject.org/briar/briar-desktop/-/issues/371Use constants as (screen) padding values throughout the code base2022-08-17T07:59:49ZMikolai GütschowUse constants as (screen) padding values throughout the code basesimilar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)similar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)https://code.briarproject.org/briar/briar/-/issues/2283Add menu item to select custom tor bridge2022-08-17T05:41:15ZJohan SchmurgeAdd menu item to select custom tor bridgeAdd menu item to select custom tor bridge. In some countries public tor bridges are blocked, and app does not work. Using custom bridges resolve this problem as it do in tor browser.Add menu item to select custom tor bridge. In some countries public tor bridges are blocked, and app does not work. Using custom bridges resolve this problem as it do in tor browser.