briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-01-18T15:03:45Zhttps://code.briarproject.org/briar/briar/-/issues/2250Refuse to start app on Android 4 beyond expiry date2022-01-18T15:03:45ZakwizgranRefuse to start app on Android 4 beyond expiry dateWhen the expiry date for Android 4 has been reached the app should refuse to start. This can use a similar mechanism to the existing ExpiredActivity for debug builds.
We might want to provide a button that deletes the user's account, if...When the expiry date for Android 4 has been reached the app should refuse to start. This can use a similar mechanism to the existing ExpiredActivity for debug builds.
We might want to provide a button that deletes the user's account, if that's easy to achieve, or just let the user know that their account will be deleted when they uninstall the app.
Subtask of #2221.MailboxDaniel LublinDaniel Lublin2022-01-17https://code.briarproject.org/briar/briar-desktop/-/issues/173Introduction with empty message raises exception2022-01-18T13:36:35ZSebastianIntroduction with empty message raises exceptionwhen making an introduction and leaving the introduction message blank I get this exception:
```
java.lang.IllegalArgumentException: null
at org.briarproject.briar.introduction.MessageEncoderImpl.encodeRequestMessage(MessageEncoderImpl...when making an introduction and leaving the introduction message blank I get this exception:
```
java.lang.IllegalArgumentException: null
at org.briarproject.briar.introduction.MessageEncoderImpl.encodeRequestMessage(MessageEncoderImpl.java:114)
at org.briarproject.briar.introduction.AbstractProtocolEngine.sendRequestMessage(AbstractProtocolEngine.java:115)
at org.briarproject.briar.introduction.IntroducerProtocolEngine.onLocalRequest(IntroducerProtocolEngine.java:230)
at org.briarproject.briar.introduction.IntroducerProtocolEngine.onRequestAction(IntroducerProtocolEngine.java:76)
at org.briarproject.briar.introduction.IntroductionManagerImpl.makeIntroduction(IntroductionManagerImpl.java:363)
at org.briarproject.briar.desktop.introduction.IntroductionViewModel$makeIntroduction$1.invoke(IntroductionViewModel.kt:77)
at org.briarproject.briar.desktop.introduction.IntroductionViewModel$makeIntroduction$1.invoke(IntroductionViewModel.kt:74)
at org.briarproject.briar.desktop.viewmodel.DbViewModel$runOnDbThread$1.invoke(DbViewModel.kt:29)
at org.briarproject.briar.desktop.viewmodel.DbViewModel$runOnDbThread$1.invoke(DbViewModel.kt:26)
at org.briarproject.briar.desktop.threading.BriarExecutorsImpl.onDbThread$lambda-0(BriarExecutorsImpl.kt:15)
at org.briarproject.bramble.TimeLoggingExecutor.lambda$execute$0(TimeLoggingExecutor.java:35)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
```
where I read:
```java
@Override
public Message encodeRequestMessage(GroupId contactGroupId, long timestamp,
@Nullable MessageId previousMessageId, Author author,
@Nullable String text) {
if (text != null && text.isEmpty()) {
throw new IllegalArgumentException();
}
BdfList body = BdfList.of(
REQUEST.getValue(),
previousMessageId,
clientHelper.toList(author),
text
);
return createMessage(contactGroupId, timestamp, body);
}
```
We copied from Android that the message is optional, and I just confirmed it is optional there, however, I don't know how. Maybe we replace a `null` message with an empty string there.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/11Private chats2022-01-18T09:16:38ZMikolai GütschowPrivate chatsDesktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/201Write another short Transifex announcement2022-01-17T22:05:42ZNicoWrite another short Transifex announcement* beta release on January 21st with almost full private chat experience
* people can test translations with nightly builds (https://code.briarproject.org/briar/briar-desktop/-/merge_requests/96)
* we'll make sure to update translations o...* beta release on January 21st with almost full private chat experience
* people can test translations with nightly builds (https://code.briarproject.org/briar/briar-desktop/-/merge_requests/96)
* we'll make sure to update translations on a (daily?) basis till that date
Depending on whether @sebkur and @ialokim want to have a chat with Muna vom LocLab this week, we should wait for this or publish it without having talked to her before.Desktop 0.1.0NicoNico2022-01-15https://code.briarproject.org/briar/briar-desktop/-/issues/157Image attachement support2022-01-17T20:52:33ZMikolai GütschowImage attachement supportaccording to @seb quite similar to #88according to @seb quite similar to #88Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/3BriarService currently ignores startup errors2022-01-16T14:41:31ZNicoBriarService currently ignores startup errorsSee https://code.briarproject.org/briar/briar/-/issues/2089
- `lifecycleManager.startServices(dbKey)` is currently called directly from [`Login.kt`](https://code.briarproject.org/briar/briar-desktop/-/blob/29b93b8558f93caeb81049800cd374...See https://code.briarproject.org/briar/briar/-/issues/2089
- `lifecycleManager.startServices(dbKey)` is currently called directly from [`Login.kt`](https://code.briarproject.org/briar/briar-desktop/-/blob/29b93b8558f93caeb81049800cd3747a93ad7f5d/src/main/kotlin/org/briarproject/briar/desktop/dialogs/Login.kt) and [`Registration.kt`](https://code.briarproject.org/briar/briar-desktop/-/blob/29b93b8558f93caeb81049800cd3747a93ad7f5d/src/main/kotlin/org/briarproject/briar/desktop/dialogs/Registration.kt) and indeed ignores startup errors
- this issue should be addressed after properly restructuring those calls into another class (e.g. `BriarService`)
List of encountered errors:
- `org.briarproject.bramble.api.db.DataTooNewException`Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/57Handle invalid account registration2022-01-16T14:41:31ZSebastianHandle invalid account registrationEmpty username raises an `IllegalArgumentException` and I guess we can just check if the username is empty before continuing.
The password strength calculator should be used before accepting a password.Empty username raises an `IllegalArgumentException` and I guess we can just check if the username is empty before continuing.
The password strength calculator should be used before accepting a password.Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/63Add second password field to registration screen2022-01-16T14:41:30ZSebastianAdd second password field to registration screenDesktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/website/-/issues/19Create a "Press" page2022-01-14T14:01:27ZCleopatraCreate a "Press" pageOver the years, a lot of articles have been written about Briar. It'll be nice to have a page that shows all this press coverage.
The Press page should also have Briar brand assets, how to get support, videos and contact information. Th...Over the years, a lot of articles have been written about Briar. It'll be nice to have a page that shows all this press coverage.
The Press page should also have Briar brand assets, how to get support, videos and contact information. This should promote more press coverage.CleopatraCleopatrahttps://code.briarproject.org/briar/website/-/issues/8Add Videos to Website2022-01-14T14:01:27ZTorsten GroteAdd Videos to WebsiteWe currently have three video recordings of Briar presentations. Maybe it would be nice to add those to the website?We currently have three video recordings of Briar presentations. Maybe it would be nice to add those to the website?CleopatraCleopatrahttps://code.briarproject.org/briar/website/-/issues/30Update "Building the Source Code" guide2022-01-13T17:42:40ZCleopatraUpdate "Building the Source Code" guideThe [guide on how to build Briar from source](https://briarproject.org/building-the-source-code/) is a bit outdated. It should be updated for the latest version of Android Studio.The [guide on how to build Briar from source](https://briarproject.org/building-the-source-code/) is a bit outdated. It should be updated for the latest version of Android Studio.CleopatraCleopatrahttps://code.briarproject.org/briar/briar/-/issues/1286Build fails with verification error when following instructions on website2022-01-13T17:42:40ZakwizgranBuild fails with verification error when following instructions on websiteA user reported that the Android Studio build failed with "an error about dependencies, we think it is because of the checksum" when following the build instructions on the website.
Sounds like it could be related to recent changes in t...A user reported that the Android Studio build failed with "an error about dependencies, we think it is because of the checksum" when following the build instructions on the website.
Sounds like it could be related to recent changes in the way jtorctl and the Tor binaries are downloaded and verified.https://code.briarproject.org/briar/briar/-/issues/2252Password screen when setting up the account on new account - shows password w...2022-01-13T13:39:04ZIvanaPassword screen when setting up the account on new account - shows password when it should be hidden and the other way aroundSteps to execute
- Install briar debug on a device (I sued Pixel 2)
- Enter a nickname into the Nickname field when asked
- On the next screen type in the password
Expected results
- Password should be visible when they 'eye' icon is ...Steps to execute
- Install briar debug on a device (I sued Pixel 2)
- Enter a nickname into the Nickname field when asked
- On the next screen type in the password
Expected results
- Password should be visible when they 'eye' icon is on, and hidden when the 'eye' icon is crossed
Actual results
- Password behaves the other way around, it shows when the 'eye' icon is crossed, and it is masked when the 'eye' icon is not crossed.
- Screenshot attached
![device-2022-01-13-141405](/uploads/a1566f1ae139000bf68707d26a224089/device-2022-01-13-141405.png)https://code.briarproject.org/briar/briar-desktop/-/issues/83Improve main screen when having no contacts2022-01-13T12:50:15ZNicoImprove main screen when having no contactshttps://code.briarproject.org/briar/briar-desktop/-/merge_requests/28 added support for adding contacts, but when we have no contacts, the main screen is all white and doesn't allow us to click the add contact button :joy:
With !33, the...https://code.briarproject.org/briar/briar-desktop/-/merge_requests/28 added support for adding contacts, but when we have no contacts, the main screen is all white and doesn't allow us to click the add contact button :joy:
With !33, the main screen is not all white anymore, but just shows as "TBD" placeholder instead of a nice and colorful image.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/193Remove conversation menu items that do not work yet2022-01-12T11:36:06ZSebastianRemove conversation menu items that do not work yet* self-destructing messages
* Connections submenu
* rename contact (unless we move #158 into the 0.1.0 milestone)* self-destructing messages
* Connections submenu
* rename contact (unless we move #158 into the 0.1.0 milestone)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/199Show different placeholder screen if pending contact is selected2022-01-12T11:32:46ZMikolai GütschowShow different placeholder screen if pending contact is selectedCurrently, it looks like the following. It would be best to display some information about what it means for a contact to be pending.
![image](/uploads/451a4a64648af2face680c6ef6330253/image.png)Currently, it looks like the following. It would be best to display some information about what it means for a contact to be pending.
![image](/uploads/451a4a64648af2face680c6ef6330253/image.png)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/197Display avatars in contact intro drawer, if available2022-01-12T10:58:39ZSebastianDisplay avatars in contact intro drawer, if availableDesktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/87Handle long names in contact list2022-01-11T22:26:24ZMikolai GütschowHandle long names in contact listWhile testing !22 I found this visual glitch for (the actually not so long name) *Joseph Louis Lagrange*:
![image](/uploads/f2e7835605a58050bffd3368a734cdf2/image.png)
We should decide on how this should be handled:
- Should the name be...While testing !22 I found this visual glitch for (the actually not so long name) *Joseph Louis Lagrange*:
![image](/uploads/f2e7835605a58050bffd3368a734cdf2/image.png)
We should decide on how this should be handled:
- Should the name be cut after a given amount of characters to something like *Joseph Louis Lagr...*?
- Should we wrap the name to a second line? (I remember we were advised not to do so in the UX coaching)
- Would we like the name to be shown in a scrolling fashion (like a ticker)?Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/161Show scrollbar in scrollable areas2022-01-09T18:37:01ZMikolai GütschowShow scrollbar in scrollable arease.g. the message history, contact list
see https://github.com/JetBrains/compose-jb/tree/master/tutorials/Desktop_Components#scrollbarse.g. the message history, contact list
see https://github.com/JetBrains/compose-jb/tree/master/tutorials/Desktop_Components#scrollbarsDesktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/35Message View: Tight control of scrolling2022-01-09T18:37:00ZMikolai GütschowMessage View: Tight control of scrollingTo, e.g., start the first new message in the private chat view. Currently we reverse the message order and always start at the bottom of the list.
See https://code.briarproject.org/briar/briar-desktop/-/merge_requests/5#note_53309To, e.g., start the first new message in the private chat view. Currently we reverse the message order and always start at the bottom of the list.
See https://code.briarproject.org/briar/briar-desktop/-/merge_requests/5#note_53309Desktop 0.1.0Mikolai GütschowMikolai Gütschow