briar issueshttps://code.briarproject.org/groups/briar/-/issues2020-12-31T12:06:36Zhttps://code.briarproject.org/briar/briar-gtk/-/issues/27Refactor code2020-12-31T12:06:36ZNicoRefactor codeSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruGTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/71Allow multiple lines in input field2020-12-31T12:05:29ZNicoAllow multiple lines in input fieldDino.im handles it in a way I like personally.Dino.im handles it in a way I like personally.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/70Limit input width just like message texts width2020-12-31T12:05:26ZNicoLimit input width just like message texts widthWhile we limit the width of messages in the chat history, the input is stretched from one end to another.
I guess we need to put the `Gtk.Entry` in a `Handy.Leaflet`, just like Fractal:
![fractal-4.0-screenshot](/uploads/92eb9f5cdc4dfb...While we limit the width of messages in the chat history, the input is stretched from one end to another.
I guess we need to put the `Gtk.Entry` in a `Handy.Leaflet`, just like Fractal:
![fractal-4.0-screenshot](/uploads/92eb9f5cdc4dfb083d2bf72e5414ffa6/fractal-4.0-screenshot.png)GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/84Use Briar blue instead of theme selected color2020-12-16T14:02:59ZNicoUse Briar blue instead of theme selected colorCurrently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g...Currently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g. Linux Mint it's green. There, the difference between own and their usernames is not visible that much, because both names are colored in green. We should use the Briar blue code instead, so that we have blue-green on all platforms.GTK 0.1.0-beta3x0lootsx0lootshttps://code.briarproject.org/briar/briar/-/issues/1855Update profile pictures in contact list2020-12-16T13:01:41ZSebastianUpdate profile pictures in contact listMake sure that the profile pictures update in the contact list automatically when one of the contacts changes their avatar.Make sure that the profile pictures update in the contact list automatically when one of the contacts changes their avatar.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1856Update profile picture in current chat's app bar2020-12-16T12:59:18ZSebastianUpdate profile picture in current chat's app barLike #1855 we need to update the avatar once it changesLike #1855 we need to update the avatar once it changesProfile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1832Store self-destruct timer duration2020-12-16T12:58:10ZakwizgranStore self-destruct timer durationFor each contact, store the local timer duration for self-destructing messages and the time when it was updated. When a message is received from the contact with a different timer duration and higher timestamp, update the local timer dur...For each contact, store the local timer duration for self-destructing messages and the time when it was updated. When a message is received from the contact with a different timer duration and higher timestamp, update the local timer duration. There should also be methods for setting the duration manually and querying the duration when sending a message.
Subtask of #804Self-destructing messagesakwizgranakwizgran2021-01-31https://code.briarproject.org/briar/briar-gtk/-/issues/49briar-gtk flatpak on librm5_devkit2020-12-16T09:21:16Zfphemeralbriar-gtk flatpak on librm5_devkithere the (admitteldy hacky) steps to reproduce
getting briar-gtk alpha flatpak to work on librm5_devkit aarch64
## patched briar headless
cloned briar repo
applied two patches:
```diff
+++ b/bramble-core/src/main/java/org/briarproject...here the (admitteldy hacky) steps to reproduce
getting briar-gtk alpha flatpak to work on librm5_devkit aarch64
## patched briar headless
cloned briar repo
applied two patches:
```diff
+++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java
@@ -192,7 +192,7 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
// Load the settings
settings = callback.getSettings();
// Install or update the assets if necessary
- if (!assetsAreUpToDate()) installAssets();
+ //if (!assetsAreUpToDate()) installAssets();
if (cookieFile.exists() && !cookieFile.delete())
LOG.warning("Old auth cookie not deleted");
// Start a new Tor process
+++ b/bramble-java/src/main/java/org/briarproject/bramble/plugin/tor/UnixTorPluginFactory.java
@@ -82,13 +82,13 @@ public class UnixTorPluginFactory implements DuplexPluginFactory {
@Override
public DuplexPlugin createPlugin(PluginCallback callback) {
// Check that we have a Tor binary for this architecture
- String architecture = null;
- if (isLinux()) {
- String arch = System.getProperty("os.arch");
- if (arch.equals("amd64")) {
- architecture = "linux-x86_64";
- }
- }
+ String architecture = "linux-aarch64";
+ //if (isLinux()) {
+ // String arch = System.getProperty("os.arch");
+ // if (arch.equals("amd64")) {
+ // architecture = "linux-x86_64";
+ // }
+ //}
if (architecture == null) {
LOG.info("Tor is not supported on this architecture");
return null;
```
compiled briar-headless
as also described in
http://4g375hpowkjyopwa7c5lm7f4ovzhceezvscm342uklflfpl3mcxxhxyd.onion/briar_headless_on_librem5_devkit.html
## briar-gtk build flatpak
git cloned:
https://code.briarproject.org/briar/briar-gtk
`git submodule update --init`
built flatpak as advertised via:
`flatpak-builder --install-deps-from=flathub --user --install --force-clean --ccache flatpak-builddir app.briar.gtk.json`
## run shell in flatpak container
`flatpak run --command=sh app.briar.gtk`
first replacing briar headless with the patched version for aarch64
`cp /home/purism/dl/briar/briar-headless/build/libs/briar-headless.jar /home/purism/.local/share/flatpak/app/app.briar.gtk/aarch64/master/active/files/briar/briar-headless.jar`
starting briar headless inside the flatpak
`java -jar /app/briar/briar-headless.jar`
which complains about the not visible (from flatpak perspective) distro tor dependencies.
so copy dependencies into flatpak as well:
libevent-2.1.so.6:
`cp /usr/lib/aarch64-linux-gnu/libevent-2.1.so.6.0.2 /home/purism/.local/share/flatpak/runtime/org.gnome.Platform/aarch64/3.36/active/files/lib/aarch64-linux-gnu/libevent-2.1.so.6`
libzstd.so.1:
`cp /usr/lib/aarch64-linux-gnu/libzstd.so.1.3.8 /home/purism/.local/share/flatpak/runtime/org.gnome.Platform/aarch64/3.36/active/files/lib/aarch64-linux-gnu/libzstd.so.1`
with that briar-headless runs fine.
## briar-gtk python key error
python key error, so I disabled the two lines of code:
remove/comment-out lines 30 and 31 of
/home/purism/.local/share/flatpak/app/app.briar.gtk/aarch64/master/active/files/lib/python3.7/site-packages/briar_wrapper/models/contacts.pyhttps://code.briarproject.org/briar/briar/-/issues/1859Menu item to enable/disable disappearing messages2020-12-11T10:45:21ZSebastianMenu item to enable/disable disappearing messagesSelf-destructing messagesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1842Add message ID of profile picture to Identity, Contact and AuthorInfo classes2020-12-11T10:34:39ZakwizgranAdd message ID of profile picture to Identity, Contact and AuthorInfo classesThis field will be null for identities without a profile picture, or those whose profile picture is unknown.
Subtask of #214This field will be null for identities without a profile picture, or those whose profile picture is unknown.
Subtask of #214Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1845Show profile picture in AuthorView using Glide2020-12-11T10:34:26ZakwizgranShow profile picture in AuthorView using GlideIf an AuthorInfo specifies a profile picture, AuthorView should load it using Glide instead of showing an identicon.
Depends on #1842 and #1844. Subtask of #214.If an AuthorInfo specifies a profile picture, AuthorView should load it using Glide instead of showing an identicon.
Depends on #1842 and #1844. Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1848Test performance of profile picture loading and caching2020-12-11T10:34:16ZakwizgranTest performance of profile picture loading and cachingCheck that performance is acceptable when loading a conversation with a large number of profile pictures (eg a forum with posts from many contacts).
Depends on #1845. Subtask of #214.Check that performance is acceptable when loading a conversation with a large number of profile pictures (eg a forum with posts from many contacts).
Depends on #1845. Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1847UI for choosing profile picture2020-12-11T10:34:02ZakwizgranUI for choosing profile pictureAdd an item to the settings screen that shows the user's current profile picture (if any) with a button for choosing a new picture.
Create a new confirmation screen that shows the chosen picture cropped to a circle, with an explanation ...Add an item to the settings screen that shows the user's current profile picture (if any) with a button for choosing a new picture.
Create a new confirmation screen that shows the chosen picture cropped to a circle, with an explanation that the picture will only be visible to contacts and buttons to confirm or cancel the choice.
Depends on #1844, #1846. Subtask of #214.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1794No internet connection on IPv6-only network2020-12-11T10:33:06ZpegazNo internet connection on IPv6-only networkHi there,
I've got a big red message at the bottom of my screen saying "no internet connection" when i try to add my first contact, just connected to data of my phone.
I known my phone provider use only ipv6, is that a possible issue?
...Hi there,
I've got a big red message at the bottom of my screen saying "no internet connection" when i try to add my first contact, just connected to data of my phone.
I known my phone provider use only ipv6, is that a possible issue?
Thanks for the job done!Android 1.2akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1846Refactor image compression code for reuse outside messaging client2020-12-07T11:49:19ZakwizgranRefactor image compression code for reuse outside messaging clientFactor out AttachmentCreationTask#compressImage() so it can be reused when storing the user's profile picture.
Subtask of #214.Factor out AttachmentCreationTask#compressImage() so it can be reused when storing the user's profile picture.
Subtask of #214.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1838Show a bomb icon on messages with self-destruct timers2020-12-03T14:02:14ZakwizgranShow a bomb icon on messages with self-destruct timersSubtask of #804Subtask of #804Self-destructing messagesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1831Update private group sharing client to include a self-destruct timer in each ...2020-11-30T12:45:14ZakwizgranUpdate private group sharing client to include a self-destruct timer in each messageSubtask of #804Subtask of #804Self-destructing messagesakwizgranakwizgran2021-01-31https://code.briarproject.org/briar/briar/-/issues/1830Update blog and forum sharing clients to include a self-destruct timer in eac...2020-11-30T12:45:14ZakwizgranUpdate blog and forum sharing clients to include a self-destruct timer in each messageSubtask of #804Subtask of #804Self-destructing messagesakwizgranakwizgran2021-01-31https://code.briarproject.org/briar/briar/-/issues/1829Update introduction client to include a self-destruct timer in each message2020-11-30T12:45:13ZakwizgranUpdate introduction client to include a self-destruct timer in each messageSubtask of #804Subtask of #804Self-destructing messagesakwizgranakwizgran2021-01-31https://code.briarproject.org/briar/briar/-/issues/1828Update messaging client to include a self-destruct timer in each message2020-11-30T12:45:13ZakwizgranUpdate messaging client to include a self-destruct timer in each messageSubtask of #804Subtask of #804Self-destructing messagesakwizgranakwizgran2021-01-31