briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-01-21T14:12:16Zhttps://code.briarproject.org/briar/briar/-/issues/1802Sync data via SD card or USB stick on Android2022-01-21T14:12:16ZakwizgranSync data via SD card or USB stick on AndroidImplement a plugin and user interface for syncing data via external storage (SD card or USB stick) on Android.Implement a plugin and user interface for syncing data via external storage (SD card or USB stick) on Android.Transfer content securely via SD cards and USB memory sticksIvanaIvana2021-07-31https://code.briarproject.org/briar/briar-desktop/-/issues/168Prepare website for release2022-01-21T13:10:43ZSebastianPrepare website for releaseDepends on #167Depends on #167Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/210Copy 0.1.0 beta artifacts to release server for persistence2022-01-21T13:10:04ZSebastianCopy 0.1.0 beta artifacts to release server for persistenceI think nightly builds are deleted after a few days, if we want our 0.1.0 release to be available longer, we need to copy it somewhere.I think nightly builds are deleted after a few days, if we want our 0.1.0 release to be available longer, we need to copy it somewhere.Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/252Release 0.1.0-beta2022-01-21T13:08:39ZNicoRelease 0.1.0-beta* [x] Change version in build config
* [x] Finish https://code.briarproject.org/briar/briar-desktop/-/issues/245
* [x] Update translations
* [x] Tag in Git
* [x] Build release files with GitLab CI
* [x] Copy release files to desktop.bria...* [x] Change version in build config
* [x] Finish https://code.briarproject.org/briar/briar-desktop/-/issues/245
* [x] Update translations
* [x] Tag in Git
* [x] Build release files with GitLab CI
* [x] Copy release files to desktop.briarproject.org
* [x] Check that permalink points to correct version
* [x] Publish website update
* [x] Post on social mediaDesktop 0.1.0https://code.briarproject.org/briar/briar-desktop/-/issues/251CI-builds have <unknown> branch in BuildData2022-01-21T11:47:11ZSebastianCI-builds have <unknown> branch in BuildDataSee this:
![Screenshot_from_2022-01-21_07-51-42](/uploads/c4f2ac678e007fdf948514433781edc4/Screenshot_from_2022-01-21_07-51-42.png)
Changing the CI settings the way it clones didn't help to change this.
Apparently after cloning, the ...See this:
![Screenshot_from_2022-01-21_07-51-42](/uploads/c4f2ac678e007fdf948514433781edc4/Screenshot_from_2022-01-21_07-51-42.png)
Changing the CI settings the way it clones didn't help to change this.
Apparently after cloning, the CI does something like `git checkout abcdef12345` and therefore is in detached state.
Possible solution: https://stackoverflow.com/a/69268083/1268759Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/317Remove binaries from git history2022-01-21T09:59:52ZakwizgranRemove binaries from git historyThe git repo is huge. Rewrite the commit history to remove unnecessary binaries (fonts, android.jar, etc).
We could also remove the Tor binaries and any jars that have been converted to Gradle dependencies, but that would make it imposs...The git repo is huge. Rewrite the commit history to remove unnecessary binaries (fonts, android.jar, etc).
We could also remove the Tor binaries and any jars that have been converted to Gradle dependencies, but that would make it impossible to build old commits that used those binaries.https://code.briarproject.org/briar/briar-desktop/-/issues/243Make AboutDialog accessible on Startup and Expired screen2022-01-20T22:32:46ZMikolai GütschowMake AboutDialog accessible on Startup and Expired screenby means of a (?) button in one of the corners, probably
Follow-up of !105by means of a (?) button in one of the corners, probably
Follow-up of !105Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/247(Visual) difference between images sent without text from Android and Desktop2022-01-20T22:23:02ZMikolai Gütschow(Visual) difference between images sent without text from Android and Desktopsee the following screenshot: the first image was sent from the Desktop and the second from Android, both without a message text. It seems like Desktop sends an empty string instead of null here?
![image](/uploads/8c5e7463b36bb35e640672...see the following screenshot: the first image was sent from the Desktop and the second from Android, both without a message text. It seems like Desktop sends an empty string instead of null here?
![image](/uploads/8c5e7463b36bb35e640672488f53a4ec/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/246Compressing large images fails2022-01-20T22:19:34ZSebastianCompressing large images failsOn Android we first reduce the images size to a maximum of 1000px using a loop that downsamples to 1/4th of the images size in the previous iteration (by halving both width and height) and only then start compressing in yet another loop ...On Android we first reduce the images size to a maximum of 1000px using a loop that downsamples to 1/4th of the images size in the previous iteration (by halving both width and height) and only then start compressing in yet another loop that reduces JPEG quality in every iteration.
See https://code.briarproject.org/briar/briar/-/blob/master/briar-android/src/main/java/org/briarproject/briar/android/attachment/media/ImageCompressorImpl.java#L42
I forgot to implement the first part and only do the second loop. Hence some images end up being not compressable to the desired size.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/178Create Ubuntu-compatible deb packages2022-01-20T13:39:10ZSebastianCreate Ubuntu-compatible deb packagesCurrently, our nightly build deb packages work on debian, but not on Ubuntu, see:
https://code.briarproject.org/briar/briar-desktop/-/merge_requests/44#note_58849
Would be nice to have nightly-built packages for this as Ubuntu and some ...Currently, our nightly build deb packages work on debian, but not on Ubuntu, see:
https://code.briarproject.org/briar/briar-desktop/-/merge_requests/44#note_58849
Would be nice to have nightly-built packages for this as Ubuntu and some of its derivatives such as Mint are very popular distros.Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/82Warn users of potential attack when creating contacts2022-01-20T13:18:02ZNicoWarn users of potential attack when creating contacts@grote or @akwizgran informed me of this potential attack back in the old days of Briar GTK. An attacker might try to find out which contacts a user has, which we try to prevent by implementing the following logic from the Android client...@grote or @akwizgran informed me of this potential attack back in the old days of Briar GTK. An attacker might try to find out which contacts a user has, which we try to prevent by implementing the following logic from the Android client:
https://code.briarproject.org/briar/briar/-/blob/beta-1.2.14/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java#L139
Also see the respective MR at Briar GTK https://code.briarproject.org/briar/briar-gtk/-/merge_requests/97 where I tried to re-implement it, but we should follow the Android's logic because that one got peer reviewed.
Sub task of https://code.briarproject.org/briar/briar-desktop/-/issues/81.
Follow up to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/28.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/81Create proper dialogs when failing at contact creation2022-01-20T13:06:23ZNicoCreate proper dialogs when failing at contact creationFollow-up to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/28.Follow-up to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/28.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/225Version numbering in deb inconsistent with our versioning scheme2022-01-19T19:28:55ZSebastianVersion numbering in deb inconsistent with our versioning schemeI think according to our current versioning scheme we're working on version `0.1.0`.
When installing the deb package, it prints:
```
Unpacking briar-desktop (0.0.1-1) over (0.0.1-1) ...
Setting up briar-desktop (0.0.1-1) ...
```
which l...I think according to our current versioning scheme we're working on version `0.1.0`.
When installing the deb package, it prints:
```
Unpacking briar-desktop (0.0.1-1) over (0.0.1-1) ...
Setting up briar-desktop (0.0.1-1) ...
```
which looks like it has somehow a different version number set.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/233Properly wire feature flag functionality in ConversationVisitor2022-01-19T18:02:58ZNicoProperly wire feature flag functionality in ConversationVisitorRelated to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/111?
* https://code.briarproject.org/briar/briar-desktop/-/blob/d1e668dec33d8f309a6f6d99bbc8b4af015475d2/src/main/kotlin/org/briarproject/briar/desktop/conver...Related to https://code.briarproject.org/briar/briar-desktop/-/merge_requests/111?
* https://code.briarproject.org/briar/briar-desktop/-/blob/d1e668dec33d8f309a6f6d99bbc8b4af015475d2/src/main/kotlin/org/briarproject/briar/desktop/conversation/ConversationVisitor.kt#L90
* https://code.briarproject.org/briar/briar-desktop/-/blob/d1e668dec33d8f309a6f6d99bbc8b4af015475d2/src/main/kotlin/org/briarproject/briar/desktop/conversation/ConversationVisitor.kt#L134
* https://code.briarproject.org/briar/briar-desktop/-/blob/d1e668dec33d8f309a6f6d99bbc8b4af015475d2/src/main/kotlin/org/briarproject/briar/desktop/conversation/ConversationVisitor.kt#L178Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/241Wrong string format according to Transifex2022-01-19T17:16:24ZMikolai GütschowWrong string format according to TransifexWe've just got this mail from Transifex:
> A resource could not be auto-updated
>
> Transifex was unable to auto update the file Briar Desktop. Fetching from the following URL failed https://code.briarproject.org/briar/briar-desktop/-/...We've just got this mail from Transifex:
> A resource could not be auto-updated
>
> Transifex was unable to auto update the file Briar Desktop. Fetching from the following URL failed https://code.briarproject.org/briar/briar-desktop/-/raw/main/src/main/resources/strings/BriarDesktop.properties. The error message from the server was:
>
> Invalid plural types for string: expiration.banner.part1. Language supports: ['one', 'other'], but found: ['zero', 'one', 'other'] instead.
>
> Please make sure the URL provided for the file is accessible, or update the link to the file.
> If you plan to stop auto-update for this file, please disregard this message.
That's a regression from the expiration banner MR since I used the message format to also have a special version for "today" (daysLeft = zero). I didn't know it was not possible to use this form in English. I guess the fix would be to manually check for today (tomorrow?) in the code and have two different strings then?Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/194Add About/Credits dialog2022-01-19T16:11:03ZSebastianAdd About/Credits dialogCould show:
* Copyright
* Authors
* License
* Thanks notices
* Libraries used and their licenses
* Donation addresses Bitcoin/Ether etc
* Version number
* Git hash app was built fromCould show:
* Copyright
* Authors
* License
* Thanks notices
* Libraries used and their licenses
* Donation addresses Bitcoin/Ether etc
* Version number
* Git hash app was built fromDesktop 0.1.0https://code.briarproject.org/briar/briar/-/issues/2254QR screen hangs if user leave Briar and go to permission manager and denies l...2022-01-19T10:36:04ZIvanaQR screen hangs if user leave Briar and go to permission manager and denies location permission during the creation of nearby contactReproducible on devices: Pixel 2 API 30, Samsung A01 Core API 29, Motorola E2 API 23
It does not happen on HTC One M9 API 24
## Steps to execute
- Verify that Briar debug has location and camera permissions granted in the device setting...Reproducible on devices: Pixel 2 API 30, Samsung A01 Core API 29, Motorola E2 API 23
It does not happen on HTC One M9 API 24
## Steps to execute
- Verify that Briar debug has location and camera permissions granted in the device settings
- Go to 'add nearby contact'
- Follow instructions, and when the QR code is displayed, go to the device settings and deny the locaiton permission to Briar debug
- Return to Briar debug
- re-login when asked
## expected results
- the QR screen that was showing before, displays again
## actual results
- the QR screen hangs. See attached.![device-2022-01-18-141734](/uploads/bbc47c7fbbd01b50beba5f971278fa6c/device-2022-01-18-141734.mp4)[QR_screen_hangs_on_Pixel2.txt](/uploads/48d5e18d8e704108f0fbf9869ce77ad9/QR_screen_hangs_on_Pixel2.txt)https://code.briarproject.org/briar/briar-desktop/-/issues/159Let users delete contacts2022-01-18T21:44:06ZMikolai GütschowLet users delete contactsThis might be implemented or in the contact list (with right-click?) or in the context menu (the three dots) in the conversation view.This might be implemented or in the contact list (with right-click?) or in the context menu (the three dots) in the conversation view.Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/140Check TODO notes in code before release2022-01-18T21:03:04ZSebastianCheck TODO notes in code before releaseAt some point, we should check whether any of the TODO notes in code needs to be resolved before the first release for example. Create issues for them or might solve them direct.At some point, we should check whether any of the TODO notes in code needs to be resolved before the first release for example. Create issues for them or might solve them direct.Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/235Check if factoring out some scrollbar related logic makes sense2022-01-18T20:28:35ZMikolai GütschowCheck if factoring out some scrollbar related logic makes senseThe following discussion from !105 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/105#note_60777):
> Might be also good to have those scrollbar-related...The following discussion from !105 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/105#note_60777):
> Might be also good to have those scrollbar-related things as a reusable component in the future.