briar issueshttps://code.briarproject.org/groups/briar/-/issues2021-04-26T12:52:47Zhttps://code.briarproject.org/briar/briar/-/issues/1960Design "Connect via Bluetooth" feature2021-04-26T12:52:47ZTorsten GroteDesign "Connect via Bluetooth" featureSub-task of #1821Sub-task of #1821Adapt to changes in the Android platformTorsten GroteTorsten Grote2021-04-30https://code.briarproject.org/briar/briar/-/issues/1959When the 'Disappearing messages' setting is changed during the message compos...2021-04-30T13:35:24ZIvanaWhen the 'Disappearing messages' setting is changed during the message composing, no warning message in landscape orientationSteps to reproduce
Start typing a message on device1 in portrait orientation and before sending it, go to the menu in the upper right corner and change the Disappearing messages setting to On.
Continue typing the message and then send...Steps to reproduce
Start typing a message on device1 in portrait orientation and before sending it, go to the menu in the upper right corner and change the Disappearing messages setting to On.
Continue typing the message and then send.
A warning message appears in the portrait orientation, that says: "Disappearing messages changed, since you started composing your message, disappearing messages have been enabled"
Now start typing a message and the change the Disappearing setting before sending the message, turn the phone to landscape and continue typing; Then send the message.
Actual results: The message is sent OK, but the warning message does not show.
Expected results: the warning message shoudl show the same way as it does in portrait orientationhttps://code.briarproject.org/briar/briar/-/issues/1958Bomb icon disappears from the text input field in landscape orientation when ...2021-03-08T12:29:21ZIvanaBomb icon disappears from the text input field in landscape orientation when the keyboard comes upSteps to reproduce the issue:
Go to menu in the upper right corner and change Disappearing messages setting to ON
Start typing a message to a contact, and verify that there is a little bomb icon in the text input field as you are typing...Steps to reproduce the issue:
Go to menu in the upper right corner and change Disappearing messages setting to ON
Start typing a message to a contact, and verify that there is a little bomb icon in the text input field as you are typing... then change the orientation of device. Continue typing.
Expected result:
The bomb icon shows in the text input field the same way as it does in the portrait orientation
Actual results:
The bomb icon does not show int he text input field when the keyboard is up.
Turning the device back into portrait orientation - bomb icon in the text input field is visible again.![device-2021-03-03-123142](/uploads/211a76c6a292e5e923b93787a5fb9ad3/device-2021-03-03-123142.mp4)Self-destructing messages2021-01-31https://code.briarproject.org/briar/briar/-/issues/1957All conversation messages are marked as read via messaging manager2021-05-05T16:08:47ZakwizgranAll conversation messages are marked as read via messaging managerThe setReadFlag() method is declared in the ConversationClient interface, but only MessagingManagerImpl's implementation of the method is used (except for one integration test).
If clients don't need their own implementations, the metho...The setReadFlag() method is declared in the ConversationClient interface, but only MessagingManagerImpl's implementation of the method is used (except for one integration test).
If clients don't need their own implementations, the method could be moved to the MessagingManager or ConversationManager interface, and the unused implementation in ConversationClientImpl could be removed.
On the other hand, if clients *do* need their own implementations then the implementation in ConversationClientImpl should be updated and we should make sure that ConversationViewModel and (eventually) MessagingControllerImpl call the right client for each message.
Test instructions:
* repeat tests from !1389Self-destructing messagesIvanaIvana2021-01-31https://code.briarproject.org/briar/briar-gtk/-/issues/99React on ConversationMessagesDeletedEvents2021-03-02T12:19:12ZNicoReact on ConversationMessagesDeletedEventsPointed out by @grote in https://code.briarproject.org/briar/briar/-/merge_requests/1384#note_47198. Once https://code.briarproject.org/briar/briar-gtk/-/issues/80 is there this will be really easy.Pointed out by @grote in https://code.briarproject.org/briar/briar/-/merge_requests/1384#note_47198. Once https://code.briarproject.org/briar/briar-gtk/-/issues/80 is there this will be really easy.GTK 0.2.0-beta1https://code.briarproject.org/briar/briar/-/issues/1956Disguise/mask app2023-06-19T08:42:38ZCleopatraDisguise/mask appIt will be cool if there was a way to disguise the Briar app so that an adversary can't see the app icon on the user's device.
I like the way the [Umbrella app](https://github.com/securityfirst/Umbrella_android) does it. You can click ...It will be cool if there was a way to disguise the Briar app so that an adversary can't see the app icon on the user's device.
I like the way the [Umbrella app](https://github.com/securityfirst/Umbrella_android) does it. You can click a button to disguise the app as a calculator app. While in the calculator app, you shake the device to unmask the app.
![umbrella-mask](/uploads/d7f0d519ff301f4ea246ecab88c401c6/umbrella-mask.png)https://code.briarproject.org/briar/briar/-/issues/1955Don't advertise support for self-destructing messages unless feature flag is ...2021-03-08T17:58:12ZakwizgranDon't advertise support for self-destructing messages unless feature flag is enabledTo avoid receiving self-destructing messages when the UI for the feature is disabled by a feature flag, we shouldn't tell our contacts we support the new version of the messaging client unless the feature flag is enabled.To avoid receiving self-destructing messages when the UI for the feature is disabled by a feature flag, we shouldn't tell our contacts we support the new version of the messaging client unless the feature flag is enabled.Self-destructing messagesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1954Voice messages2023-02-26T08:07:02ZakwizgranVoice messagesSeveral users have asked to be able to send asynchronous voice messages (voice notes). This request was previously recorded under #985 (voice/video calls) but I'm moving it to its own ticket as the requirements and implementation are dif...Several users have asked to be able to send asynchronous voice messages (voice notes). This request was previously recorded under #985 (voice/video calls) but I'm moving it to its own ticket as the requirements and implementation are different.
Relevant comments from #985:
* https://code.briarproject.org/briar/briar/-/issues/985#note_28705
* https://code.briarproject.org/briar/briar/-/issues/985#note_44100
* https://code.briarproject.org/briar/briar/-/issues/985#note_47061https://code.briarproject.org/briar/briar/-/issues/1953Dialog about "Disappearing messages changed" for image only messages2021-03-08T12:27:51ZSebastianDialog about "Disappearing messages changed" for image only messages![issue](/uploads/8e8d903d76bddc993f68dfc1af183ae6/issue.png)
The "Disappearing messages changed" appears although it shouldn't.
Steps to reproduce:
1. open a fresh, empty conversation
2. enable disappearing messages
3. (optional: send...![issue](/uploads/8e8d903d76bddc993f68dfc1af183ae6/issue.png)
The "Disappearing messages changed" appears although it shouldn't.
Steps to reproduce:
1. open a fresh, empty conversation
2. enable disappearing messages
3. (optional: send a text message and notice that the dialog does not appear)
4. send an image message (without text) and see the dialog appear
It doesn't work just once, it works repeatedly and also after sending more text-only or image-with-text messagesSelf-destructing messagesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1952Crash - when changing or canceling profile pictures2021-07-06T10:06:10ZIvanaCrash - when changing or canceling profile picturesSteps to reproduce:
HTC One M9 API 24 -
Log into the briar
1. Go to settings > tap on 'tap here to change your profile picture'
2. Select a picture available in your phone
3. When the popup appears, select 'cancel'.
Go back to step 1...Steps to reproduce:
HTC One M9 API 24 -
Log into the briar
1. Go to settings > tap on 'tap here to change your profile picture'
2. Select a picture available in your phone
3. When the popup appears, select 'cancel'.
Go back to step 1 and 2
This has been reproduced 3 times... here are the logfiles from Android studio.
[change_of_profile_pictures_3.txt](/uploads/2be2b0296e1e4a386f41e6ce31fbae13/change_of_profile_pictures_3.txt)[crash_when_changing_profile_picture_2.txt](/uploads/fb32103ee1133301809083e9331bd5f5/crash_when_changing_profile_picture_2.txt)[Crash_when_changing_profile_pictures.txt](/uploads/bdbcba54c0d8ff0a966a3effe4dd2d2e/Crash_when_changing_profile_pictures.txt)
version under test: beta 1.2.16 8a534b45Profile picturesIvanaIvana2021-01-31https://code.briarproject.org/briar/briar/-/issues/1951Exclude files from D2D backups2021-03-15T13:29:35ZTorsten GroteExclude files from D2D backupsWhen targeting API 30: When using device-to-device backup our `allowBackup=false` will be ignored and our app data will get backed up, if we don't explicitly exclude files from backup.
Subtask of #1827When targeting API 30: When using device-to-device backup our `allowBackup=false` will be ignored and our app data will get backed up, if we don't explicitly exclude files from backup.
Subtask of #1827Adapt to changes in the Android platformTorsten GroteTorsten Grote2021-04-30https://code.briarproject.org/briar/briar/-/issues/1950Briar 5 dakika sonra kapanıyor.2021-02-22T11:28:57ZWuukoBriar 5 dakika sonra kapanıyor.Briar açıldıktan 5 dakika sonra eğer aktif değilsem kapanıyor. Aktifsem kapanmıyor.
Telefon: huawei y7
Sürüm:8.2
Note: I wrote in Turkish because my English was bad.Briar açıldıktan 5 dakika sonra eğer aktif değilsem kapanıyor. Aktifsem kapanmıyor.
Telefon: huawei y7
Sürüm:8.2
Note: I wrote in Turkish because my English was bad.https://code.briarproject.org/briar/briar/-/issues/1949Make it easier to distinguish between replying and writing a new post in a fo...2021-02-20T11:46:47ZakwizgranMake it easier to distinguish between replying and writing a new post in a forum or private groupIn a recent testing session we noticed that it was easy to accidentally write a top-level post in a forum or private group when intending to reply to another post.
Some things that might help:
* Increase the visual difference between th...In a recent testing session we noticed that it was easy to accidentally write a top-level post in a forum or private group when intending to reply to another post.
Some things that might help:
* Increase the visual difference between the "replying" state and the "writing a new post" state (eg look at what Signal does)
* Increase the size of the reply button so it's easier to hit
* Allow a reply to be started by right-swiping a post
Related to #1948, as we currently use the same highlighting for the post being replied to as we use for unread posts.https://code.briarproject.org/briar/briar/-/issues/1948Improve unread message highlighting in forums and private groups2021-02-20T11:46:50ZakwizgranImprove unread message highlighting in forums and private groupsIn a recent testing session we noticed that it's hard to distinguish between read and unread messages in forums and private groups, especially when using the dark theme.
Adding some kind of border or badge to unread messages, as well as...In a recent testing session we noticed that it's hard to distinguish between read and unread messages in forums and private groups, especially when using the dark theme.
Adding some kind of border or badge to unread messages, as well as or instead of using a different background colour, might help.https://code.briarproject.org/briar/briar/-/issues/1947NPE when forum post arrives before parent is loaded2021-02-19T17:55:49ZakwizgranNPE when forum post arrives before parent is loaded* Android version: 4.1.2
* Phone model: Samsung Galaxy Ace 2 (GT-I8160)
* Briar version: 1.2.15 (885b03c) (debug build)
The crash happened when I opened a forum from the invitation message in a private conversation, then quickly hit the...* Android version: 4.1.2
* Phone model: Samsung Galaxy Ace 2 (GT-I8160)
* Briar version: 1.2.15 (885b03c) (debug build)
The crash happened when I opened a forum from the invitation message in a private conversation, then quickly hit the back button.
Stacktrace:
```
java.lang.NullPointerException
at org.briarproject.briar.client.MessageTreeImpl.parseNode(MessageTreeImpl.java:74)
at org.briarproject.briar.client.MessageTreeImpl.add(MessageTreeImpl.java:50)
at org.briarproject.briar.client.MessageTreeImpl.add(MessageTreeImpl.java:57)
at org.briarproject.briar.android.threaded.ThreadListViewModel.addItem(ThreadListViewModel.java:200)
at org.briarproject.briar.android.forum.ForumViewModel.eventOccurred(ForumViewModel.java:98)
at org.briarproject.bramble.event.EventBusImpl.lambda$broadcast$0(EventBusImpl.java:42)
at org.briarproject.bramble.event.EventBusImpl.lambda$broadcast$0$EventBusImpl(EventBusImpl.java)
at org.briarproject.bramble.event.-$$Lambda$EventBusImpl$clxOMxNLcHINGTGi9tkg-7meojQ.run(lambda)
at android.os.Handler.handleCallback(Handler.java:615)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4867)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1007)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:774)
at dalvik.system.NativeStart.main(Native Method)
```
Edited log:
```
02-19 14:29:35.867 I/BaseActivity: Pausing ConversationActivity
02-19 14:29:35.918 I/BaseActivity: Creating ForumActivity
02-19 14:29:36.128 I/BaseActivity: Starting ForumActivity
02-19 14:29:36.129 I/BaseActivity: Resuming ForumActivity
02-19 14:29:36.253 I/DuplexOutgoingSession: Generated ack: true
02-19 14:29:36.254 I/DuplexOutgoingSession: Sent ack
02-19 14:29:36.643 I/BaseActivity: Pausing ForumActivity
02-19 14:29:36.692 I/BaseActivity: Resuming ConversationActivity
02-19 14:29:36.763 I/ForumViewModel: Forum post received, adding...
```
The message tree assumes that when a message is added, its parent (which is a dependency) is already in the tree.
ForumViewModel logs the amount of time taken to load the message headers and bodies. This is a debug build, so messages logged with logDuration() would appear in the log. Those messages don't appear in the log, so it looks like the new message was added to the tree before the initial load completed, so its parent was present in the DB but not in the tree.Android 1.2akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/1946Text in blog comments has no padding on the left side (API 16)2021-09-02T12:26:21ZakwizgranText in blog comments has no padding on the left side (API 16)On the Galaxy Ace 2 (Android 4.1.2) blog posts are shown with the correct amount of padding but comments are not: the text touches the left side of the card. On other devices posts and comments have a similar amount of padding.
![device...On the Galaxy Ace 2 (Android 4.1.2) blog posts are shown with the correct amount of padding but comments are not: the text touches the left side of the card. On other devices posts and comments have a similar amount of padding.
![device-2021-02-19-142657](/uploads/afce2bc980a7e1ed9be254a25696e3ec/device-2021-02-19-142657.png)Android 1.3IvanaIvanahttps://code.briarproject.org/briar/briar/-/issues/1945Previous/next unread message buttons sometimes don't appear2021-03-29T13:00:18ZakwizgranPrevious/next unread message buttons sometimes don't appearOn the Galaxy Ace 2 (Android 4.1.2), the previous/next unread message buttons in forums and private groups don't always appear. The small badge showing the number of unread messages above/below is shown, but not the large button it's sup...On the Galaxy Ace 2 (Android 4.1.2), the previous/next unread message buttons in forums and private groups don't always appear. The small badge showing the number of unread messages above/below is shown, but not the large button it's supposed to be attached to.
Sometimes the large button appears late, after the badge, and sometimes it doesn't appear at all. Turning the screen off and on doesn't make a difference, but scrolling causes the large button to appear.
![device-2021-02-19-154020](/uploads/25f68f4b6ce2652f62d0a2d963675d12/device-2021-02-19-154020.png)https://code.briarproject.org/briar/briar/-/issues/1944Changing a contact name does not update the contact list immediately2021-04-26T12:09:06ZSebastianChanging a contact name does not update the contact list immediatelyTest instructions:
* Enter a conversation
* Open the menu
* Select 'change contact name'
* Enter a new alias and confirm
* Navigate back to the contact list
* Observe that the alias of the contact has already changed when arriving at the...Test instructions:
* Enter a conversation
* Open the menu
* Select 'change contact name'
* Enter a new alias and confirm
* Navigate back to the contact list
* Observe that the alias of the contact has already changed when arriving at the contact list
* Variant A: change the contact name to nothing (empty string into dialog)
* Variant B: after the contact alias was empty, change back to some non-empty aliasAdapt to changes in the Android platformIvanaIvana2021-04-30https://code.briarproject.org/briar/briar/-/issues/1943Warn the user when the last shutdown wasn't clean2021-07-26T10:31:11ZakwizgranWarn the user when the last shutdown wasn't cleanShow some kind of warning (a notification, or something in the main UI when signing in) when the last shutdown wasn't clean (see #57).
We may also want to know whether the dirty shutdown happened before or after the last reboot.
Subtas...Show some kind of warning (a notification, or something in the main UI when signing in) when the last shutdown wasn't clean (see #57).
We may also want to know whether the dirty shutdown happened before or after the last reboot.
Subtask of #1824.https://code.briarproject.org/briar/briar/-/issues/1942Profile picture isn't shown if settings screen is recreated after process was...2021-04-26T12:13:43ZakwizgranProfile picture isn't shown if settings screen is recreated after process was killedSteps to reproduce:
* Open the Briar settings screen
* Leave Briar running in the foreground and turn the screen off
* Use the ADB shell to kill the Briar process
* Turn the screen back on
* The Briar password prompt is shown
* Sign into...Steps to reproduce:
* Open the Briar settings screen
* Leave Briar running in the foreground and turn the screen off
* Use the ADB shell to kill the Briar process
* Turn the screen back on
* The Briar password prompt is shown
* Sign into Briar
* The settings screen is shown
* The profile picture isn't loaded
![device-2021-02-18-143535](/uploads/264e108ebbe0be0b9acb706e3080bfe1/device-2021-02-18-143535.png)
Tested on the Nexus 5X (Android 8.1.0).Adapt to changes in the Android platformakwizgranakwizgran2021-04-30