briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-09-10T08:35:04Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/196Easify read-only access to settings2022-09-10T08:35:04ZNicoEasify read-only access to settingsThis may or may not be done already as part of !49.
From https://code.briarproject.org/briar/briar-desktop/-/merge_requests/49#note_57372:
> Yes, that should work at least. However for the access to settings we might want to think abou...This may or may not be done already as part of !49.
From https://code.briarproject.org/briar/briar-desktop/-/merge_requests/49#note_57372:
> Yes, that should work at least. However for the access to settings we might want to think about other ways than reusing the view model that is mostly designed for the settings screen, including functions to update the settings. I fear we might need to use this `viewModel()` call then at several places where we actually only need to look up a single setting.
>
> I'm not sure if that's the best way, but I would rather have a `SettingsGateway` or `SettingsAdapter` (feel free to come up with a better naming) that would be provided using `CompositionLocalProvider` as well. This class would only give read-access to the settings then.Desktop 0.4.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/160Move focus when clicking on a contact2023-01-09T21:41:07ZMikolai GütschowMove focus when clicking on a contactCurrently, if the user pressed on the filter text field before, the focus stays there and they can continue to enter text there.Currently, if the user pressed on the filter text field before, the focus stays there and they can continue to enter text there.Desktop 0.4.0https://code.briarproject.org/briar/briar-desktop/-/issues/156Show native notification for new messages / new contacts2023-02-21T11:27:38ZMikolai GütschowShow native notification for new messages / new contactsThis should :tm: be easy with Compose: https://github.com/JetBrains/compose-jb/tree/master/tutorials/Tray_Notifications_MenuBar_new
We have to decide what should be shown in the notification: The actual message text or as in Android onl...This should :tm: be easy with Compose: https://github.com/JetBrains/compose-jb/tree/master/tutorials/Tray_Notifications_MenuBar_new
We have to decide what should be shown in the notification: The actual message text or as in Android only a generic "You have {} new message(s)".Desktop 0.4.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/148Raise translation limit for inclusion in release2022-05-10T20:35:30ZMikolai GütschowRaise translation limit for inclusion in releaseFollow-up of !59
> We shouldn't include every single translation language, since some of them have only a few percent of our strings translated.
>
> I chose 50% as a limit for now, which I also used for GTK iirc. Later on we should prob...Follow-up of !59
> We shouldn't include every single translation language, since some of them have only a few percent of our strings translated.
>
> I chose 50% as a limit for now, which I also used for GTK iirc. Later on we should probably increase this. The Localization Lab people recommend 100% and reviewed, but I find this too harsh, given that it's all run by volunteers. Briar Android is using 80%, iirc, which sounds like a good choice for a first stable release.Desktop 0.4.0https://code.briarproject.org/briar/briar-desktop/-/issues/133Show notification badge for new messages in BriarSidebar2023-01-17T11:11:44ZMikolai GütschowShow notification badge for new messages in BriarSidebarSee the discussion at https://code.briarproject.org/briar/briar-desktop/-/issues/108#note_57164:
@paul-lorenc:
> Would it also make sense to add a blue notification badge to the sidebar above the type of incoming message? For example, i...See the discussion at https://code.briarproject.org/briar/briar-desktop/-/issues/108#note_57164:
@paul-lorenc:
> Would it also make sense to add a blue notification badge to the sidebar above the type of incoming message? For example, if you are having a one-on-one conversation with a contact, it might be useful to see that there are unread messages in the private group or forum tabs. I don't think a numbered message badge is needed, just a simple blue or green badge to indicate there are new messages in that tab. If something like this would be somewhat simple, I think it would help UX a lot.
@akwizgran:
> Yeah, on Android it looks like we depend on ContactListFragment reloading the contact list to update the unread count when the user returns from a conversation to the contact list (which incidentally makes me wonder how briar#2145 ever existed - apparently the problem was not what I thought).
>
> To update the contact list's unread count via events we'd want to do something similar to briar!1541, wrapping MessageTracker#setReadFlag() and broadcasting an event with the contact ID. Fortunately ConversationManager already wraps that method, so we don't need to refactor any callers, just add the event. So the first part of this should be easy.
>
> Similarly, we can display the unread counts and timestamps for individual forums and private groups by adding an event broadcast to ForumManager and PrivateGroupManager's existing wrappers around MessageTracker methods.
>
> Blogs don't seem to use GroupCounts at all, so there's a big pile of work to do there.
>
> And then finally we'd want to display an aggregate count for all private conversations, another aggregate count for all forums, etc, in the sidebar (nav drawer on Android). We could add methods to ConversationManager, ForumManager, PrivateGroupManager and BlogManager (after adding GroupCounts to the individual blogs) to calculate these aggregate counts when first loading the sidebar, and then update the aggregate counts via the same events that would be used to update the individual counts.
The related upstream issue is https://code.briarproject.org/briar/briar/-/issues/42 and the custom event introduced in https://code.briarproject.org/briar/briar-desktop/-/merge_requests/46#note_56940 could be adapted for this.Desktop 0.4.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/31Make Briar Desktop work on Windows2023-01-11T10:28:00ZNicoMake Briar Desktop work on WindowsJust this: [Native distributions & local execution](https://github.com/JetBrains/compose-jb/blob/master/tutorials/Native_distributions_and_local_execution/README.md)
Similar to https://code.briarproject.org/briar/briar/-/merge_requests/...Just this: [Native distributions & local execution](https://github.com/JetBrains/compose-jb/blob/master/tutorials/Native_distributions_and_local_execution/README.md)
Similar to https://code.briarproject.org/briar/briar/-/merge_requests/1376.
Related to https://code.briarproject.org/briar/briar/-/issues/2165.
Depends on https://code.briarproject.org/briar/tor-reproducer/-/issues/2.Desktop 0.4.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/13Forums2023-02-02T14:59:58ZMikolai GütschowForumsDesktop 0.4.0Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/172Update target SDK to 332023-02-07T13:23:54ZSebastianUpdate target SDK to 33MailboxTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/163Notification does not update when app is in background2023-02-07T13:22:57ZSebastianNotification does not update when app is in backgroundI think we had this problem before and also solved it at some point, but it seems we have a regression.
Steps to reproduce:
* start non-paired mailbox
* put mailbox into background while it is starting up
* on logs, observe that tor get...I think we had this problem before and also solved it at some point, but it seems we have a regression.
Steps to reproduce:
* start non-paired mailbox
* put mailbox into background while it is starting up
* on logs, observe that tor gets into published state
* observe that the notification is still "Starting mailbox…"
* switch back to app which should be at the qr code screen now
* observe that notification has now changed to "Waiting for Briar to scan QR code…"
We're collecting the app state in MainActivity only when the activity is started, so it makes sense that currently no updates get processed when the activity is in the background.MailboxIvanaIvanahttps://code.briarproject.org/briar/briar/-/issues/2352Don't upload to mailbox when directly connected to contact2022-08-17T10:03:32ZakwizgranDon't upload to mailbox when directly connected to contactWhile we're directly connected to a contact we should stop creating files to send to the contact via our own mailbox or the contact's mailbox. Files that have already been created should be uploaded, and downloads should continue as norm...While we're directly connected to a contact we should stop creating files to send to the contact via our own mailbox or the contact's mailbox. Files that have already been created should be uploaded, and downloads should continue as normal.
The mailbox upload worker (#2291) is probably the best place to add this.Mailbox: Manage mailbox connectionsakwizgranakwizgranhttps://code.briarproject.org/briar/briar-mailbox/-/issues/149Send feedback and crash reports via Tor2023-08-28T16:00:11ZakwizgranSend feedback and crash reports via TorSubtask of #82Subtask of #82Mailboxhttps://code.briarproject.org/briar/briar-mailbox/-/issues/148UI for sending feedback and crash reports2023-08-28T16:00:09ZakwizgranUI for sending feedback and crash reportsSubtask of #82.Subtask of #82.Mailboxhttps://code.briarproject.org/briar/briar-mailbox/-/issues/144MainActivity should reset everything to an initial state when recreated with ...2023-01-19T13:09:22ZSebastianMainActivity should reset everything to an initial state when recreated with a fresh lifecycleAs [discussed here](https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/99#note_68817) it can happen that the system tries to restore the activity in a state such as the QR screen while the process is a fresh one with an u...As [discussed here](https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/99#note_68817) it can happen that the system tries to restore the activity in a state such as the QR screen while the process is a fresh one with an unstarted lifecycle. If we do not reset the UI to the initial state, crashes happen.MailboxSebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/2346Scanning Mailbox QR code uses lower half of camera image?2022-07-13T11:03:13ZSebastianScanning Mailbox QR code uses lower half of camera image?Related to #2269. Maybe !1600 hasn't fixed this entirely.
When I scan the Mailbox QR code, I have the feeling it doesn't work so well when arranging the two devices such that the qr code appears right in the preview square in the center...Related to #2269. Maybe !1600 hasn't fixed this entirely.
When I scan the Mailbox QR code, I have the feeling it doesn't work so well when arranging the two devices such that the qr code appears right in the preview square in the center of the briar screen.
Before !1600 I think it used to be so that moving the QR code to the uppermost part of a portrait-oriented briar phone scanned the QR code successfully. That doesn't work any longer, however I can scan very reliably when I position it such that the QR code is in the *lowest* part of the screen, outside of the preview square.Mailbox: Pairinghttps://code.briarproject.org/briar/briar/-/issues/2343End-to-end integration tests for communication via mailbox2023-01-19T13:05:12ZakwizgranEnd-to-end integration tests for communication via mailboxWrite end-to-end integration tests in which two Bramble components, representing a mailbox owner and a contact, communicate via a mailbox running on localhost.
Depends on #2228.Write end-to-end integration tests in which two Bramble components, representing a mailbox owner and a contact, communicate via a mailbox running on localhost.
Depends on #2228.MailboxSebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/2342Briar mailbox setup screen stuck sometimes2022-07-13T11:06:48ZIvanaBriar mailbox setup screen stuck sometimesSteps to reproduce
are visible in the attached videos. Devices used: HTC One M9 and Pixel 2
- In Briar go to settings > Mailbox
- When the Mailbox setup creen is displayed, leave Briar and got to device Settins app to switch the wifi e...Steps to reproduce
are visible in the attached videos. Devices used: HTC One M9 and Pixel 2
- In Briar go to settings > Mailbox
- When the Mailbox setup creen is displayed, leave Briar and got to device Settins app to switch the wifi either on or off
- Then come back to Briar to continue the process
Expected results:
- If wifi is on, then Briar should either restart the mailbox setup process from teh beginning or it should continue where it left off.
Actual results: The same mailbox setup screen is still displayed butnow seems 'stuck' - ie tapping it produces no results
Both devices have the 'do not keep activities' as ON
![device-2022-06-22-150649](/uploads/917c97f8cff62f60e88783dccbdd50e4/device-2022-06-22-150649.mp4)
![device-2022-06-22-135844](/uploads/b695f3114415e37c7d34c9a98929a2c3/device-2022-06-22-135844.mp4)
Steps are visible in the videos attachedMailbox: Pairinghttps://code.briarproject.org/briar/briar/-/issues/2337Briar on PIxel 2 able to link with two mailbox devices2022-07-13T11:04:48ZIvanaBriar on PIxel 2 able to link with two mailbox devicesSteps to reproduce: (17th June)
Install newest version of Briar on Pixel 2 (android 11)
Install newest version of mailbox on Nokia 3.2 (android 10)
Install newest version of mailbox on Samsung 6810 (Android 4.1.2)
Link the Briar app on...Steps to reproduce: (17th June)
Install newest version of Briar on Pixel 2 (android 11)
Install newest version of mailbox on Nokia 3.2 (android 10)
Install newest version of mailbox on Samsung 6810 (Android 4.1.2)
Link the Briar app on Pixel 2 with mailbox app on Nokia 3.2
When both devices show the 'Connected' screens, switch the internet off (at router, modem...)
Both devices show the offline screen. Pixel 2 shows offline screen (briar app) and Nokia 3.2 only shows the offline screen after I tap on Finish.
The Briar offline screen has a button Try again. this works well before the two devices are actually linked, and it gives them the opportunity to try and link again.
However, this button is still available even after they have successfully linked.
Switch the internet back on.
I restart the internet. Nokia 3.2 shows the Mailbox is running screen. Pixel 2 still shows the offline screen. If I tap the Try again button, it leads me to the Scan Mailbox QR code screen.
**- It should show me Mailbox is runnign screen at this point. **
I then take another device (Samsung 6810) and display the QR code. I use the briar app (which is already linked to one mailbox) to scan the code, and the scan goes ahead OK. I get a success screen.
This means that I am able to use briar to connect to two different mailbox devices.
At this point, each of the two mailbox devices is showing Mailbox is running screen, as does the Briar app.
Repeated the same steps twice - it appears to be repeatable.
I have tried to repeat it with another combination ofdevices - HTc E9 One Android 5.0.2, Samsing I9195 (Android 4.4.2) and Nokia 3.2 Android 10. Using HTC as the briar device, I still get the 'Try again'button on the offline screen, and it takes me to the Scan the QR code screen. But scanning doesn't seem to work - ie I just get Unable to connect, Try again. This workflow seems slightly different from the above one, but it is still not correct...Mailbox: PairingIvanaIvanahttps://code.briarproject.org/briar/briar/-/issues/2336DatabaseComponent#getNextSendTime() should consider latency2022-06-17T13:33:31ZakwizgranDatabaseComponent#getNextSendTime() should consider latencyDatabaseComponent#getNextSendTime() returns the earliest retransmission time of any message that's eligible to be sent to a given contact. It should also consider the rule that a message can be retransmitted immediately if the current tr...DatabaseComponent#getNextSendTime() returns the earliest retransmission time of any message that's eligible to be sent to a given contact. It should also consider the rule that a message can be retransmitted immediately if the current transport has lower latency than the transport over which the message was last transmitted.Mailbox: Manage mailbox connectionsakwizgranakwizgranhttps://code.briarproject.org/briar/briar-mailbox/-/issues/139Cannot find geoip.zip2022-06-15T10:03:50ZSebastianCannot find geoip.zipI get a crash during startup and this stacktrace on current `main` (c8cc251327e):
```
2022-06-15 09:59:53.599 19837-19837/? I/o.b.m.c.l.LifecycleManagerImpl: [main] Registering service AndroidTorPlugin
2022-06-15 09:59:54.842 19837-1986...I get a crash during startup and this stacktrace on current `main` (c8cc251327e):
```
2022-06-15 09:59:53.599 19837-19837/? I/o.b.m.c.l.LifecycleManagerImpl: [main] Registering service AndroidTorPlugin
2022-06-15 09:59:54.842 19837-19864/? E/AndroidRuntime: FATAL EXCEPTION: AndroidExecutor
Process: org.briarproject.mailbox, PID: 19837
android.content.res.Resources$NotFoundException: Resource ID #0x0
at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:248)
at android.content.res.ResourcesImpl.openRawResource(ResourcesImpl.java:363)
at android.content.res.Resources.openRawResource(Resources.java:1378)
at android.content.res.Resources.openRawResource(Resources.java:1322)
at org.briarproject.mailbox.core.tor.AndroidTorModule.provideResourceProvider$lambda-0(AndroidTorModule.kt:57)
at org.briarproject.mailbox.core.tor.AndroidTorModule.$r8$lambda$KdQ4hVPDfH1cNYDGSUQ8EZAwDA4(Unknown Source:0)
at org.briarproject.mailbox.core.tor.AndroidTorModule$$ExternalSyntheticLambda0.getResourceInputStream(Unknown Source:2)
at org.briarproject.mailbox.core.tor.TorPlugin.getGeoIpInputStream(TorPlugin.java:322)
at org.briarproject.mailbox.core.tor.TorPlugin.installAssets(TorPlugin.java:285)
at org.briarproject.mailbox.core.tor.TorPlugin.startService(TorPlugin.java:184)
at org.briarproject.mailbox.core.lifecycle.LifecycleManagerImpl.startServices(LifecycleManagerImpl.kt:137)
at org.briarproject.mailbox.android.MailboxService.onCreate$lambda-0(MailboxService.kt:121)
at org.briarproject.mailbox.android.MailboxService.$r8$lambda$nB5tsAdL05RBwWtIkVvT-p8bZe4(Unknown Source:0)
at org.briarproject.mailbox.android.MailboxService$$ExternalSyntheticLambda1.run(Unknown Source:2)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:223)
at org.briarproject.mailbox.core.system.AndroidExecutorImpl.lambda$new$0$org-briarproject-mailbox-core-system-AndroidExecutorImpl(AndroidExecutorImpl.java:51)
at org.briarproject.mailbox.core.system.AndroidExecutorImpl$$ExternalSyntheticLambda0.run(Unknown Source:2)
at java.lang.Thread.run(Thread.java:923)
```
I think this probably got introduced with the recent upgrade of Tor from 3.X to 4.X in !97.Mailbox: TorSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/138Show a warning dialog if Tor detects clock skew2022-07-13T11:03:53ZakwizgranShow a warning dialog if Tor detects clock skewThe Tor plugin should listen for STATUS_GENERAL events from Tor, parse CLOCK_SKEW messages, and use them to broadcast events that can be received by the UI.
The UI should react to these events by showing a warning dialog telling the use...The Tor plugin should listen for STATUS_GENERAL events from Tor, parse CLOCK_SKEW messages, and use them to broadcast events that can be received by the UI.
The UI should react to these events by showing a warning dialog telling the user to check that the device's time, date and timezone are correct (perhaps with some filtering to ensure that we don't show the dialog again immediately after the user has dismissed it).
The dialog should be shown immediately if clock skew is detected while the app's in the foreground. If clock skew is detected while the app is in the background then the dialog should be shown when the app's brought to the foreground. We may be able to use a LiveEvent for this.Mailbox: TorTorsten GroteTorsten Grote