briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-11-07T23:40:58Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/428Common best way to handle unread messages in private chats and forums2022-11-07T23:40:58ZMikolai GütschowCommon best way to handle unread messages in private chats and forumsquoting from https://code.briarproject.org/briar/briar-desktop/-/merge_requests/257#note_72160:
> I've played with it as well, and don't see any real difference either. Some things don't look optimal though: we're using `firstVisibleIte...quoting from https://code.briarproject.org/briar/briar-desktop/-/merge_requests/257#note_72160:
> I've played with it as well, and don't see any real difference either. Some things don't look optimal though: we're using `firstVisibleItemScrollOffset` as the key, which is dependent on a `State`. If I'm not mistaken, this means that as soon as the `scrollState` changes, the encapsulating composable (`UnreadFabs` in this case) will be recomposed. Also, the callback inside `remember` is called as soon as this key changes, which it will all the time during scrolling.
>
> I've compared your implementation with the one for private messages and it looks surprisingly different, using a `produceState` instead. Trying to adopt this here didn't lead to any improvements from what I could tell, so I would opt for leaving it as it was, also dropping the `derivedStateOf` commit.
>
> We should however have a look at this again in the future and try to find a common way of handling unread messages for private chats and forums > new issue.https://code.briarproject.org/briar/briar-desktop/-/issues/425Option to drag and drop images from files browsers etc into private chat views2022-11-04T15:05:18ZSebastianOption to drag and drop images from files browsers etc into private chat viewshttps://code.briarproject.org/briar/briar-mailbox/-/issues/168Dead code in StatusFragment2023-08-28T16:00:10ZSebastianDead code in StatusFragmentIn the StatusFragment, we still have code for changing the fragment if the app detects a no-network situation, however, we actually move to the NoNetwork fragment in the main activity anyway, so this is essentially dead code.
I think we...In the StatusFragment, we still have code for changing the fragment if the app detects a no-network situation, however, we actually move to the NoNetwork fragment in the main activity anyway, so this is essentially dead code.
I think we should either remove that or remove the navigation in the main activity, but having both doesn't make sense.
I think showing the NoNetwork fragment is the simpler solution.https://code.briarproject.org/briar/briar/-/issues/2382Continuation of illustration revamp2022-11-01T17:27:27ZSebastianContinuation of illustration revampWe've had the illustrations revamped recently and added them to the app in !1722, however some screens still use old illustrations or large material icons kind of as illustrations too. Let's replace those eventually. In order to not forg...We've had the illustrations revamped recently and added them to the app in !1722, however some screens still use old illustrations or large material icons kind of as illustrations too. Let's replace those eventually. In order to not forget any of them, let's collect the relevant screens here.https://code.briarproject.org/briar/briar-mailbox/-/issues/167Continuation of illustration revamp2023-08-28T16:00:10ZSebastianContinuation of illustration revampWe've had the illustrations revamped recently and added them to the mailbox app in !124, however some screens still use large material icons kind of as illustrations too. Let's replace those eventually. In order to not forget any of them...We've had the illustrations revamped recently and added them to the mailbox app in !124, however some screens still use large material icons kind of as illustrations too. Let's replace those eventually. In order to not forget any of them, let's collect the relevant screens here.https://code.briarproject.org/briar/briar-desktop/-/issues/423Use High Quality or Vector Icon2022-11-02T04:13:32ZpaulUse High Quality or Vector IconWhen using the task switcher on KDE, the Briar icon is noticeably lower quality than other icons.
![briar-desktop-icon](/uploads/b055b7998bcc63c5e9841a4581f06996/briar-desktop-icon.png)When using the task switcher on KDE, the Briar icon is noticeably lower quality than other icons.
![briar-desktop-icon](/uploads/b055b7998bcc63c5e9841a4581f06996/briar-desktop-icon.png)https://code.briarproject.org/briar/briar/-/issues/2381Image attachment button doesn't get enabled while conversation is open2022-10-31T12:35:50ZakwizgranImage attachment button doesn't get enabled while conversation is openWhen we receive a client versioning message informing us that a contact supports image attachments, the image attachment button in the conversation screen should be enabled. Currently this only happens after leaving and re-entering the c...When we receive a client versioning message informing us that a contact supports image attachments, the image attachment button in the conversation screen should be enabled. Currently this only happens after leaving and re-entering the conversation screen.https://code.briarproject.org/briar/briar/-/issues/2380Include bridge fingerprint in Snowflake params2022-10-28T10:57:09ZakwizgranInclude bridge fingerprint in Snowflake paramsTor Browser includes the bridge fingerprint in the key=value params passed to the Snowflake process, but Briar doesn't. Currently this doesn't matter because the Snowflake binary includes a default fingerprint that's the same as the one ...Tor Browser includes the bridge fingerprint in the key=value params passed to the Snowflake process, but Briar doesn't. Currently this doesn't matter because the Snowflake binary includes a default fingerprint that's the same as the one Tor Browser passes. But we should probably match what Tor Browser is doing so we don't get any surprises if the bridge fingerprint changes.
This would involve adding the fingerprint to the key=value params and removing one of the STUN servers, to keep the total length of the params within the limit.
* https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40665
* https://gitlab.torproject.org/tpo/anti-censorship/team/-/issues/101https://code.briarproject.org/briar/briar/-/issues/2379Hotspot fails to start if hotspot was previously running when app was killed2022-10-28T10:29:52ZakwizgranHotspot fails to start if hotspot was previously running when app was killedIf the app is killed (eg by revoking permissions) while a hotspot is running, it's not possible to start another hotspot until the phone has been rebooted or the phone's wifi has been turned off and on again.
This is a platform bug, but...If the app is killed (eg by revoking permissions) while a hotspot is running, it's not possible to start another hotspot until the phone has been rebooted or the phone's wifi has been turned off and on again.
This is a platform bug, but we might be able to find a workaround. Some things we could try:
* Call removeGroup() and wait for the async response before calling createGroup()
* If the hotspot fails to start, ask the user to turn wifi off and on again, and perhaps open the settings panel that provides a toggle for this (like we do if wifi is turned off when we're preparing to start the hotspot)https://code.briarproject.org/briar/briar/-/issues/2378borders around threads in dark view theme have too little contrast2023-01-31T18:14:28ZRubenborders around threads in dark view theme have too little contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrasthttps://code.briarproject.org/briar/briar/-/issues/2376Feature request: ignoring/hiding/excluding users in forums/groups2023-01-31T18:14:44ZAminda SuomalainenFeature request: ignoring/hiding/excluding users in forums/groupsI have been recently added to multiple forums that are probably wider than Briar is intended for, and I have came across hatespeech that I would prefer to not be subjected to.
Lacking moderation features (https://code.briarproject.org/b...I have been recently added to multiple forums that are probably wider than Briar is intended for, and I have came across hatespeech that I would prefer to not be subjected to.
Lacking moderation features (https://code.briarproject.org/briar/briar/-/issues/512), I would like an option to ignore the user in style of IRC that it just hides all posts that person does. Optionally something to soft-hide requiring me to touch the post would make it visible like is possible on negative karma posts on Reddit, while I am not sure I would like that.
I think the best case scenario let me also not redistribute the hate speech to those I share the forums to, while I guess that might break Briar's design.https://code.briarproject.org/briar/briar-desktop/-/issues/421Visual bug in forum with large author names2023-01-11T21:49:54ZMikolai GütschowVisual bug in forum with large author namesalthough the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)although the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)https://code.briarproject.org/briar/briar/-/issues/2375Android 12 - New installation of Briar under certain conditions - Start Hostp...2022-10-24T11:58:48ZIvanaAndroid 12 - New installation of Briar under certain conditions - Start Hostpot button disabledSteps to reproduce:
- Clean installation of Briar = OK
- "Stop optimising battery usage? " => Allow
- Create Account = OK
- Briar > Settings > Share this app offline (no contacts yet)
- Start Hotspot
- Dialog: Allow Briar Debug access t...Steps to reproduce:
- Clean installation of Briar = OK
- "Stop optimising battery usage? " => Allow
- Create Account = OK
- Briar > Settings > Share this app offline (no contacts yet)
- Start Hotspot
- Dialog: Allow Briar Debug access to devices location?
- I select "Approximate" and "Only this time"
- Start Hotspot screen (again)
- "Location Permission" Dialog "You have denied access to your precise location, but Briar needs this permission to create a wifi hotspot. Please consider granting access". I click OK
- App permissions screen opens = OK
- I tap Permissions, I see location is marked as "Ask every time" - which is OK, as that is what I selected earlier.
- I tap Location and I see the location setting details - the Use Precise Location setting is OFF. I switch it on.
- Then I use the app switcher to go bac to Briar and I see the Start Hotspot screen, but with the Start Hotspot button disabled. See video for details.
Do not keep activities = OFF.
branch tested: 25f99bd7decfb1494462e54c7f92d2a11e025df0
![device-2022-10-24-134926](/uploads/6fbd116207ce0058a516bb0811db1894/device-2022-10-24-134926.mp4)https://code.briarproject.org/briar/public-mesh-testbed/-/issues/1Display own instance name on wifi-direct-rebased branch2022-10-21T14:09:47ZSebastianDisplay own instance name on wifi-direct-rebased branchI'm trying out the wifi-direct-rebased branch. There are quite a bunch of devices visible in the vicinity (fire tv sticks, cars, ...). I figured out I can recognize the testing devices by them having a 6-character instance name (the devi...I'm trying out the wifi-direct-rebased branch. There are quite a bunch of devices visible in the vicinity (fire tv sticks, cars, ...). I figured out I can recognize the testing devices by them having a 6-character instance name (the device names are not very descriptive in some cases). I thought it might make sense to display the device's own instance name so that it's easier to identify which device to click on the other one. (displaying the device name would be nice too, but it seems like that's only available via reflection).https://code.briarproject.org/briar/briar/-/issues/2374Android 12 - hotspot error when nearby devices = ON and location = OFF2022-10-20T13:14:50ZIvanaAndroid 12 - hotspot error when nearby devices = ON and location = OFFSteps to reproduce:
Android 12 device
- Briar build 25f99bd7decfb1494462e54c7f92d2a11e025df0 is running
- in device settings - set the location permission to Off and nearby devices to ON.
- go back to Briar app > settings > share this...Steps to reproduce:
Android 12 device
- Briar build 25f99bd7decfb1494462e54c7f92d2a11e025df0 is running
- in device settings - set the location permission to Off and nearby devices to ON.
- go back to Briar app > settings > share this app offline
- tap Start hotspot
- a dialog box comes up asking the user to select the precise or approximate location...
- select the approximate location
- Start the Hitspot again
- A message comes up asking the user to set the device location to on (or some such)
- User continues and on the following dialog box selects 'change to precise location'.
- The progress circle starts and the hotspot is opening... and then...
- the error message - see attached screens.
If at the start of this process both nearby devices and location are off, then hotspot starts OK
Interesting maybe - if I go back to Briar > settings and restart the process of sharing the app, the process does not restart, but imemdiately the error screen shows again. And If I log out of Briar all together, and log back in, the same thing happens.
![Screenshot_20221020_133441](/uploads/1b32fff4eb4149c9851d677f06b991e8/Screenshot_20221020_133441.png)
![Screenshot_20221020_133502](/uploads/a660d1ee89930a71a604193a628022b2/Screenshot_20221020_133502.png)
![Screenshot_20221020_133515](/uploads/61cbc6014500fd8af49f8ea663131605/Screenshot_20221020_133515.png)
![Screenshot_20221020_133529](/uploads/9862fd1068b92d40f249f0597eb5ae14/Screenshot_20221020_133529.png)
![Screenshot_20221020_133546](/uploads/fa2ee59a4f6415d3c1ee017acf6ae7e0/Screenshot_20221020_133546.png)https://code.briarproject.org/briar/briar/-/issues/2372Restarting the app after having killed it, shows the last screen displayed be...2022-10-19T12:44:00ZIvanaRestarting the app after having killed it, shows the last screen displayed before killing the app -which hangsSteps to reproduce
Android 12, Samsung device
- In Briar app go to contacts screen and tap create a new nearby contact
- go through the steps as required, and Allow briar to access 'nearby devices'
- when the camera is showing, leave t...Steps to reproduce
Android 12, Samsung device
- In Briar app go to contacts screen and tap create a new nearby contact
- go through the steps as required, and Allow briar to access 'nearby devices'
- when the camera is showing, leave the Briar app and go to device settings, and change the 'nearby devices' setting
- This will kill the Briar app -
- log in again
- The first screen that the user sees after the log in is the camera screen again, which hangs... see attached - it is from this screen that I left the Briar app and went to the device settings
-expectation: after the log in, the Briar main screen should be shown and not the camera screen.
the 'do not keep activities' = Off in this case.
This may not be specifically the Android 12 issue... Will try and reproduce with other phones and add comments
![device-2022-10-19-140006](/uploads/bdc3665c4517e133373a76753dd2b438/device-2022-10-19-140006.mp4)https://code.briarproject.org/briar/briar-desktop/-/issues/418When selecting forum post at the bottom, it gets hidden by reply box2022-10-18T12:33:57ZTorsten GroteWhen selecting forum post at the bottom, it gets hidden by reply boxHiding the selected forum post isn't ideal. Maybe we can find a solution here like scrolling the up in this case to keep the item visible.Hiding the selected forum post isn't ideal. Maybe we can find a solution here like scrolling the up in this case to keep the item visible.https://code.briarproject.org/briar/briar-desktop/-/issues/417Enforce custom overloading of IconButton everywhere to support tooltips2022-10-18T12:12:05ZMikolai GütschowEnforce custom overloading of IconButton everywhere to support tooltipsThe following discussion from !250 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/250#note_71894): (+2 comments)
> Please always use our own overloadin...The following discussion from !250 should be addressed:
- [ ] @ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/250#note_71894): (+2 comments)
> Please always use our own overloading of `IconButton` which enables tooltips on desktop. Another rule we should probably write down somewhere or enforce via linting?https://code.briarproject.org/briar/briar/-/issues/2371Adding remote contact on API 19 crashes the app.2022-10-18T16:52:29ZFlyingP1g FlyingP1gAdding remote contact on API 19 crashes the app.I was adding a remote contact with virtual device (Nexus 5x API 19), it crashed without even giving briar crash fragment. (Tested multiple times)
Adding a remote contact with virtual device (Pixel 4a API 31) works ok.
I was using master ...I was adding a remote contact with virtual device (Nexus 5x API 19), it crashed without even giving briar crash fragment. (Tested multiple times)
Adding a remote contact with virtual device (Pixel 4a API 31) works ok.
I was using master branch and the latest comit was this 718d95f3d5426f8bbb65b8c8664874bb4f6ac53d
Steps to reproduce:
1) Add contact at distance
2) adb shell input text 'briar link'
3) Go to the next screen
4) give nickname and press add contact (Note: sometimes briar doesn't crash instantly, but later, I was never able to add a contact.)
5) Briar should crash
Last lines in Logcat:
```
2022-10-16 14:25:12.140 2745-2745/org.briarproject.briar.android.debug W/dalvikvm: VFY: unable to resolve virtual method 2963: Landroid/widget/Button;.setAutoSizeTextTypeWithDefaults (I)V
2022-10-16 14:25:12.140 2745-2745/org.briarproject.briar.android.debug D/dalvikvm: VFY: replacing opcode 0x6f at 0x0004
2022-10-16 14:25:12.140 2745-2745/org.briarproject.briar.android.debug I/BaseActivity: Resuming StartupActivity
2022-10-16 14:25:12.180 2745-2745/org.briarproject.briar.android.debug D/: HostConnection::get() New Host Connection established 0xb8e34bc0, tid 2745
2022-10-16 14:25:12.180 2745-2745/org.briarproject.briar.android.debug D/EGL_emulation: eglCreateContext: 0xb8e33a00: maj 3 min 1 rcv 4
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug D/EGL_emulation: eglMakeCurrent: 0xb8e33a00: ver 3 1
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug E/eglCodecCommon: glUtilsParamSize: unknow param 0x000082da
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug E/eglCodecCommon: glUtilsParamSize: unknow param 0x00008cdf
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug E/eglCodecCommon: glUtilsParamSize: unknow param 0x00008824
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug E/EGL_emulation: tid 2745: eglSurfaceAttrib(1199): error 0x3009 (EGL_BAD_MATCH)
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug W/HardwareRenderer: Backbuffer cannot be preserved
2022-10-16 14:25:12.220 2745-2745/org.briarproject.briar.android.debug D/OpenGLRenderer: Enabling debug mode 0
2022-10-16 14:25:12.250 2745-2745/org.briarproject.briar.android.debug I/dalvikvm: Could not find method android.view.View.setTooltipText, referenced from method androidx.appcompat.widget.TooltipCompat.setTooltipText
2022-10-16 14:25:12.250 2745-2745/org.briarproject.briar.android.debug W/dalvikvm: VFY: unable to resolve virtual method 2302: Landroid/view/View;.setTooltipText (Ljava/lang/CharSequence;)V
2022-10-16 14:25:12.250 2745-2745/org.briarproject.briar.android.debug D/dalvikvm: VFY: replacing opcode 0x6e at 0x0006
2022-10-16 14:25:12.270 2745-2745/org.briarproject.briar.android.debug I/BaseActivity: Stopping NavDrawerActivity
```https://code.briarproject.org/briar/briar-desktop/-/issues/414Visual bugs with Burmese (my)2022-10-13T12:48:23ZMikolai GütschowVisual bugs with Burmese (my)While testing for !253 we found the following problems with the Burmese script:
- the "change password" button text appears to be cropped
![grafik](/uploads/329ee179312c4eea5a0abd0988da7c7b/grafik.png)
compared to the string in the re...While testing for !253 we found the following problems with the Burmese script:
- the "change password" button text appears to be cropped
![grafik](/uploads/329ee179312c4eea5a0abd0988da7c7b/grafik.png)
compared to the string in the resource file:
![grafik](/uploads/7d284e3d101a44a1cd09435a84ea0580/grafik.png)
- "Pending contact selected" text is not centered if it doesn't fit into one line:
![grafik](/uploads/f9a9758b0c842df1da896bd685fb7e97/grafik.png)
in both cases, the character "း" is involved
---
Most probably an upstream issue, we should find a minimal reproducing example and report it to Compose for Desktop.