briar issueshttps://code.briarproject.org/groups/briar/-/issues2021-06-23T11:58:38Zhttps://code.briarproject.org/briar/briar/-/issues/157Re-adding a deleted Contact does not work2021-06-23T11:58:38ZTorsten GroteRe-adding a deleted Contact does not workSteps to Reproduce:
* add each other as contacts
* delete contact on device A
* try to add contact back on device A
* device B will get an error message and not add anything
* device A will have contact from device B back
However, on bo...Steps to Reproduce:
* add each other as contacts
* delete contact on device A
* try to add contact back on device A
* device B will get an error message and not add anything
* device A will have contact from device B back
However, on both devices, the users see each other as offline and can not exchange messages.
This issue is related to issue #2.https://code.briarproject.org/briar/briar/-/issues/2070Unit test for transport key agreement validator2021-06-23T14:08:44ZakwizgranUnit test for transport key agreement validatorTransfer content securely via SD cards and USB memory sticksTorsten GroteTorsten Grote2021-07-31https://code.briarproject.org/briar/briar/-/issues/1468Restrict size of image attachments2021-06-28T08:08:18ZTorsten GroteRestrict size of image attachmentsWe can not process images of arbitrary size, because the device may lack the memory to load the entire image into it or because the maximum texture size is smaller than the image.
* [x] don't read entire images in memory
* [x] scale ful...We can not process images of arbitrary size, because the device may lack the memory to load the entire image into it or because the maximum texture size is smaller than the image.
* [x] don't read entire images in memory
* [x] scale full screen images down to screen size to avoid exceeding max texture size
* [x] add tests for [MarkEnforcingInputStream](https://github.com/bumptech/glide/blob/ad33b8d503024c8a3a6a3da60ce28c4d7732ae58/library/src/main/java/com/bumptech/glide/util/MarkEnforcingInputStream.java)
* [x] tests for our own code that handles the various image types and edge cases
* [x] limit our supported mime types to image/gif, image/jpeg and image/png
* [x] limit the size of images that can be sent
Subtask of #1237.Android 1.3Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/2084Aborted introduction sessions can't be retried2021-06-28T12:48:17ZakwizgranAborted introduction sessions can't be retriedWhile working on #2079 I discovered that if an introduction session is aborted while handling an incoming message, subsequent attempts to retry the introduction (with the same introducer and introducees) will fail.
This happens because ...While working on #2079 I discovered that if an introduction session is aborted while handling an incoming message, subsequent attempts to retry the introduction (with the same introducer and introducees) will fail.
This happens because the sender records the ID of the message that triggered the abort in the session, but the recipient doesn't. Any subsequent message with the same sender and recipient is rejected by the recipient because it depends on the message that triggered the abort, not on that message's predecessor as the recipient expects.Transfer content securely via SD cards and USB memory sticksakwizgranakwizgran2021-07-31https://code.briarproject.org/briar/python-briar-wrapper/-/issues/15Add option to use system's Tor binary2021-06-29T05:57:21ZNicoAdd option to use system's Tor binaryThis is most likely needed for a release to Debian (https://code.briarproject.org/briar/briar-gtk/issues/38).This is most likely needed for a release to Debian (https://code.briarproject.org/briar/briar-gtk/issues/38).https://code.briarproject.org/briar/briar-gtk/-/issues/38Release to Debian2021-06-29T05:57:28ZNicoRelease to DebianDepends on
* https://code.briarproject.org/briar/briar-debian/-/issues/1
* https://code.briarproject.org/briar/python-briar-wrapper/issues/14
* https://code.briarproject.org/briar/briar-gtk/issues/39
* likely also https://code.briarproje...Depends on
* https://code.briarproject.org/briar/briar-debian/-/issues/1
* https://code.briarproject.org/briar/python-briar-wrapper/issues/14
* https://code.briarproject.org/briar/briar-gtk/issues/39
* likely also https://code.briarproject.org/briar/python-briar-wrapper/issues/15https://code.briarproject.org/briar/briar/-/issues/2069Integration test for transport key agreement client2021-07-02T11:11:31ZakwizgranIntegration test for transport key agreement clientTransfer content securely via SD cards and USB memory sticksTorsten GroteTorsten Grote2021-07-31https://code.briarproject.org/briar/briar/-/issues/2091Add a transport property that just indicates that the transport is supported2021-07-02T18:01:34ZakwizgranAdd a transport property that just indicates that the transport is supportedWe need to know whether it's possible to communicate with a given contact via removable drives. The presence of transport keys doesn't necessarily mean the contact supports the transport, as when adding a contact we derive keys for all t...We need to know whether it's possible to communicate with a given contact via removable drives. The presence of transport keys doesn't necessarily mean the contact supports the transport, as when adding a contact we derive keys for all transports we support, without knowing whether the contact also supports them.
For all existing transports we can use transport properties to check whether the contact supports the transport. But the removable drive transport doesn't have any properties.
Add a "supported" property for all transports, so that we can tell which transports a contact supports regardless of whether any properties are needed for establishing a connection.
We may also be able to use this property for key derivation when adding a contact, so that we only derive keys for transports both parties support.Transfer content securely via SD cards and USB memory sticksakwizgranakwizgran2021-07-31https://code.briarproject.org/briar/briar/-/issues/384Create conversation manager2021-07-05T13:41:40ZakwizgranCreate conversation managerThe UI combines private messages, introduction messages and forum sharing messages into a single conversation. This requires various parts of the UI (contact list, conversation view, notification manager) to combine messages from the mes...The UI combines private messages, introduction messages and forum sharing messages into a single conversation. This requires various parts of the UI (contact list, conversation view, notification manager) to combine messages from the messaging, introduction, and forum sharing clients. Create a ConversationManager in the core that deals with combining these messages and presents a unified API (including events) to the UI.https://code.briarproject.org/briar/briar/-/issues/2039Implement HotspotErrorFragment2021-07-06T09:38:42ZTorsten GroteImplement HotspotErrorFragmentWhen the hotspot or the webserver can't start, we should show an error page and include an option to get to the feedback sender, so we can be notified about the issue.When the hotspot or the webserver can't start, we should show an error page and include an option to get to the feedback sender, so we can be notified about the issue.Install via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2055Hide hotspot offline sharing feature behind feature flag2021-07-06T09:38:53ZTorsten GroteHide hotspot offline sharing feature behind feature flagInstall via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2044Decide whether we want to tell people how to disable unknown sources again2021-07-06T09:38:57ZSebastianDecide whether we want to tell people how to disable unknown sources againAfter downloading briar from somebody else's local hotspot, the user has the browser configure to install APKs downloaded from there, which is potentially unsafe. Maybe we should tell them how to disable that at some point (e.g. the same...After downloading briar from somebody else's local hotspot, the user has the browser configure to install APKs downloaded from there, which is potentially unsafe. Maybe we should tell them how to disable that at some point (e.g. the same time we're telling them how to enable that)Install via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2029Make Wi-Fi hotspot SSID and password persistent on API 29+2021-07-06T09:39:02ZTorsten GroteMake Wi-Fi hotspot SSID and password persistent on API 29+This should improve the UX, if they don't change on subsequent attempts.
Subtask of #1081This should improve the UX, if they don't change on subsequent attempts.
Subtask of #1081Install via Bluetooth or Wi-FiTorsten GroteTorsten Grote2021-07-31https://code.briarproject.org/briar/briar/-/issues/2051Rename app.apk to briar-X.Y.apk2021-07-06T09:39:08ZSebastianRename app.apk to briar-X.Y.apkIt probably makes sense to rename `app.apk` to something meaningful like `briar-X.Y.apk` on the hotspot download page, because that's the name it will end up with in the Downloads folder of the recipient. In case someone wants to copy th...It probably makes sense to rename `app.apk` to something meaningful like `briar-X.Y.apk` on the hotspot download page, because that's the name it will end up with in the Downloads folder of the recipient. In case someone wants to copy that over some other medium like email or USB stick, it's going to be easier to find.Install via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2022Implement website for app sharing2021-07-06T09:39:13ZSebastianImplement website for app sharingSubtask of #1081Subtask of #1081Install via Bluetooth or Wi-FiTorsten GroteTorsten Grote2021-07-31https://code.briarproject.org/briar/briar/-/issues/2086QR-Code margin and rounded corners color not white in dark mode2021-07-06T09:39:46ZSebastianQR-Code margin and rounded corners color not white in dark mode![Screen14](/uploads/6382fb9eb7de39e2ad9e04a7e7b30a92/Screen14.png)![Screen14](/uploads/6382fb9eb7de39e2ad9e04a7e7b30a92/Screen14.png)Install via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2087Hotspot view model loses state when activity gets recreated2021-07-06T09:40:01ZSebastianHotspot view model loses state when activity gets recreatedTest instructions:
* Enable the developer option "don't keep activities" (Device Settings → System → Developer options → Apps section → Don't keep activities)
* Open briar
* Go to the share briar offline activity (Briar Settings → Share ...Test instructions:
* Enable the developer option "don't keep activities" (Device Settings → System → Developer options → Apps section → Don't keep activities)
* Open briar
* Go to the share briar offline activity (Briar Settings → Share Briar offline)
* Start sharing (revealing the Wifi configuration for the receiving device)
* Switch to any different app
* Switch back to briar
* Observe that you're back at the intro screen of the offline hotspot feature
* Start sharing again (revealing the Wifi configuration again)
* Make sure that sharing is still working, i.e. connect with a second device and download briar
![Screen16](/uploads/a5d8089ee928db9f41a4d317f1255496/Screen16.png)![Screen15](/uploads/4bea1ed9bfea8f8d5b4626c1541b9d34/Screen15.png)Install via Bluetooth or Wi-FiIvanaIvana2021-07-31https://code.briarproject.org/briar/briar/-/issues/2101Incrementing counter for group info request twice2021-07-06T09:40:25ZSebastianIncrementing counter for group info request twiceI just noticed, when we're requesting group info, I see this output:
```
07-05 12:39:44.503 19900-19900/org.briarproject.briar.android.debug I/HotspotManager: requestGroupInfo attempt: 1
07-05 12:39:45.520 19900-19900/org.briarproject.b...I just noticed, when we're requesting group info, I see this output:
```
07-05 12:39:44.503 19900-19900/org.briarproject.briar.android.debug I/HotspotManager: requestGroupInfo attempt: 1
07-05 12:39:45.520 19900-19900/org.briarproject.briar.android.debug I/HotspotManager: requestGroupInfo attempt: 3
07-05 12:39:46.541 19900-19900/org.briarproject.briar.android.debug I/HotspotManager: requestGroupInfo attempt: 5
```
seems like we increment the `attempt` variable twice.Install via Bluetooth or Wi-FiSebastianSebastian2021-07-31https://code.briarproject.org/briar/briar/-/issues/2024Port code from hotspot test app to Briar2021-07-06T09:40:31ZTorsten GrotePort code from hotspot test app to BriarThe `MainViewModel` and the `WebServer` from the hotspot test app need to be ported to Briar.
Subtask of #1081The `MainViewModel` and the `WebServer` from the hotspot test app need to be ported to Briar.
Subtask of #1081Install via Bluetooth or Wi-FiTorsten GroteTorsten Grote2021-07-31https://code.briarproject.org/briar/briar/-/issues/2028Show a notification for as long as Wi-Fi hotspot is active2021-07-06T09:40:37ZTorsten GroteShow a notification for as long as Wi-Fi hotspot is activeThe notification should have a `Stop sharing` button.
Subtask of #1081The notification should have a `Stop sharing` button.
Subtask of #1081Install via Bluetooth or Wi-FiTorsten GroteTorsten Grote2021-07-31