From 768bb6fc64407d91e82a807983b5788fae84b469 Mon Sep 17 00:00:00 2001
From: ialokim <ialokim@mailbox.org>
Date: Fri, 7 Oct 2022 12:22:38 +0200
Subject: [PATCH] send ClientVersionUpdatedEvent for each client state change,
not only on version updates
---
.../versioning/ClientVersioningManagerImpl.java | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/bramble-core/src/main/java/org/briarproject/bramble/versioning/ClientVersioningManagerImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/versioning/ClientVersioningManagerImpl.java
index 72d5515612..232b71f1bc 100644
--- a/bramble-core/src/main/java/org/briarproject/bramble/versioning/ClientVersioningManagerImpl.java
+++ b/bramble-core/src/main/java/org/briarproject/bramble/versioning/ClientVersioningManagerImpl.java
@@ -228,15 +228,11 @@ class ClientVersioningManagerImpl implements ClientVersioningManager,
Contact contact = db.getContact(txn, c);
callVisibilityHooks(txn, contact, before, after);
}
- // Broadcast events for any new client versions
- Set<ClientVersion> oldRemoteVersions = new HashSet<>();
- for (ClientState cs : oldRemoteStates) {
- oldRemoteVersions.add(cs.clientVersion);
- }
+ // Broadcast events for any client version update
for (ClientState cs : newRemoteStates) {
- if (!oldRemoteVersions.contains(cs.clientVersion)) {
- txn.attach(new ClientVersionUpdatedEvent(c,
- cs.clientVersion));
+ if (!oldRemoteStates.contains(cs)) {
+ txn.attach(
+ new ClientVersionUpdatedEvent(c, cs.clientVersion));
}
}
} catch (FormatException e) {
--
GitLab