From e248419dcaff17a18b7047137352a35ae9c44d8a Mon Sep 17 00:00:00 2001 From: Thomas <3169-thomas@users.noreply.code.briarproject.org> Date: Tue, 8 Nov 2022 19:18:05 +0000 Subject: [PATCH] Address comments --- .../org/briarproject/bramble/crypto/StreamEncrypterImpl.java | 3 ++- .../org/briarproject/bramble/sync/SyncRecordWriterImpl.java | 1 + .../org/briarproject/bramble/transport/StreamWriterImpl.java | 5 +++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/bramble-core/src/main/java/org/briarproject/bramble/crypto/StreamEncrypterImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/crypto/StreamEncrypterImpl.java index 55a4d0c6f0..5425c94869 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/crypto/StreamEncrypterImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/crypto/StreamEncrypterImpl.java @@ -27,6 +27,7 @@ import static org.briarproject.bramble.util.ByteUtils.INT_64_BYTES; /** * See the BTP-Specs to understand whats going on here + * https://code.briarproject.org/briar/briar-spec/blob/master/protocols/BTP.md */ @NotThreadSafe @NotNullByDefault @@ -152,4 +153,4 @@ class StreamEncrypterImpl implements StreamEncrypter { if (writeStreamHeader) writeStreamHeader(); out.flush(); } -} \ No newline at end of file +} diff --git a/bramble-core/src/main/java/org/briarproject/bramble/sync/SyncRecordWriterImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/sync/SyncRecordWriterImpl.java index 7b228e9f4e..4e665d2168 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/sync/SyncRecordWriterImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/sync/SyncRecordWriterImpl.java @@ -28,6 +28,7 @@ import static org.briarproject.bramble.api.sync.SyncConstants.PROTOCOL_VERSION; /** * see the BSP-Specs + * https://code.briarproject.org/briar/briar-spec/blob/master/protocols/BSP.md */ @NotThreadSafe diff --git a/bramble-core/src/main/java/org/briarproject/bramble/transport/StreamWriterImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/transport/StreamWriterImpl.java index 66bf8a5683..a88a76e5dc 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/transport/StreamWriterImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/transport/StreamWriterImpl.java @@ -22,7 +22,7 @@ class StreamWriterImpl extends OutputStream implements StreamWriter { private final StreamEncrypter encrypter; private final byte[] payload; - ///@var length Stores how long the content that is currently in the buffer "payload" is. + /// length Stores how long the content that is currently in the buffer "payload" is. private int length = 0; StreamWriterImpl(StreamEncrypter encrypter) { @@ -69,7 +69,8 @@ class StreamWriterImpl extends OutputStream implements StreamWriter { @Override public void write(byte[] b, int off, int len) throws IOException { //Frame Segmentation - int available = payload.length - length; // available = How much free space ther is at the end of the buffer "payload" + // available = How much free space ther is at the end of the buffer "payload" + int available = payload.length - length; while (available <= len) { System.arraycopy(b, off, payload, length, available); length += available; -- GitLab