Skip to content
Snippets Groups Projects
Commit d139d5d3 authored by Nico's avatar Nico
Browse files

Confirm that Briar Desktop is shutting down like Android

Briar Android's shutdown is handled in `BriarService::onDestroy`

https://code.briarproject.org/briar/briar/-/blob/a53a49e543e3190f329b8608ecec157da4047b89/briar-android/src/main/java/org/briarproject/briar/android/BriarService.java#L206

and `BriaService::shutdownFromBackground`

https://code.briarproject.org/briar/briar/-/blob/a53a49e543e3190f329b8608ecec157da4047b89/briar-android/src/main/java/org/briarproject/briar/android/BriarService.java#L264

There, there are some more Android specific stuff like wakelocks,
`stopForeground()` and `unregisterReceiver()` calls, but in general it
does the same like Desktop: call `stopServices()` and then
`waitForShutdown()`.

As part of this TODO search, I created the following issues and
comments between those two chat logs:
* https://chat.briarproject.org/briar/pl/xq3oewf8q7b7mmzryp7dsimawy
* https://chat.briarproject.org/briar/pl/axa877burpypufhmkb8r4k8m6a

Besides this single TODO I found no other TODO comment either important
enough to create a new issue or comment or eligible to get removed.

Fixes #140
parent d1e668de
No related branches found
No related tags found
1 merge request!113Confirm that Briar Desktop is shutting down like Android
Pipeline #9289 passed
...@@ -89,7 +89,6 @@ constructor( ...@@ -89,7 +89,6 @@ constructor(
} }
override fun stop() { override fun stop() {
// TODO: check how briar is doing this
if (lifecycleManager.lifecycleState == RUNNING) { if (lifecycleManager.lifecycleState == RUNNING) {
lifecycleManager.stopServices() lifecycleManager.stopServices()
lifecycleManager.waitForShutdown() lifecycleManager.waitForShutdown()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment