Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Briar Mailbox Briar Mailbox
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • Briar MailboxBriar Mailbox
  • Merge requests
  • !132

Move stop button below description on status screen

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastian requested to merge 177-move-stop-button-below-status into main Dec 16, 2022
  • Overview 7
  • Commits 1
  • Pipelines 4
  • Changes 1

Closes #177 (closed)

I moved the button below, looks like this:

Screenshot_20221216-090724

On the landscape layout, the icon is so large that the whole layout is too high on pretty standard ratio devices:

Screenshot_20221216-090832

Instead of making this scrollable, I think it's better to decrease the size of the icon. I found the easiest solution to just add a separate layout file for landscape and make the height of the image depend relatively on the screen height on landscape instead of the screen width on portrait. I'd love to make this work with a single layout, however I haven't found any solution that doesn't involve manipulating the constraints from code. The second layout introduced a lot of redundancy, but I think that might be still better than moving away from plain layouts that don't have any code dependencies.

Here's the result with the added landscape layout:

Screenshot_20221216-090749

Edited Dec 16, 2022 by Sebastian
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 177-move-stop-button-below-status