Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 697
    • Issues 697
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Issues
  • #1229

Closed
Open
Opened May 11, 2018 by akwizgran@akwizgranOwner

Crash when creating account after rotating screen

Steps to reproduce:

  • Create a new account and press 'Create Account'
  • Before the next screen is shown, rotate the screen to landscape
  • Rotate the screen back to portrait
  • Press 'Create Account' again

Stacktrace:

    java.lang.IllegalStateException
        at org.briarproject.briar.android.login.SetupControllerImpl.createAccount(SetupControllerImpl.java:88)
        at org.briarproject.briar.android.login.SetupControllerImpl.createAccount(SetupControllerImpl.java:82)
        at org.briarproject.briar.android.login.SetupControllerImpl.showDozeOrCreateAccount(SetupControllerImpl.java:67)
        at org.briarproject.briar.android.login.PasswordFragment.onClick(PasswordFragment.java:117)
        at android.view.View.performClick(View.java:6294)
        at android.view.View$PerformClick.run(View.java:24770)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

There are really two bugs here:

  • The username and password aren't passed from the old SetupControllerImpl instance to the new one
  • The result of the first account creation is returned to the old SetupActivity instance

The second bug is covered by #725, so this ticket is just for the first bug.

Assignee
Assign to
Android 1.0
Milestone
Android 1.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#1229