Activity
assigned to @grote
A couple of minor comments that I didn't want to block the MR with:
- Disabled button text in the light theme is darker than before, which makes it less clear that the button's disabled - would it be a lot of work to change this?
- The delete button in the "Manage RSS Feeds" screen is a black icon on a grey background in both themes. It looks like the button was using some unusual styling already, so I'm not sure whether the fix should be to make the icon white in the dark theme, or to re-style the button in both themes.
Disabled button text in the light theme is darker than before, which makes it less clear that the button's disabled - would it be a lot of work to change this?
No, we just need to introduce a new color in two variants to make it match the old style better.
The delete button in the "Manage RSS Feeds" screen is a black icon on a grey background in both themes. It looks like the button was using some unusual styling already, so I'm not sure whether the fix should be to make the icon white in the dark theme, or to re-style the button in both themes.
We should probably make it look like the reshare button in blog posts:
mentioned in merge request !844 (merged)
-
@anxhelo Two specific questions we had while implementing the dark theme were related to colors. We deferred these for you to look at. The discussion can be found here: !818 (comment 27832)
The first issue is with how to highlight unread messages in threaded discussions (forums or private groups). You can create test data in the settings to see it in action. We used a different background color on a post that fades slowly back to the normal background color. The the light theme, this highlight color is white and for the black theme it is black.
The second issue is with the little bubbles that indicate the number of unread messages. Currently, it uses the
accentcolor which is a slightly lighter blue in the dark theme. So the contrast with the white font isn't great.@akwizgran as guidance from you, is it still true that all changes we are still making to the dark theme should not affect the light theme at all?
-
@grote we've already made some small changes to the light theme, such as the forum background, and if we need to make other small changes so that the dark theme works better, that's fine. But redesigning the light theme is out of scope for this ticket.
mentioned in merge request !861 (merged)
mentioned in commit 881d8034
closed via merge request !861 (merged)
changed milestone to %Android 1.1
mentioned in issue #1358 (closed)
mentioned in merge request !878 (merged)
mentioned in merge request !884 (merged)
closed via merge request !878 (merged)
-
Depends on #1358 (closed), or updating the 9-patches for the dark theme as a temporary solution.
-
From my side everything is done. Not sure if @elioqoshi has something else. Seems the testing just wants non-standard Android settings with more space.
There will be data and results in testing which we can triage ourselves. In this case I believe it's safe to assume without any further changes but keep the testing result notes as a reference for the future if we ever want to have another look. From what I can see, all is good as well on my side. I'd like to have an updated apk however just to be sure we have the latest build @grote. Thanks!