Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 697
    • Issues 697
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Issues
  • #427

Closed
Open
Opened Jun 01, 2016 by Ernir Erlingsson@ernirGuest

Loading authors

Currently, in the forum, the author is loaded like this.

   private void loadAuthor() throws DbException {
		Collection<LocalAuthor> localAuthors =
				identityManager.getLocalAuthors();

		for (LocalAuthor author : localAuthors) {
			if (author == null)
				continue;
			data.setLocalAuthor(author);
			break;
		}
	}

This follows the assumption that the first author (with a null safety check) is the correct author.

  • Am I right to assume that we are following a single author scheme at the moment?
  • Shouldn't we load up the author once, after login, and then just re-use that instance throughout the app ? Heck, we could even inject it.
Assignee
Assign to
Milestone F
Milestone
Milestone F (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#427