Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 785
    • Issues 785
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1016

Resolve main issues with image transition animation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torsten Grote requested to merge 1475-image-transitions into master Dec 13, 2018
  • Overview 22
  • Commits 7
  • Pipelines 6
  • Changes 8

This MR saves the conversation activity list position (only when the activity restarts or is recreated when killed) which hopefully addresses the spurious item overlapping issues.

It also fixes an issue where the animation sometimes wasn't played when clicking on an image in a message with several other images.

Finally, it resolves the broken return animation which was caused by a forced downscroll that the BriarRecyclerView performed when the toolbar was hidden. This might also help with the item overlapping issues.

First part of #1475 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1475-image-transitions