Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 789
    • Issues 789
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1142

Improve handling of missing attachments in UI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge 1585-check-attachment-content-type into master Jun 18, 2019
  • Overview 6
  • Commits 3
  • Pipelines 2
  • Changes 13

This branch improves the handling of missing and invalid attachments.

When an attachment is loaded, the MessagingManager checks that it's an attachment (rather than a private message) and that it has the expected content type. When the UI tries to load the attachments of a private message, it handles NoSuchMessageException by waiting for the attachment to arrive, then trying again. The message is shown without attachments in the meantime.

This branch doesn't completely solve the handling of missing attachments - I think we should show placeholders for missing or invalid attachments, but we can solve that separately after merging this branch.

Edited Jun 19, 2019 by akwizgran
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1585-check-attachment-content-type