Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 786
    • Issues 786
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1150

Bump client minor version to avoid triggering crash

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge 1606-bump-client-minor-version into master Jun 28, 2019
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

This is a sneaky workaround for #1606 (closed). Briar 1.1.7 doesn't consider that a contact supports image attachments unless the client minor version is exactly 1, so it won't take the code path that triggers the bug. Current master considers that a contact supports image attachments if the client minor version is greater than 0, so this branch and current master are still able to exchange images.

We should make a stable release that incorporates the (already merged) fix for #1606 (closed), and new alpha releases for 1.2 and 1.3 that incorporate this fix so they don't crash contacts running older stable releases.

Closes #1606 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1606-bump-client-minor-version