Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 789
    • Issues 789
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1336

Migrate ThreadListController to ViewModel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torsten Grote requested to merge 1881-thread-list-controller into master Jan 08, 2021
  • Overview 72
  • Commits 22
  • Pipelines 7
  • Changes 44

This migration is quite complex. Thorough testing is advised.

It also addresses part of #1891 (closed) by introducing a new SharingController which can be used in ViewModels and exposes LiveData. Some unused and legacy code was removed in the process.

It also fixes the unknown bug that the list scrolling position doesn't get restored when re-entering the discussion.

Closes #1870 (closed), #1873 (closed), #1881 (closed)

Edited Jan 12, 2021 by Torsten Grote
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1881-thread-list-controller