Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 775
    • Issues 775
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Merge requests
  • !1344

Do not create PeerSession for groups we created

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torsten Grote requested to merge 1483-peer-session-crash into master Jan 14, 2021
  • Overview 5
  • Commits 2
  • Pipelines 3
  • Changes 6

Instead, if a contact we are adding is already in one of our groups, re-create the appropriate session. Also, when removing a creator of one of our groups, auto-dissolve the affected groups.

Test instructions (has automatic integration test as well):

  • Add a contact (B), create a private group and share it with the contact (B).
  • Then both contacts (A and B) remove and re-add each other.
  • When the creator (A) tries to share the group, check that no crash happens, other contacts can still be invited and join the group
  • Check that the group is dissolved for (B) who can not be invited again

Closes #1483 (closed)

Edited Feb 01, 2021 by Torsten Grote
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1483-peer-session-crash