Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 789
    • Issues 789
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1355

Condition display of progressbar on a isCreatingAccount LiveData

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Lublin requested to merge 1919-password-fields-not-focusable into master Feb 03, 2021
  • Overview 15
  • Commits 1
  • Pipelines 4
  • Changes 4

Avoiding the mess with saving onSaveInstanceState, and the (in this case) unwanted restoring of it upon back-button tap.

Closes #1919 (closed)

Test instructions:

  • Precondition: fresh install, setting up a new account
    • Testing specific bug fix:
      • Choose a name, tap next
      • Choose a password, tap next
        • Not testable on some devices which display "Create account" instead of "Next"
      • You are now on Background connections screen
      • Tap Back-button ◁
      • Ensure that password can be changed again
    • During setup process, rotate device and ensure that:
      • entered text is kept
      • progressbar is continuously displayed

Please also verify that the following is fixed and can be closed: #1819 (closed) (Create Account-button should never visible when account is already being created)

Edited Feb 22, 2021 by Daniel Lublin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1919-password-fields-not-focusable