Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 788
    • Issues 788
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1601

Make bridge test more robust

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge make-bridge-test-more-robust into master Mar 10, 2022
  • Overview 7
  • Commits 6
  • Pipelines 2
  • Changes 3

This branch tries to make BridgeTest more robust by testing each bridge multiple times and only considering a bridge to be unreachable if it fails every time.

Previously some unreliable obfs4 bridges were randomly passing or failing because our timeout (5 min) was just long enough for Tor to fail to bootstrap, wait, and retry. For a given bridge, sometimes the retry would complete before the timeout and sometimes not. I've reduced the timeout for obfs4 bridges to 2 min so we don't wait and retry (the test has its own retry mechanism already). Since meek is very slow I've increased its timeout to 6 min instead.

Even with 5 retries we're still seeing different bridges failing each time the test is run, so the test now tolerates up to 4 unreachable bridges. I've removed some consistently failing bridges and added a couple more from Tor Browser.

BridgeTest failures block the release pipeline so I'm assigning this to the current milestone and Sponsor 6.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: make-bridge-test-more-robust