Skip to content
Snippets Groups Projects

Turn the UI of `CreateIdentityActivity` into XML

Merged Turn the UI of `CreateIdentityActivity` into XML
395-convert-createidentityactivity-to-xml into master
Merged Torsten Grote requested to merge 395-convert-createidentityactivity-to-xml into master

Closes #395 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
briar-android/src/org/briarproject/android/identity/CreateIdentityActivity.java
107 createIdentityButton.setLayoutParams(WRAP_WRAP);
108 createIdentityButton.setText(R.string.create_identity_button);
109 createIdentityButton.setEnabled(false);
110 createIdentityButton.setOnClickListener(this);
111 layout.addView(createIdentityButton);
112
113 progress = new ProgressBar(this);
114 progress.setLayoutParams(WRAP_WRAP);
115 progress.setIndeterminate(true);
116 progress.setVisibility(GONE);
117 layout.addView(progress);
118
119 setContentView(layout);
89
90 createIdentityButton = (Button) findViewById(R.id.createIdentityButton);
91 if (createIdentityButton != null)
  • str4d
    str4d @str4d ·
    Contributor

    When would createIdentityButton be null?

  • Torsten Grote
    Torsten Grote @grote ·
    Author Owner

    I just put this there to get rid of the warning from Android Studio. It probably is worried about the layout being changed and some point. I thought this is the quickest way to make it shut up.

  • str4d
    str4d @str4d ·
    Contributor

    LGTM!

  • Torsten Grote Status changed to merged

    Status changed to merged

  • Torsten Grote mentioned in commit 886c8feb

    mentioned in commit 886c8feb

  • akwizgran Milestone changed to %Milestone D

    Milestone changed to %Milestone D

    • Please register or sign in to reply