Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 791
    • Issues 791
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !507

Use a polite executor for validation tasks

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged akwizgran requested to merge 675-polite-executor into master Apr 05, 2017
  • Overview 21
  • Commits 5
  • Pipelines 0
  • Changes 10

I tested three solutions to this problem:

  • Use a separate executor for validation crypto tasks
  • Use a separate executor for validation crypto and DB tasks
  • Continue to use the existing executors, but add a queue to prevent validation tasks from blocking the crypto executor (this branch)

All the solutions had comparable performance, so I chose the one that didn't involve adding another executor.

This branch also includes a commit that adds logging to the crypto and DB executors and the DB lock to help with performance measurements. Should be useful for #545 (closed).

@grote you've seen most of this before in !485 (closed).

Closes #675 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 675-polite-executor