Skip to content

Implement Dark Theme (DayNight with automatic option)

Torsten Grote requested to merge 1251-dark-theme into master

This is just a first rough implementation. A real UI designer should look over this.

device-2018-05-26-112459 device-2018-05-26-122358 device-2018-05-26-122554 device-2018-05-26-122917

However, it should be pretty complete. Please test and let me know if you see mis-styled resources. Testing should ideally be done on API 14/15 devices as well as I had to implement some workarounds for those to prevent crashes.

Known Issues:

  • feedback and crash dialog (DevReporterActivity) doesn't want to be styled

I already tried everything to fix this (even upgrading ACRA), but without success. There also doesn't seem to be an issue with Google about this. This MR contains a WIP commit which shows some attempts.

While implementing, I tried to restrain myself from fixing unrelated issues. Some low low-hanging fruits I fixed, but I didn't convert any layouts except in one case where it was the easiest solution (instead of doing compound drawable tinting for API < 23).

Edited by Torsten Grote

Merge request reports