Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 700
    • Issues 700
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Merge Requests
  • !912

Merged
Opened Sep 04, 2018 by Torsten Grote@groteOwner

Use ConversationManager for private message retrieval

  • Overview 73
  • Commits 15
  • Pipelines 7
  • Changes 74

Currently, the ConversationActivity is a big mess. One of the issues is that it needs to collect messages from various clients. This MR moves the message retrieval into the ConversationManager, so it can also be used by the headless client (#1254 (closed)) for the same task.

For the latter, a clear and concise API is important, so this MR also cleans up the various PrivateMessage classes, removes redundant fields and methods, flattens the inheritance hierarchy, etc.

We haven't had real core bugs in some time, so to not let us get too bored, this MR makes this a lot more likely again :P On the bright side, it removes more code than it adds.

One step closer towards finishing #384

Edited Sep 05, 2018 by Torsten Grote
Assignee
Assign to
Reviewer
Request review from
Android 1.2
Milestone
Android 1.2
Assign milestone
Time tracking
Reference: briar/briar!912
Source branch: conversation-manager