Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 789
    • Issues 789
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !928

Fix nonlocalized timestamp

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Julian Dehm requested to merge goapunk/briar:fix_nonlocalized_timestamp into master Sep 19, 2018
  • Overview 53
  • Commits 9
  • Pipelines 21
  • Changes 6

On Android < 6 DateUtils picks up the system language to build strings, therefore the timestamps are shown in the wrong language when anything else than System default is used as language in Briar.

This MR fixes the following things:

  • Update the system configuration on API < 23 so DateUtils picks up the right language
  • Respect the deprecation of updateConfiguration where possible.
  • Skips setting the locale if the os language is used
  • Set the locale only once (on start).
  • Hide languages using the Devanagari script on API 15
  • Hides Asturian on API < 21 because it won't be picked up by Android.
  • Fixes the foreground notification using the old language after account deletion.

I tested the changes (mostly) in the emulator an APIs 15,16, 21,23,28.

closes #1470

Edited Mar 04, 2019 by Julian Dehm
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_nonlocalized_timestamp