Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 791
    • Issues 791
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Wiki
  • pre review checklist

pre review checklist · Changes

Page history
Android UI - Icon Drawables authored Jan 26, 2021 by Torsten Grote's avatar Torsten Grote
Hide whitespace changes
Inline Side-by-side
pre-review-checklist.md
View page @ 4f1057e6
## Java
#### Thread safety
* Classes should be immutable where possible
* Classes that may be used by multiple threads must be thread-safe
......@@ -31,3 +33,13 @@
* Use dedicated lock objects rather than `synchronized`
* Don't call into other classes while holding locks
* Don't start database transactions while holding locks
## Android UI
#### Icon Drawables
* Use `app:srcCompat` instead of `android:src` to define drawables in XML files
* Use `setImageResource()` to set icons instead of `setImageDrawable()`
* If you need to set a drawable directly, but can't use `setImageResource()`, use `VectorDrawableCompat.create()` to get the drawable
* Don't use vector(-only) drawables for notification icons (unless that's supported now)
* Test icon display on API < 21
\ No newline at end of file
Clone repository
  • A Quick Overview of the Protocol Stack
  • Adding support for new architectures in Tor
  • Android Accessibility
  • Android Power Management
  • BDF
  • BQP
  • BSP
  • BTP
  • Blog Client
  • Blog Sharing Client
  • Client API Notes
  • Connect at a distance
  • Create Account
  • Design options for multi block messages
  • Development schedule for private message deletion
View All Pages