Skip to content
Snippets Groups Projects

[WIP] Update emojis and add readme

Closed Nico requested to merge (removed):update-emojis into briar
2 unresolved threads

I added a README with instructions on how to use this project and updated the emojis to their newest masters.

If you allow me this comment: Wow, is this a big mess! C, Go and Python to generate some emojis o_O

Edited by Nico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
README.md 0 → 100644
17
18 Follow [the installation instructions](https://github.com/googlei18n/nototools#installation).
19
20 Run `make` in _noto-emoji_.
21
22 Compile _spritegen_ by running `go build spritegen.go`.
23
24 ## Usage
25
26 Execute `./generate-for-briar.sh`.
27
28 ## What do to next?
29
30 When everything went well, you can go update
31 the new emojis in Briar:
32 [code.briarproject.org/briar/briar/tree/master/briar-android/src/main/assets](https://code.briarproject.org/briar/briar/tree/master/briar-android/src/main/assets)
    • Author Developer

      I almost made it, but short before the end the script fails with this:

      $ ./generate-for-briar.sh 
      Directory noto-emoji/build/briar does already exist.
      Generating sprites...
      2018/07/03 23:12:54 open noto-emoji/build/briar/emoji_u1f471.png: no such file or directory

      Therefore I could not test !1 (comment 28390) and can't do a MR today.

    • Author Developer

      @grote Quick thought: Do I maybe have to update emoji.xml like you did in ca0082f2?

      Just brainstorming, will continue the next days.

    • Yes, you need to grab this file from AOSP source code and if I remember right, comment out some stuff.

    • Btw. did the generation work without upgrading the submodules? Or did this only happen after you upgraded them?

    • Author Developer

      @grote

      you need to grab this file from AOSP source code

      Do you remember from where exactly in the AOSP source code you got it? I searched for it but did not find it anywhere...

      did the generation work without upgrading the submodules?

      I did not try it yesterday, but today it also failed with this slightly different message:

      2018/07/04 09:58:28 open noto-emoji/build/briar/emoji_u1f468_200d_1f469_200d_1f466.png: no such file or directory
    • You can use https://android.googlesource.com/ or https://aosp-mirror.github.io/ but yeah it is hard to find stuff in there.

      today it also failed with this slightly different message

      Strange, better find out why these files are missing.

    • Author Developer

      So I found the source of emoji.xml, @grote mentioned it in his latest PR on upstream's repo. However, the log says it did not get updated in the last two years, meaning there's either nothing to update or the file got moved to another place.

    • Please register or sign in to reply
  • Nico mentioned in issue briar#940 (closed)

    mentioned in issue briar#940 (closed)

  • Hey Nico! Thanks for picking this up!

    Wow, is this a big mess! C, Go and Python to generate some emojis o_O

    Yeah, this is a fork of https://github.com/mcginty/spritegen and was what Signal was using at the time.

    I didn't add any README, because it might conflict with upstream. But upstream seems dead, so we might as well go ahead.

    Good, that you found the briar branch.

  • mentioned in issue briar#1343 (closed)

  • Nico marked as a Work In Progress

    marked as a Work In Progress

  • Nico changed the description

    changed the description

  • Author Developer

    Today I tried it again tackling this MR but did not have success again. In the light of briar#1343 (closed) I don't see much sense in investing more time into this and will therefore close this MR.

  • closed

  • Please register or sign in to reply
    Loading