Skip to content
Snippets Groups Projects
Commit db86545d authored by akwizgran's avatar akwizgran
Browse files

Map output directory instead of repo directory.

parent d7a7d67d
No related branches found
No related tags found
Loading
Checking pipeline status
Loading
  • need to check if the final zip files are still in the right place and are available via CI artifacts

  • akwizgran @akwizgran ·
    Author Owner

    The artifacts are being found and uploaded now, but for some reason the binary jar in the artifacts zip is an empty file (see eg https://code.briarproject.org/briar/tor-reproducer/-/jobs/16877/artifacts/download). The POM and sources jar are fine.

    The hash of the binary jar before uploading matches the hash of the locally built binary jar, which is not an empty file. So somehow the jar is being created correctly, but when it's uploaded as an artifact it ends up empty.

    This didn't happen before changing the mapped path so I'm tempted to just revert to d7a7d67d and call it a day.

  • Wow! this is super strange!?

    Is there anything different about their creation that could explain this?

  • akwizgran @akwizgran ·
    Author Owner

    I can't understand it to be honest. The artifacts are being created properly because they have the right hashes and I can docker cp them from my local container and inspect them. But something about the artifact upload process is leaving one of them empty.

    The only thing that sticks out is that the tor-*.jar pattern matches both the binary and the source jars, while the tor-*-sources.jar pattern also matches the source jar. So maybe somehow in the process of selecting or uploading the files, the binary jar somehow gets clobbered? But this overlap between the patterns was there before, eg with d7a7d67d, and those artifacts were fine.

  • akwizgran @akwizgran ·
    Author Owner

    I removed the duplicate glob pattern and the binary jar is still empty.

    Unfortunately reverting to d7a7d67d is no good, as that commit had an issue with each subsequent job's artifacts including copies of the previous jobs' artifacts. I've moved the output dir out of the build dir to fix this, but the problem with empty artifacts remains.

  • akwizgran @akwizgran ·
    Author Owner

    Finally worked around this by just uploading the whole output dir for the platform. :shrug:

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment