Map output directory instead of repo directory.
-
The artifacts are being found and uploaded now, but for some reason the binary jar in the artifacts zip is an empty file (see eg https://code.briarproject.org/briar/tor-reproducer/-/jobs/16877/artifacts/download). The POM and sources jar are fine.
The hash of the binary jar before uploading matches the hash of the locally built binary jar, which is not an empty file. So somehow the jar is being created correctly, but when it's uploaded as an artifact it ends up empty.
This didn't happen before changing the mapped path so I'm tempted to just revert to d7a7d67d and call it a day.
-
I can't understand it to be honest. The artifacts are being created properly because they have the right hashes and I can
docker cp
them from my local container and inspect them. But something about the artifact upload process is leaving one of them empty.The only thing that sticks out is that the
tor-*.jar
pattern matches both the binary and the source jars, while thetor-*-sources.jar
pattern also matches the source jar. So maybe somehow in the process of selecting or uploading the files, the binary jar somehow gets clobbered? But this overlap between the patterns was there before, eg with d7a7d67d, and those artifacts were fine. -
I removed the duplicate glob pattern and the binary jar is still empty.
Unfortunately reverting to d7a7d67d is no good, as that commit had an issue with each subsequent job's artifacts including copies of the previous jobs' artifacts. I've moved the output dir out of the build dir to fix this, but the problem with empty artifacts remains.