Skip to content
Snippets Groups Projects

Don't clobber built jar when downloading reference jar

Merged akwizgran requested to merge do-not-clobber into master
All threads resolved!

Ever since the path returned by get_final_file_name() was converted to an absolute path in !23 (merged), we seem to have been overwriting the built jar with the reference jar during verification. This meant that we were comparing the hash of the reference jar to itself.

This bug came to light because there aren't yet any reference jars for macOS, so the built jar was being clobbered by an empty file.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Good find, looks good!

  • Sebastian approved this merge request

    approved this merge request

  • Sebastian resolved all threads

    resolved all threads

  • merged

  • akwizgran mentioned in commit 9928ebbb

    mentioned in commit 9928ebbb

  • Please register or sign in to reply
    Loading