Add unit tests for PeerProtocolEngine

briar-tests/src/org/briarproject/briar/privategroup/invitation/AbstractProtocolEngineTest.java

@@ -2,6 +2,7 @@ package org.briarproject.briar.privategroup.invitation;
 
 import org.briarproject.BriarMockTestCase;
 import org.briarproject.bramble.api.client.ClientHelper;
+import org.briarproject.bramble.api.contact.Contact;
 import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.data.BdfDictionary;
 import org.briarproject.bramble.api.data.BdfEntry;
@@ -79,6 +80,9 @@ public abstract class AbstractProtocolEngineTest extends BriarMockTestCase {
 	private final BdfDictionary meta =
 			BdfDictionary.of(new BdfEntry("me", "ta"));
 	protected final ContactId contactId = new ContactId(5);
+	protected final Contact contact =
+			new Contact(contactId, author, new AuthorId(getRandomId()), true,
+					true);
 
 	protected final InviteMessage inviteMessage =
 			new InviteMessage(new MessageId(getRandomId()), contactGroupId,

briar-tests/src/org/briarproject/briar/privategroup/invitation/InviteeProtocolEngineTest.java

@@ -4,6 +4,7 @@ import org.briarproject.bramble.api.contact.Contact;
 import org.briarproject.bramble.api.data.BdfDictionary;
 import org.briarproject.bramble.api.data.BdfEntry;
 import org.briarproject.bramble.api.data.BdfList;
+import org.briarproject.bramble.api.identity.Author;
 import org.briarproject.bramble.api.identity.AuthorId;
 import org.briarproject.bramble.api.identity.LocalAuthor;
 import org.briarproject.bramble.api.sync.Message;
@@ -327,14 +328,17 @@ public class InviteeProtocolEngineTest extends AbstractProtocolEngineTest {
 						privateGroupId, session.getInviteTimestamp() + 1,
 						privateGroup.getName(), privateGroup.getCreator(),
 						privateGroup.getSalt(), "msg", signature);
-		final Contact contact =
-				new Contact(contactId, localAuthor, localAuthor.getId(), true,
+		Author notCreator =
+				new Author(new AuthorId(getRandomId()), "Not Creator",
+						getRandomBytes(5));
+		final Contact notCreatorContact =
+				new Contact(contactId, notCreator, localAuthor.getId(), true,
 						true);
 
 		expectGetContactId();
 		context.checking(new Expectations() {{
 			oneOf(db).getContact(txn, contactId);
-			will(returnValue(contact));
+			will(returnValue(notCreatorContact));
 		}});
 		expectAbortWhenSubscribedToGroup();
 
@@ -351,8 +355,6 @@ public class InviteeProtocolEngineTest extends AbstractProtocolEngineTest {
 						privateGroupId, session.getInviteTimestamp() + 1,
 						privateGroup.getName(), privateGroup.getCreator(),
 						privateGroup.getSalt(), "msg", signature);
-		final Contact contact =
-				new Contact(contactId, author, localAuthor.getId(), true, true);
 		assertEquals(contact.getAuthor(), privateGroup.getCreator());
 
 		expectGetContactId();