Merge branch '112-message-validators' into 'master'
Separate the sync layer from its clients. #112 This patch contains most of the work for #112. MessagingManager and ForumManager have been converted to BSP clients, and the sync layer's message and group formats no longer contain any client-specific data. Each client has a MessageValidator that's called by the ValidationManager to validate messages belonging to the client. A new MessageValidatedEvent informs listeners when a message has been validated. This required some changes to the UI, especially the notification manager. While working on the notification manager I realised it was calling Android API methods from background threads, which may be unsafe, and the notification logic was split across BriarService and AndroidNotificationManagerImpl. So I refactored those classes, along with AndroidExecutorImpl, which was using an unnecessary background thread. Still to do: * Synchronise blocks, not messages * Add message type field to message header as per BSP spec * Convert TransportPropertyManager into a BSP client * Convert SubscriptionUpdates/Acks into forum client messages See merge request !64
Showing
- briar-android/src/org/briarproject/android/AndroidExecutorImpl.java 22 additions, 61 deletions...oid/src/org/briarproject/android/AndroidExecutorImpl.java
- briar-android/src/org/briarproject/android/AndroidNotificationManagerImpl.java 105 additions, 99 deletions.../briarproject/android/AndroidNotificationManagerImpl.java
- briar-android/src/org/briarproject/android/BaseActivity.java 1 addition, 0 deletionsbriar-android/src/org/briarproject/android/BaseActivity.java
- briar-android/src/org/briarproject/android/BriarService.java 31 additions, 75 deletionsbriar-android/src/org/briarproject/android/BriarService.java
- briar-android/src/org/briarproject/android/CrashReportActivity.java 5 additions, 5 deletions...oid/src/org/briarproject/android/CrashReportActivity.java
- briar-android/src/org/briarproject/android/SplashScreenActivity.java 5 additions, 10 deletions...id/src/org/briarproject/android/SplashScreenActivity.java
- briar-android/src/org/briarproject/android/TestingActivity.java 2 additions, 2 deletions...android/src/org/briarproject/android/TestingActivity.java
- briar-android/src/org/briarproject/android/contact/ContactListActivity.java 17 additions, 15 deletions...org/briarproject/android/contact/ContactListActivity.java
- briar-android/src/org/briarproject/android/contact/ContactListAdapter.java 5 additions, 13 deletions.../org/briarproject/android/contact/ContactListAdapter.java
- briar-android/src/org/briarproject/android/contact/ContactListItem.java 5 additions, 5 deletions...src/org/briarproject/android/contact/ContactListItem.java
- briar-android/src/org/briarproject/android/contact/ConversationActivity.java 68 additions, 112 deletions...rg/briarproject/android/contact/ConversationActivity.java
- briar-android/src/org/briarproject/android/contact/ConversationAdapter.java 6 additions, 7 deletions...org/briarproject/android/contact/ConversationAdapter.java
- briar-android/src/org/briarproject/android/contact/ConversationItem.java 15 additions, 7 deletions...rc/org/briarproject/android/contact/ConversationItem.java
- briar-android/src/org/briarproject/android/forum/CreateForumActivity.java 5 additions, 6 deletions...c/org/briarproject/android/forum/CreateForumActivity.java
- briar-android/src/org/briarproject/android/forum/ForumActivity.java 8 additions, 5 deletions...oid/src/org/briarproject/android/forum/ForumActivity.java
- briar-android/src/org/briarproject/android/forum/ForumListActivity.java 11 additions, 18 deletions...src/org/briarproject/android/forum/ForumListActivity.java
- briar-android/src/org/briarproject/android/forum/WriteForumPostActivity.java 10 additions, 10 deletions...rg/briarproject/android/forum/WriteForumPostActivity.java
- briar-android/src/org/briarproject/plugins/droidtooth/DroidtoothPlugin.java 2 additions, 2 deletions...org/briarproject/plugins/droidtooth/DroidtoothPlugin.java
- briar-api/src/org/briarproject/api/UniqueId.java 17 additions, 0 deletionsbriar-api/src/org/briarproject/api/UniqueId.java
- briar-api/src/org/briarproject/api/android/AndroidExecutor.java 6 additions, 5 deletions...api/src/org/briarproject/api/android/AndroidExecutor.java
Loading
Please register or sign in to comment