Skip to content
Snippets Groups Projects
Verified Commit 3da879cf authored by Torsten Grote's avatar Torsten Grote
Browse files

Address review comments for group member list

parent 8fdce5ba
No related branches found
No related tags found
No related merge requests found
......@@ -133,7 +133,7 @@
<activity
android:name=".android.privategroup.memberlist.GroupMemberListActivity"
android:label="@string/app_name"
android:label="@string/groups_member_list"
android:parentActivityName=".android.privategroup.conversation.GroupActivity"
android:windowSoftInputMode="adjustResize|stateHidden">
<meta-data
......
......@@ -140,7 +140,6 @@ public class GroupActivity extends
case R.id.action_group_member_list:
Intent i = new Intent(this, GroupMemberListActivity.class);
i.putExtra(GROUP_ID, groupId.getBytes());
i.putExtra(GROUP_NAME, getTitle());
ActivityOptionsCompat options =
makeCustomAnimation(this, android.R.anim.slide_in_left,
android.R.anim.slide_out_right);
......
......@@ -41,9 +41,6 @@ public class GroupMemberListActivity extends BriarActivity {
byte[] b = i.getByteArrayExtra(GROUP_ID);
if (b == null) throw new IllegalStateException("No GroupId in intent.");
groupId = new GroupId(b);
String name = i.getStringExtra(GROUP_NAME);
if (name == null) throw new IllegalStateException("No name in intent.");
setTitle(name + " " + getString(R.string.groups_member_list));
list = (BriarRecyclerView) findViewById(R.id.list);
LinearLayoutManager linearLayoutManager = new LinearLayoutManager(this);
......
......@@ -5,15 +5,15 @@ import org.briarproject.api.identity.Author.Status;
import org.briarproject.api.nullsafety.NotNullByDefault;
import org.briarproject.api.privategroup.GroupMember;
import javax.annotation.concurrent.NotThreadSafe;
import javax.annotation.concurrent.Immutable;
@NotThreadSafe
@Immutable
@NotNullByDefault
public class MemberListItem {
class MemberListItem {
private final Author member;
private Status status;
private boolean sharing;
private final Status status;
private final boolean sharing;
public MemberListItem(GroupMember groupMember) {
this.member = groupMember.getAuthor();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment