Moved lifecycle management into briar-core and reconfigured executors.
CryptoExecutor and DatabaseExecutor now use bounded thread pools with unbounded queues, since running too many tasks in parallel is likely to harm performance; IncomingConnectionExecutor, PluginExecutor and ReliabilityExecutor use unbounded thread pools with direct handoff, since their tasks may run indefinitely. There are no longer any bounded executors, and all executors discard tasks when shutting down, which fixes issue #3612189. Responsibility for starting and stopping services has been moved from BriarService in briar-android to LifecycleManagerImpl in briar-core. However, BriarService is still responsible for stopping the Android-specific executors, which is ugly. It would be better if executors registered themselves with LifecycleManager.
Showing
- briar-android/src/net/sf/briar/android/AndroidModule.java 20 additions, 8 deletionsbriar-android/src/net/sf/briar/android/AndroidModule.java
- briar-android/src/net/sf/briar/android/BriarService.java 26 additions, 74 deletionsbriar-android/src/net/sf/briar/android/BriarService.java
- briar-android/src/net/sf/briar/android/HomeScreenActivity.java 11 additions, 9 deletions...-android/src/net/sf/briar/android/HomeScreenActivity.java
- briar-android/src/net/sf/briar/android/blogs/BlogActivity.java 3 additions, 16 deletions...-android/src/net/sf/briar/android/blogs/BlogActivity.java
- briar-android/src/net/sf/briar/android/blogs/BlogListActivity.java 5 additions, 18 deletions...roid/src/net/sf/briar/android/blogs/BlogListActivity.java
- briar-android/src/net/sf/briar/android/blogs/ConfigureBlogActivity.java 4 additions, 17 deletions...src/net/sf/briar/android/blogs/ConfigureBlogActivity.java
- briar-android/src/net/sf/briar/android/blogs/CreateBlogActivity.java 4 additions, 17 deletions...id/src/net/sf/briar/android/blogs/CreateBlogActivity.java
- briar-android/src/net/sf/briar/android/blogs/ManageBlogsActivity.java 3 additions, 16 deletions...d/src/net/sf/briar/android/blogs/ManageBlogsActivity.java
- briar-android/src/net/sf/briar/android/blogs/ReadBlogPostActivity.java 4 additions, 17 deletions.../src/net/sf/briar/android/blogs/ReadBlogPostActivity.java
- briar-android/src/net/sf/briar/android/blogs/WriteBlogPostActivity.java 5 additions, 18 deletions...src/net/sf/briar/android/blogs/WriteBlogPostActivity.java
- briar-android/src/net/sf/briar/android/contact/ContactListActivity.java 3 additions, 16 deletions...src/net/sf/briar/android/contact/ContactListActivity.java
- briar-android/src/net/sf/briar/android/groups/ConfigureGroupActivity.java 4 additions, 17 deletions...c/net/sf/briar/android/groups/ConfigureGroupActivity.java
- briar-android/src/net/sf/briar/android/groups/CreateGroupActivity.java 4 additions, 17 deletions.../src/net/sf/briar/android/groups/CreateGroupActivity.java
- briar-android/src/net/sf/briar/android/groups/GroupActivity.java 3 additions, 16 deletions...ndroid/src/net/sf/briar/android/groups/GroupActivity.java
- briar-android/src/net/sf/briar/android/groups/GroupListActivity.java 5 additions, 18 deletions...id/src/net/sf/briar/android/groups/GroupListActivity.java
- briar-android/src/net/sf/briar/android/groups/ManageGroupsActivity.java 3 additions, 16 deletions...src/net/sf/briar/android/groups/ManageGroupsActivity.java
- briar-android/src/net/sf/briar/android/groups/ReadGroupPostActivity.java 5 additions, 18 deletions...rc/net/sf/briar/android/groups/ReadGroupPostActivity.java
- briar-android/src/net/sf/briar/android/groups/WriteGroupPostActivity.java 5 additions, 18 deletions...c/net/sf/briar/android/groups/WriteGroupPostActivity.java
- briar-android/src/net/sf/briar/android/identity/CreateIdentityActivity.java 3 additions, 17 deletions...net/sf/briar/android/identity/CreateIdentityActivity.java
- briar-android/src/net/sf/briar/android/invitation/AddContactActivity.java 3 additions, 11 deletions...c/net/sf/briar/android/invitation/AddContactActivity.java
Loading
Please register or sign in to comment