Skip to content
Snippets Groups Projects
Commit 6b79cbfc authored by akwizgran's avatar akwizgran
Browse files

No need to call getResources() for getString().

parent d755668b
No related branches found
No related tags found
No related merge requests found
...@@ -17,6 +17,8 @@ ...@@ -17,6 +17,8 @@
<string name="startup_failed_notification_text">You may need to reinstall Briar.</string> <string name="startup_failed_notification_text">You may need to reinstall Briar.</string>
<string name="expiry_warning">This software has expired.\nPlease install a newer version.</string> <string name="expiry_warning">This software has expired.\nPlease install a newer version.</string>
<string name="contact_list_button">Contacts</string> <string name="contact_list_button">Contacts</string>
<string name="delete_contact">Delete contact</string>
<string name="contact_deleted_toast">Contact deleted</string>
<string name="forums_button">Forums</string> <string name="forums_button">Forums</string>
<string name="settings_button">Settings</string> <string name="settings_button">Settings</string>
<string name="sign_out_button">Sign Out</string> <string name="sign_out_button">Sign Out</string>
......
...@@ -39,7 +39,6 @@ import org.briarproject.api.messaging.MessageId; ...@@ -39,7 +39,6 @@ import org.briarproject.api.messaging.MessageId;
import org.briarproject.util.StringUtils; import org.briarproject.util.StringUtils;
import android.content.Intent; import android.content.Intent;
import android.content.res.Resources;
import android.os.Bundle; import android.os.Bundle;
import android.text.InputType; import android.text.InputType;
import android.view.View; import android.view.View;
...@@ -168,8 +167,7 @@ implements OnClickListener { ...@@ -168,8 +167,7 @@ implements OnClickListener {
private void displayLocalAuthor() { private void displayLocalAuthor() {
runOnUiThread(new Runnable() { runOnUiThread(new Runnable() {
public void run() { public void run() {
Resources res = getResources(); String format = getString(R.string.format_from);
String format = res.getString(R.string.format_from);
String name = localAuthor.getName(); String name = localAuthor.getName();
from.setText(String.format(format, name)); from.setText(String.format(format, name));
sendButton.setEnabled(true); sendButton.setEnabled(true);
......
...@@ -139,7 +139,7 @@ implements InvitationListener { ...@@ -139,7 +139,7 @@ implements InvitationListener {
} }
private void showToastAndFinish() { private void showToastAndFinish() {
String format = getResources().getString(R.string.contact_added_toast); String format = getString(R.string.contact_added_toast);
String text = String.format(format, contactName); String text = String.format(format, contactName);
Toast.makeText(this, text, LENGTH_LONG).show(); Toast.makeText(this, text, LENGTH_LONG).show();
finish(); finish();
......
...@@ -6,7 +6,6 @@ import static android.view.Gravity.CENTER_HORIZONTAL; ...@@ -6,7 +6,6 @@ import static android.view.Gravity.CENTER_HORIZONTAL;
import org.briarproject.R; import org.briarproject.R;
import android.content.Context; import android.content.Context;
import android.content.res.Resources;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.LinearLayout; import android.widget.LinearLayout;
import android.widget.TextView; import android.widget.TextView;
...@@ -50,8 +49,8 @@ class ConfirmationCodeView extends AddContactView implements CodeEntryListener { ...@@ -50,8 +49,8 @@ class ConfirmationCodeView extends AddContactView implements CodeEntryListener {
addView(code); addView(code);
CodeEntryView codeEntry = new CodeEntryView(ctx); CodeEntryView codeEntry = new CodeEntryView(ctx);
Resources res = getResources(); String enter = container.getString(R.string.enter_confirmation_code);
codeEntry.init(this, res.getString(R.string.enter_confirmation_code)); codeEntry.init(this, enter);
addView(codeEntry); addView(codeEntry);
} }
......
...@@ -44,7 +44,7 @@ class ConnectionView extends AddContactView { ...@@ -44,7 +44,7 @@ class ConnectionView extends AddContactView {
TextView connecting = new TextView(ctx); TextView connecting = new TextView(ctx);
int remoteCode = container.getRemoteInvitationCode(); int remoteCode = container.getRemoteInvitationCode();
String format = ctx.getResources().getString(R.string.searching_format); String format = container.getString(R.string.searching_format);
connecting.setText(String.format(format, remoteCode)); connecting.setText(String.format(format, remoteCode));
innerLayout.addView(connecting); innerLayout.addView(connecting);
......
...@@ -5,7 +5,6 @@ import static android.view.Gravity.CENTER_HORIZONTAL; ...@@ -5,7 +5,6 @@ import static android.view.Gravity.CENTER_HORIZONTAL;
import org.briarproject.R; import org.briarproject.R;
import android.content.Context; import android.content.Context;
import android.content.res.Resources;
import android.widget.TextView; import android.widget.TextView;
class InvitationCodeView extends AddContactView implements CodeEntryListener { class InvitationCodeView extends AddContactView implements CodeEntryListener {
...@@ -32,8 +31,8 @@ class InvitationCodeView extends AddContactView implements CodeEntryListener { ...@@ -32,8 +31,8 @@ class InvitationCodeView extends AddContactView implements CodeEntryListener {
addView(code); addView(code);
CodeEntryView codeEntry = new CodeEntryView(ctx); CodeEntryView codeEntry = new CodeEntryView(ctx);
Resources res = getResources(); String enter = container.getString(R.string.enter_invitation_code);
codeEntry.init(this, res.getString(R.string.enter_invitation_code)); codeEntry.init(this, enter);
addView(codeEntry); addView(codeEntry);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment