Skip to content
Snippets Groups Projects
Commit 8141a97f authored by akwizgran's avatar akwizgran
Browse files

Merge branch '1015-recent-emoji-crash' into 'master'

Prevent a crash caused by empty emoji

Closes #1015

See merge request !571
parents 6dbec3a8 db842bd7
No related branches found
No related tags found
No related merge requests found
...@@ -104,8 +104,9 @@ public class EmojiPageView extends FrameLayout { ...@@ -104,8 +104,9 @@ public class EmojiPageView extends FrameLayout {
emojiSize + 2 * pad)); emojiSize + 2 * pad));
view = emojiView; view = emojiView;
} }
String emoji = model.getEmoji()[position];
view.setEmoji(emoji);
view.setEmoji(model.getEmoji()[position]);
return view; return view;
} }
} }
......
...@@ -32,7 +32,7 @@ public class RecentEmojiPageModel implements EmojiPageModel { ...@@ -32,7 +32,7 @@ public class RecentEmojiPageModel implements EmojiPageModel {
private static final Logger LOG = private static final Logger LOG =
Logger.getLogger(RecentEmojiPageModel.class.getName()); Logger.getLogger(RecentEmojiPageModel.class.getName());
private static final String EMOJI_LRU_PREFERENCE = "pref_emoji_recent"; private static final String EMOJI_LRU_PREFERENCE = "pref_emoji_recent2";
private static final int EMOJI_LRU_SIZE = 50; private static final int EMOJI_LRU_SIZE = 50;
private final LinkedHashSet<String> recentlyUsed; // UI thread private final LinkedHashSet<String> recentlyUsed; // UI thread
...@@ -98,12 +98,12 @@ public class RecentEmojiPageModel implements EmojiPageModel { ...@@ -98,12 +98,12 @@ public class RecentEmojiPageModel implements EmojiPageModel {
} }
private String serialize(LinkedHashSet<String> emojis) { private String serialize(LinkedHashSet<String> emojis) {
return StringUtils.join(emojis, ";"); return StringUtils.join(emojis, "\t");
} }
private LinkedHashSet<String> deserialize(@Nullable String serialized) { private LinkedHashSet<String> deserialize(@Nullable String serialized) {
if (serialized == null) return new LinkedHashSet<>(); if (serialized == null) return new LinkedHashSet<>();
String[] list = serialized.split(";"); String[] list = serialized.split("\t");
LinkedHashSet<String> result = new LinkedHashSet<>(list.length); LinkedHashSet<String> result = new LinkedHashSet<>(list.length);
Collections.addAll(result, list); Collections.addAll(result, list);
return result; return result;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment