Skip to content
Snippets Groups Projects
  1. Sep 28, 2016
  2. Sep 13, 2016
    • Torsten Grote's avatar
      Merge branch '619-validation-transactions' into 'master' · 2fbbb663
      Torsten Grote authored
      Refactor ValidationManager and fix some bugs
      
      The validation manager uses a pattern of throwing an exception from within a transaction, then trying to ensure that the transaction gets committed anyway by setting it complete in a finally block. This is a bad idea - if the intentional exception isn't thrown but a later method throws an unintentional exception, the changes up to that point will be committed instead of rolled back.
      
      I reworked the control flow to remove this pattern, and in the process realised that the validation manager was doing a lot of work to provide objects to attach to MessageStateChangedEvents, which are only used by tests these days. So I fixed that and a couple of other issues.
      
      The VALID state is no longer needed and has been removed.
      
      Closes #619
      
      See merge request !313
      2fbbb663
  3. Sep 12, 2016
  4. Sep 09, 2016
  5. Sep 08, 2016
  6. Sep 07, 2016
  7. Sep 06, 2016
  8. Sep 05, 2016
  9. Sep 02, 2016
  10. Sep 01, 2016
Loading