Remove placeholder tests

See merge request !491

Evidently this way of nagging myself to write tests doesn't work.

Don't make DNS lookups during RSS import

Closes #908

See merge request !488

Make Tor boot more verbose

See merge request !486

Remove error state and reset session on error instead

Closes #900

See merge request !484

Remove REMOTE_LEFT state from sharing client state machine

See merge request !483

Signed-off-by: goapunk <noobie@goapunks.net>

(cherry picked from commit e26f663)

Signed-off-by: noobie <noobie@goapunks.net>

Merge branch '877-save-invitation-outcome-to-invitation-message-and-make-available-to-ui' into 'master'

Store invitation outcome in metadata and make it available to the UI

This MR is based on !479 and should only be merged after that one has been merged as well.

It stores the invitation outcome in the message metadata  and includes it in the `canBeOpened()` calculation for private groups and sharables.

Closes #877

See merge request !480

Migrate blog sharing to new sharing client infrastructure

This MR contains a second small commit that fixes #816 and adds a test for it.

Closes #476, #701

See merge request !479

and include in canBeOpened calculation for private groups and sharables.

Fixes #816

Check the blog item in NavDrawer when opening a blog via notification

There are three scenarios where the selected item in the NavDrawer changes:
1. The user selects an item -> the item is checked automatically.
2. The user pressed back -> already handled in onBackPressed (needs to be extended with #606)
3. The user touched a notification -> handled by this commit.
   
Signed-off-by: goapunk <noobie@goapunks.net>

Closes #889

See merge request !481

Stop periodic list update only once

When testing the forum unread code, I noticed the recycler view is detaching twice. Once because the stop method is called and once because the view detaches from the window. Wouldn't it be safe to null the refresher when the updates are stopped?

See merge request !478

Signed-off-by: goapunk <noobie@goapunks.net>

Remove code for collapsing threads and for reply count

Besides removing lots of code, this MR also improves the encapsulation between adapter and view holders.

Closes #478, #502, #526, #682,  #683,  #835,  #836

See merge request !477

Threaded Unread Handling

![unread](/uploads/457c3bc36c897d683ff8161b4f3a344c/unread.mp4)

This leaves in the collapsing code for now and just hides the UI element for collapsing. The code can be removed in a second pass to simplify the adapter.

Closes #879

See merge request !476

New Forum Sharing Client

This is very similar to how the private group invitations work and I am sure there's still some tiny bugs that I didn't catch.

All existing integration tests either pass or have been modified to pass.

Once this has been merged, the code should be usable for blog sharing as well.

Closes #475

See merge request !467

Fix ForumActivityTest and get rid of redundant theme definition

Closes #881

See merge request !474

Fix memory leaks caused by periodic view refreshing tasks

This branch implements @goapunk's suggested solution to #851. Credit goes to @ernir for finding the bug and the initial solution, and @goapunk for the improved solution - I just did a quick implementation so we can get this fixed as quickly as possible.

Closes #851

See merge request !473

Merge branch '710-conversationactivity-uses-uninitialised-field-as-format-string-argument' into 'master'

Make sure contact name is initialized when needed

This uses a Listenable Future and unfortunately requires 4 basically identical methods to handle the incoming events. Any suggestions for improving that are welcome.

Closes #710

See merge request !472

Do not log information from RSS feeds

Closes #882

See merge request !475