Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 786
    • Issues 786
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1010

UX for displaying multiple image attachments

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torsten Grote requested to merge 1473-display-multiple-images into master Dec 06, 2018
  • Overview 17
  • Commits 5
  • Pipelines 5
  • Changes 22

This MR shows multiple images in the private conversation where before only one image was shown. It is the bulk of the work to support multiple images. The RecyclerView it uses is recycling views over several distinct messages and can be used to display a preview of images to be attached as well.

For simplicity, multiple images within one message bubble are fixed to two columns. If a message contains an odd number of images, the last images will span both columns and get center cropped.

The corner rounding transformation has been replaced with a new one that allows us to specify a radius for each image's corner individually.

device-2018-12-06-173309

Closes #1473 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1473-display-multiple-images