Introduce ViewModel for ForumListFragment

Closes #1869 (closed)

changed milestone to %Adapt to changes in the Android platform

added Sponsor 6 label

@sebkur @quite if you are interested how to set up a new ViewModel with the new DbViewModel and ListAdapter plumping, have a look at the first two commits in this MR.

Looks good! Just some very minor comments. Looks like there's some scope for code sharing with the group list, but I respect your self-control in applying the rule of three. :-)

resolved all threads

added 10 commits

• eace3b48...04517e94 - 6 commits from branch master
• a9cd40fa - Add transactions to methods in ForumManager
• e2e67edb - Introduce ForumListViewModel
• 3b027976 - Block forum post notifications while viewing forum list
• 921e952b - Rename ForumItem to ForumPostItem

Compare with previous version

Looks good! Just some very minor comments.

I rebased against master and pushed the else if fix.

Looks like there's some scope for code sharing with the group list, but I respect your self-control in applying the rule of three. :-)

Yeah your rule of three post changed my perspective on code sharing somewhat. Also seeing the insane lengths we went to in the ThreadListController and other places to be able to share some code made me reconsider the benefits. In the end, I think most of that ended up to be harder to maintain and understand.

Where's that post on the rule of three?

https://andrewbrookins.com/technology/the-rule-of-three/

merged

mentioned in commit 0dc631b7