Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 784
    • Issues 784
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1357

Finish migrating KeyAgreementActivity to ViewModel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torsten Grote requested to merge 1872-key-agreement into master Feb 04, 2021
  • Overview 84
  • Commits 21
  • Pipelines 15
  • Changes 28

The code has been refactored substantially (though almost all functionality should have stayed the same), so a faster way to review the code might be to check out the nearby package in Android studio and otherwise look at the diffs of the individual commits.

Test instructions:

  • Add two contacts with the nearby option
  • try all sorts of variations and complications when doing it:
    • revoke permissions in system settings for briar
    • rotate screen in odd places through the process (especially before pressing the Next button)
    • disable wifi and/or bluetooth of the phone and/or in briar itself (before starting to add contacts)

Closes #1872 (closed)

Edited Apr 09, 2021 by Torsten Grote
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1872-key-agreement