Skip to content
Snippets Groups Projects

Implement UX for when a group has been dissolved

Merged Torsten Grote requested to merge 672-implement-ux-for-dissolving-a-group into master
1 unresolved thread

This MR is based on !367 (merged).

Closes #672 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Torsten Grote Milestone changed to %Milestone E

    Milestone changed to %Milestone E

  • Torsten Grote Added 32 commits:

    Added 32 commits:

    • d87a9d75...40557512 - 31 commits from branch 671-implement-ux-for-leaving-a-group
    • aa61dcad - Implement UX for when a group has been dissolved
  • akwizgran
  • Torsten Grote Added 8 commits:

    Added 8 commits:

    • aa61dcad...8dac2d1c - 6 commits from branch 671-implement-ux-for-leaving-a-group
    • 67866dbe - Implement UX for when a group has been dissolved
    • 1147b8ff - Disable group before loading messages
  • Torsten Grote Resolved all discussions

    Resolved all discussions

  • akwizgran Resolved all discussions

    Resolved all discussions

  • 143 161 return R.string.groups_message_received;
    144 162 }
    145 163
    164 @Override
    165 public void onReplyClick(GroupMessageItem item) {
    166 if (!isDissolved) super.onReplyClick(item);
    167 }
    168
    169 private void setGroupEnabled(boolean enabled) {
    170 isDissolved = !enabled;
    171 if (writeMenuItem != null) writeMenuItem.setVisible(enabled);
    172 textInput.setSendButtonEnabled(enabled);
    173 list.getRecyclerView().setAlpha(enabled ? 1f : 0.5f);
    • Per @ernir's comment the other day, at some point we should factor out the alpha constants so we can use a consistent disabled style across the app. Not a blocker for this MR though.

    • Please register or sign in to reply
  • akwizgran Target branch changed from 671-implement-ux-for-leaving-a-group to master

    Target branch changed from 671-implement-ux-for-leaving-a-group to master

  • akwizgran Status changed to merged

    Status changed to merged

  • akwizgran mentioned in commit 0b11aea7

    mentioned in commit 0b11aea7

  • Please register or sign in to reply
    Loading